From: Richard Guenther <richard.guenther@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Andrew Pinski <pinskia@gmail.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: PATCH: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)
Date: Sun, 06 Mar 2011 23:23:00 -0000 [thread overview]
Message-ID: <AANLkTikDiE4OQ5ctMxkevr_V=Oy_UvJbSRjOGPcaeg_K@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=ZAh1LjOPX=gnS3wL0KXDe7ZyHcmPaSTqDKqxG@mail.gmail.com>
On Sun, Mar 6, 2011 at 10:28 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sun, Mar 6, 2011 at 1:15 PM, Andrew Pinski <pinskia@gmail.com> wrote:
>> On Sun, Mar 6, 2011 at 9:18 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>>> Hi,
>>>
>>> We shouldn't save call frame hard registers as "void *". This patch
>>> changes the unwind library to save call frame hard registers as
>>> _Unwind_Word. OK for 4.7?
>>
>> I think this will break the ABI for the MIPS N32 ABI. Not to mention
>> the MIPS N32 ABI works fine with the unwinding part this way. Does
>> someone use the unwinding library to look at the registers in previous
>> stack frames?
>
> It may be psABI/implementation specific. X32 glibc force unwind calls
> _Unwind_SetGRValue to get a 64bit register value.
So fix it on that side?
Richard.
next prev parent reply other threads:[~2011-03-06 23:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 17:18 H.J. Lu
2011-03-06 21:15 ` Andrew Pinski
2011-03-06 21:28 ` H.J. Lu
2011-03-06 23:23 ` Richard Guenther [this message]
2011-03-06 23:40 ` H.J. Lu
2011-03-07 0:15 ` H.J. Lu
2011-03-14 17:49 ` H.J. Lu
2011-03-21 21:56 ` Ian Lance Taylor
2011-03-22 4:19 ` H.J. Lu
2011-03-22 6:32 ` Ian Lance Taylor
2011-03-22 15:19 ` Ulrich Weigand
2011-03-22 15:41 ` Jakub Jelinek
2011-03-22 16:42 ` Ian Lance Taylor
2011-03-22 16:52 ` Andrew Pinski
2011-03-22 18:58 ` Ian Lance Taylor
2011-03-22 19:30 ` Ulrich Weigand
2011-03-22 22:18 ` Ian Lance Taylor
2011-03-23 3:25 ` H.J. Lu
2011-03-23 4:53 ` Ian Lance Taylor
2011-03-23 5:01 ` H.J. Lu
2011-03-23 13:58 ` Ian Lance Taylor
2011-03-23 17:50 ` Richard Henderson
2011-03-23 18:04 ` Jakub Jelinek
2011-03-23 18:20 ` Richard Henderson
2011-03-23 18:24 ` H.J. Lu
2011-03-23 18:27 ` Richard Henderson
2011-03-23 18:37 ` Jakub Jelinek
2011-03-23 19:01 ` Richard Henderson
2011-03-23 19:17 ` Jakub Jelinek
2011-03-23 19:22 ` Ulrich Weigand
2011-03-24 7:15 ` H.J. Lu
2011-04-10 1:52 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikDiE4OQ5ctMxkevr_V=Oy_UvJbSRjOGPcaeg_K@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).