Re: [PATCH C] Fix pr44517

["Manuel López-Ibáñez" <lopezibanez@gmail.com>]

On 22 June 2010 11:04, Shujing Zhao <pearly.zhao@oracle.com> wrote:
> On 06/22/2010 03:40 PM, Manuel López-Ibáńez wrote:
>>
>> On 22 June 2010 09:05, Shujing Zhao <pearly.zhao@oracle.com> wrote:
>>>
>>> Hi,
>>>
>>> This patch tries to improve diagnostic for wrong type name in function
>>> declaration. It also changes the algorithm of function
>>> c_parser_parms_list_declarator. If one of parameter declaration is wrong,
>>> c_parser_parms_list_declarator would return NULL, not an empty parameter
>>> information struct. A test case is added to test this change.
>>>
>>
>> Great! One minor nit:
>>
>> -               }
>> +               return false;
>>            }
>>
>> This should be return NULL.
>>
>> Don't need to send a new patch for this. Just wait for approval.
>
> Oops, sorry. Gcc didn't detect it, is it because both 'false' and 'NULL' are
> 0? is it a bug?

It isn't a bug. The behaviour should be the same. But for the sake of
clarity, we should return NULL for pointers and false only for bool.

Cheers,

Manuel.