public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: Janus Weil <janus@gcc.gnu.org>
Cc: gfortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran] PR 42051,43896: [OOP] ICE in gfc_conv_variable, 	at fortran/trans-expr.c:551
Date: Fri, 11 Jun 2010 07:18:00 -0000	[thread overview]
Message-ID: <AANLkTikGG3zIXoCPFjRrr-sGMf41DXNNYewOWmRb-5Yk@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimMkPGlyPA6_DvEQxo4ZdAbzjlfp2Awl47t2A-W@mail.gmail.com>

Janus,


> b) it has been lying around for a while

Indeed, I have been trying to get back to completing the incorporation
of arrays....

> c) it fixes two bugs (both of which have been reported by real-world
> users. In fact they are duplicates.)
> d) Paul seems to have little time for gfortran lately :(

...but, as you say, I have little time for gfortran of late.

> e) I simply want to get this baby in finally :)
>
> [Btw, the original test case in PR 42051 still does not work, but this
> is apparently due to some other bug, possibly related or equal to PR
> 44064.]
>
> The patch has been regtested on x86_64-unknown-linux-gnu. Ok for trunk?
>
> Actually, since it's Paul's patch, I guess I could just approve it
> myself (I do indeed think it's fine). Therefore I'll just commit it
> tomorrow on behalf of Paul if no one objects by then.

I think that approach would be appropriate.

Thanks

Paul

  reply	other threads:[~2010-06-11  4:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-11  7:17 Janus Weil
2010-06-11  7:18 ` Paul Richard Thomas [this message]
2010-06-11  8:15   ` Paul Richard Thomas
2010-06-11 15:42     ` Paul Richard Thomas
2010-06-11 17:48       ` Janus Weil
2010-06-11 19:25 Dominique Dhumieres
2010-06-11 22:05 Dominique Dhumieres

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikGG3zIXoCPFjRrr-sGMf41DXNNYewOWmRb-5Yk@mail.gmail.com \
    --to=paul.richard.thomas@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=janus@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).