From: Xinliang David Li <davidxl@google.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: define MMX/SSE intrinsics without requiring cmdline isa flags
Date: Sun, 22 Aug 2010 09:55:00 -0000 [thread overview]
Message-ID: <AANLkTikNt+hHKkHzbHyM1uqk+CVTnAWXSjR4pBy9nzay@mail.gmail.com> (raw)
In-Reply-To: <AANLkTin7usSB2KH9Dm7VpQaabFfk8vzr2Up11U7_tD7X@mail.gmail.com>
On Thu, Aug 19, 2010 at 10:48 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Aug 19, 2010 at 10:36 AM, Xinliang David Li <davidxl@google.com> wrote:
>> On Thu, Aug 19, 2010 at 9:03 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Thu, Aug 19, 2010 at 8:42 AM, Xinliang David Li <davidxl@google.com> wrote:
>>>> Good to know that I am not alone.
>>>>
>>>> I need comments on the patch I proposed -- what are the potential
>>>> problems (other than slight increase in memory consumption which has
>>>> no impact on compile time)?
>>>>
>>>
>>> The whole target attribute is very fragile:
>>>
>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37565
>>>
>>> There is another issue with intrinsics:
>>>
>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39840
>>>
>>> I don't think we should add more kludges to the current
>>> scheme. I suggest you open a bug with your concern. We
>>> should take a look at all related issues to address them
>>> properly. I hope the driver changes Joseph is making can
>>> help this.
>>
>> You have not comment on why you think the patch is a kludge --- though
>> it does not solve the problem of mixing regions with different target
>> options in the same function, it is an independent patch on top of the
>> per function target attribute that will make people's life much easier
>> (all it does is predefine all isa builtins and 'unguard' the intrinsic
>> wrapper defs). It makes your second example in
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39840 work when merging
>> all sources into one file (after adding appropriate target attribute).
>>
>
> 1. Why not just simply not check __SSEXX__ in intrinsic header files
> and always define intrinsics?
Given the concern that existing macros are already exposed to users,
adding a new macro is a good idea.
David
next prev parent reply other threads:[~2010-08-22 6:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 0:22 Xinliang David Li
2010-08-19 14:04 ` Andi Kleen
2010-08-19 15:49 ` Xinliang David Li
2010-08-19 16:08 ` H.J. Lu
2010-08-19 16:33 ` Andi Kleen
2010-08-19 17:58 ` Xinliang David Li
2010-08-19 18:16 ` H.J. Lu
2010-08-19 18:52 ` Richard Henderson
2010-08-19 18:59 ` Xinliang David Li
2010-08-19 19:41 ` Richard Henderson
2010-08-22 9:46 ` Xinliang David Li
2010-08-22 9:55 ` Xinliang David Li [this message]
2010-08-19 18:21 ` Daniel Jacobowitz
2010-08-19 19:33 ` Xinliang David Li
2010-08-19 22:00 ` Michael Meissner
2010-08-19 22:02 ` Joseph S. Myers
2010-08-19 22:14 ` Michael Meissner
2010-08-22 9:50 ` Xinliang David Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikNt+hHKkHzbHyM1uqk+CVTnAWXSjR4pBy9nzay@mail.gmail.com \
--to=davidxl@google.com \
--cc=andi@firstfloor.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).