vect pat recog fails in sbitmap.c on ia64

vect pat recog fails in sbitmap.c on ia64

[Alexandre Oliva]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

A -O3 bootstrap on ia64-linux-gnu crashes building sbitmap.c in stage2.
The problem is that get_vectype_for_scalar_type (type_out = <unsigned
long int>) returns type_out = NULL, and then vect_pattern_recog_1
crashes when it attempts to take the mode of the returned type.

I'm not sure whether returning immediately (like we do for type_in) or
using the original scalar type_out is best.  The latter is what I
regstrapped on ia64-linux-gnu.  Ok to install?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: tree-vect-recog-no-out.patch --]
[-- Type: text/x-diff, Size: 775 bytes --]

for  gcc/ChangeLog
from  Alexandre Oliva  <aoliva@redhat.com>

	* tree-vect-patterns.c (vect_pattern_recog_1): Use scalar type
	if we don't get a vector type for output.

Index: gcc/tree-vect-patterns.c
===================================================================
--- gcc/tree-vect-patterns.c.orig	2010-06-10 14:28:05.000000000 -0300
+++ gcc/tree-vect-patterns.c	2010-06-10 14:29:26.000000000 -0300
@@ -696,7 +696,12 @@ vect_pattern_recog_1 (
       if (!type_in)
 	return;
       if (type_out)
-	type_out = get_vectype_for_scalar_type (type_out);
+	{
+	  tree saved_type_out = type_out;
+	  type_out = get_vectype_for_scalar_type (type_out);
+	  if (!type_out)
+	    type_out = saved_type_out;
+	}
       else
 	type_out = type_in;
       pattern_vectype = type_out;

[-- Attachment #3: Type: text/plain, Size: 257 bytes --]


-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist      Red Hat Brazil Compiler Engineer

Re: vect pat recog fails in sbitmap.c on ia64

[Richard Guenther]

On Fri, Jun 11, 2010 at 9:25 PM, Alexandre Oliva <aoliva@redhat.com> wrote:
> A -O3 bootstrap on ia64-linux-gnu crashes building sbitmap.c in stage2.
> The problem is that get_vectype_for_scalar_type (type_out = <unsigned
> long int>) returns type_out = NULL, and then vect_pattern_recog_1
> crashes when it attempts to take the mode of the returned type.
>
> I'm not sure whether returning immediately (like we do for type_in) or
> using the original scalar type_out is best.  The latter is what I
> regstrapped on ia64-linux-gnu.  Ok to install?

You should instead bail out immediately.

Ok with that change.

Thanks,
Richard.

>
>
> --
> Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
> You must be the change you wish to see in the world. -- Gandhi
> Be Free! -- http://FSFLA.org/   FSF Latin America board member
> Free Software Evangelist      Red Hat Brazil Compiler Engineer
>
>

Re: vect pat recog fails in sbitmap.c on ia64

[Alexandre Oliva]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

On Jun 11, 2010, Richard Guenther <richard.guenther@gmail.com> wrote:

> On Fri, Jun 11, 2010 at 9:25 PM, Alexandre Oliva <aoliva@redhat.com> wrote:
>> A -O3 bootstrap on ia64-linux-gnu crashes building sbitmap.c in stage2.
>> The problem is that get_vectype_for_scalar_type (type_out = <unsigned
>> long int>) returns type_out = NULL, and then vect_pattern_recog_1
>> crashes when it attempts to take the mode of the returned type.

> You should instead bail out immediately.

> Ok with that change.

Thanks, here's what I'm checking in.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: tree-vect-recog-no-out.patch --]
[-- Type: text/x-diff, Size: 642 bytes --]

for  gcc/ChangeLog
from  Alexandre Oliva  <aoliva@redhat.com>

	* tree-vect-patterns.c (vect_pattern_recog_1): Bail out if we
	don't get a vector type for output.

Index: gcc/tree-vect-patterns.c
===================================================================
--- gcc/tree-vect-patterns.c.orig	2010-06-14 16:08:23.000000000 -0300
+++ gcc/tree-vect-patterns.c	2010-06-14 16:25:04.000000000 -0300
@@ -699,6 +699,8 @@ vect_pattern_recog_1 (
 	type_out = get_vectype_for_scalar_type (type_out);
       else
 	type_out = type_in;
+      if (!type_out)
+	return;
       pattern_vectype = type_out;
 
       if (is_gimple_assign (pattern_stmt))

[-- Attachment #3: Type: text/plain, Size: 257 bytes --]


-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist      Red Hat Brazil Compiler Engineer