* Fix typo of the comment in resource.h
@ 2010-11-15 6:58 Mingjie Xing
2010-11-15 7:04 ` Dave Korn
0 siblings, 1 reply; 7+ messages in thread
From: Mingjie Xing @ 2010-11-15 6:58 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 210 bytes --]
Hi
This small patch fix the typo of the comment in resource.h. Is it OK?
Thanks,
Mingjie
2010-11-15 Mingjie Xing <mingjie.xing@gmail.com>
* resource.h (struct resources): Fix typo in the comment.
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 616 bytes --]
Index: resource.h
===================================================================
--- resource.h (revision 163986)
+++ resource.h (working copy)
@@ -33,7 +33,7 @@ along with GCC; see the file COPYING3.
struct resources
{
char memory; /* Insn sets or needs a memory location. */
- char unch_memory; /* Insn sets of needs a "unchanging" MEM. */
+ char unch_memory; /* Insn sets or needs a "unchanging" MEM. */
char volatil; /* Insn sets or needs a volatile memory loc. */
char cc; /* Insn sets or needs the condition codes. */
HARD_REG_SET regs; /* Which registers are set or needed. */
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Fix typo of the comment in resource.h
2010-11-15 6:58 Fix typo of the comment in resource.h Mingjie Xing
@ 2010-11-15 7:04 ` Dave Korn
2010-11-15 9:08 ` Mingjie Xing
0 siblings, 1 reply; 7+ messages in thread
From: Dave Korn @ 2010-11-15 7:04 UTC (permalink / raw)
To: Mingjie Xing; +Cc: gcc-patches
On 15/11/2010 05:11, Mingjie Xing wrote:
> Hi
>
> This small patch fix the typo of the comment in resource.h. Is it OK?
I cannot approve the patch, but spotted an additional grammar problem that
you could fix at the same time:
- char unch_memory; /* Insn sets of needs a "unchanging" MEM. */
+ char unch_memory; /* Insn sets or needs a "unchanging" MEM. */
It should be 'an "unchanging" ...', not 'a "unchanging" ...'.
cheers,
DaveK
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Fix typo of the comment in resource.h
2010-11-15 7:04 ` Dave Korn
@ 2010-11-15 9:08 ` Mingjie Xing
2010-11-18 2:42 ` [PING] " Mingjie Xing
0 siblings, 1 reply; 7+ messages in thread
From: Mingjie Xing @ 2010-11-15 9:08 UTC (permalink / raw)
To: Dave Korn; +Cc: gcc-patches
2010/11/15 Dave Korn <dave.korn.cygwin@gmail.com>:
> On 15/11/2010 05:11, Mingjie Xing wrote:
>> Hi
>>
>> This small patch fix the typo of the comment in resource.h. Is it OK?
>
> I cannot approve the patch, but spotted an additional grammar problem that
> you could fix at the same time:
>
> - char unch_memory; /* Insn sets of needs a "unchanging" MEM. */
> + char unch_memory; /* Insn sets or needs a "unchanging" MEM. */
>
> It should be 'an "unchanging" ...', not 'a "unchanging" ...'.
>
> cheers,
> DaveK
>
Indeed. Updated the patch. Thanks.
Mingjie,
Index: resource.h
===================================================================
--- resource.h (revision 163986)
+++ resource.h (working copy)
@@ -33,7 +33,7 @@ along with GCC; see the file COPYING3.
struct resources
{
char memory; /* Insn sets or needs a memory location. */
- char unch_memory; /* Insn sets of needs a "unchanging" MEM. */
+ char unch_memory; /* Insn sets or needs an "unchanging" MEM. */
char volatil; /* Insn sets or needs a volatile memory loc. */
char cc; /* Insn sets or needs the condition codes. */
HARD_REG_SET regs; /* Which registers are set or needed. */
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PING] Fix typo of the comment in resource.h
2010-11-15 9:08 ` Mingjie Xing
@ 2010-11-18 2:42 ` Mingjie Xing
2010-11-18 4:16 ` Dave Korn
0 siblings, 1 reply; 7+ messages in thread
From: Mingjie Xing @ 2010-11-18 2:42 UTC (permalink / raw)
To: gcc-patches
2010/11/15 Mingjie Xing <mingjie.xing@gmail.com>:
> 2010/11/15 Dave Korn <dave.korn.cygwin@gmail.com>:
>> On 15/11/2010 05:11, Mingjie Xing wrote:
>>> Hi
>>>
>>> This small patch fix the typo of the comment in resource.h. Is it OK?
>>
>> I cannot approve the patch, but spotted an additional grammar problem that
>> you could fix at the same time:
>>
>> - char unch_memory; /* Insn sets of needs a "unchanging" MEM. */
>> + char unch_memory; /* Insn sets or needs a "unchanging" MEM. */
>>
>> It should be 'an "unchanging" ...', not 'a "unchanging" ...'.
>>
>> cheers,
>> DaveK
>>
>
> Indeed. Updated the patch. Thanks.
>
> Mingjie,
>
> Index: resource.h
> ===================================================================
> --- resource.h (revision 163986)
> +++ resource.h (working copy)
> @@ -33,7 +33,7 @@ along with GCC; see the file COPYING3.
> struct resources
> {
> char memory; /* Insn sets or needs a memory location. */
> - char unch_memory; /* Insn sets of needs a "unchanging" MEM. */
> + char unch_memory; /* Insn sets or needs an "unchanging" MEM. */
> char volatil; /* Insn sets or needs a volatile memory loc. */
> char cc; /* Insn sets or needs the condition codes. */
> HARD_REG_SET regs; /* Which registers are set or needed. */
>
Is it OK? Really simple changes. :-)
Thanks
Mingjie
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PING] Fix typo of the comment in resource.h
2010-11-18 2:42 ` [PING] " Mingjie Xing
@ 2010-11-18 4:16 ` Dave Korn
2010-11-18 22:24 ` Paolo Bonzini
0 siblings, 1 reply; 7+ messages in thread
From: Dave Korn @ 2010-11-18 4:16 UTC (permalink / raw)
To: Mingjie Xing; +Cc: gcc-patches
On 18/11/2010 01:21, Mingjie Xing wrote:
> Is it OK? Really simple changes. :-)
I'm sure it will be, but please be patient; we have very serious shortage of
manpower. The tradition is that we usually wait 10-14 days before sending a
ping, and even then sometimes it takes several pings.
cheers,
DaveK
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PING] Fix typo of the comment in resource.h
2010-11-18 4:16 ` Dave Korn
@ 2010-11-18 22:24 ` Paolo Bonzini
2010-11-19 3:06 ` Mingjie Xing
0 siblings, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2010-11-18 22:24 UTC (permalink / raw)
To: Dave Korn; +Cc: Mingjie Xing, gcc-patches
On 11/18/2010 03:15 AM, Dave Korn wrote:
> On 18/11/2010 01:21, Mingjie Xing wrote:
>
>> Is it OK? Really simple changes. :-)
>
> I'm sure it will be, but please be patient; we have very serious shortage of
> manpower. The tradition is that we usually wait 10-14 days before sending a
> ping, and even then sometimes it takes several pings.
Go ahead, do you have commit access?
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PING] Fix typo of the comment in resource.h
2010-11-18 22:24 ` Paolo Bonzini
@ 2010-11-19 3:06 ` Mingjie Xing
0 siblings, 0 replies; 7+ messages in thread
From: Mingjie Xing @ 2010-11-19 3:06 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Dave Korn, gcc-patches
2010/11/19 Paolo Bonzini <bonzini@gnu.org>:
> On 11/18/2010 03:15 AM, Dave Korn wrote:
>>
>> On 18/11/2010 01:21, Mingjie Xing wrote:
>>
>>> Is it OK? Really simple changes. :-)
>>
>> I'm sure it will be, but please be patient; we have very serious
>> shortage of
>> manpower. The tradition is that we usually wait 10-14 days before sending
>> a
>> ping, and even then sometimes it takes several pings.
>
> Go ahead, do you have commit access?
>
> Paolo
>
Committed revision 166927.
Thanks,
Mingjie
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-11-19 1:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-15 6:58 Fix typo of the comment in resource.h Mingjie Xing
2010-11-15 7:04 ` Dave Korn
2010-11-15 9:08 ` Mingjie Xing
2010-11-18 2:42 ` [PING] " Mingjie Xing
2010-11-18 4:16 ` Dave Korn
2010-11-18 22:24 ` Paolo Bonzini
2010-11-19 3:06 ` Mingjie Xing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).