From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: fortran@gcc.gnu.org, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: [Patch, fortran] PR4773 - [4.6 Regression] Unnecessary temporaries increase the runtime for channel.f90 by ~70%
Date: Fri, 09 Jul 2010 15:04:00 -0000 [thread overview]
Message-ID: <AANLkTikanMhKUaI75kr6-BjdMSaFwLXNVQK1-2dRIzbK@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]
Revision 161670 affected an optimization used for
array_lhs = array_valued_function (args...).
In order to prevent aliasing with the result, which is passed by
reference, a fairly conservative test was applied to generate a
temporary, if needed. Unfortunately, this reduced the performance of
gfortran with some code; most notably with channel.f90.
This patch tests if the 'array_lhs' has ever been host associated, on
condition that 'array_valued_function' is contained, in addition to
checking that the result is not use-associated, a pointer or a target.
If this is not the case, no temporary is generated.
Clearly some further optimization would be possible, if the
'array_lhs' were specifically not host associated to
'array_valued_function' OR ANY OF IT'S CALLEEs. This latter
condition is rather difficult to implement, which is why I have not
even tried it.
Bootstrapped and regtested on RHEL5.3/i686 - OK for trunk and.....?
Cheers
Paul
2010-07-09 Paul Thomas <pault@gcc.gnu.org>
PR fortran/44773
* trans-expr.c (arrayfunc_assign_needs_temporary): No temporary
if the lhs has never been host associated, as well as not being
use associated, a pointer or a target.
* resolve.c (resolve_variable): Mark variables that are host
associated.
* gfortran.h: Add the host_assoc bit to the symbol_attribute
structure.
[-- Attachment #2: submit.diff --]
[-- Type: text/x-patch, Size: 2041 bytes --]
Index: gcc/fortran/trans-expr.c
===================================================================
--- gcc/fortran/trans-expr.c (revision 161983)
+++ gcc/fortran/trans-expr.c (working copy)
@@ -4978,6 +4978,11 @@
if (!expr2->value.function.esym->attr.contained)
return false;
+ /* A temporary is not needed if the lhs has never been host
+ associated and the procedure is contained. */
+ else if (!sym->attr.host_assoc)
+ return false;
+
/* A temporary is not needed if the variable is local and not
a pointer, a target or a result. */
if (sym->ns->parent
Index: gcc/fortran/gfortran.h
===================================================================
--- gcc/fortran/gfortran.h (revision 161983)
+++ gcc/fortran/gfortran.h (working copy)
@@ -682,7 +682,8 @@
use_assoc:1, /* Symbol has been use-associated. */
use_only:1, /* Symbol has been use-associated, with ONLY. */
use_rename:1, /* Symbol has been use-associated and renamed. */
- imported:1; /* Symbol has been associated by IMPORT. */
+ imported:1, /* Symbol has been associated by IMPORT. */
+ host_assoc:1; /* Symbol has been host associated. */
unsigned in_namelist:1, in_common:1, in_equivalence:1;
unsigned function:1, subroutine:1, procedure:1;
Index: gcc/fortran/resolve.c
===================================================================
--- gcc/fortran/resolve.c (revision 161983)
+++ gcc/fortran/resolve.c (working copy)
@@ -4772,6 +4772,15 @@
sym->entry_id = current_entry_id + 1;
}
+ /* If a symbol has been host_associated mark it. This is used latter,
+ to identify if aliasing is possible via host association. */
+ if (sym->attr.flavor == FL_VARIABLE
+ && gfc_current_ns->parent
+ && (gfc_current_ns->parent == sym->ns
+ || (gfc_current_ns->parent->parent
+ && gfc_current_ns->parent->parent == sym->ns)))
+ sym->attr.host_assoc = 1;
+
resolve_procedure:
if (t == SUCCESS && resolve_procedure_expression (e) == FAILURE)
t = FAILURE;
next reply other threads:[~2010-07-09 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 15:04 Paul Richard Thomas [this message]
2010-07-12 7:49 ` Tobias Burnus
2010-07-12 12:23 ` Paul Richard Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikanMhKUaI75kr6-BjdMSaFwLXNVQK1-2dRIzbK@mail.gmail.com \
--to=paul.richard.thomas@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).