From: "H.J. Lu" <hjl.tools@gmail.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: Bernd Schmidt <bernds@codesourcery.com>,
gcc-patches@gcc.gnu.org, Jeff Law <law@redhat.com>
Subject: Re: [x32] PATCH: PR middle-end/47725: [x32] error: unable to find a register to spill in class DIREG
Date: Tue, 15 Feb 2011 18:14:00 -0000 [thread overview]
Message-ID: <AANLkTikjug45BUcpHVj0ycd=h=cijdeNnMgQLrXEiZUY@mail.gmail.com> (raw)
In-Reply-To: <201102151833.00647.ebotcazou@adacore.com>
On Tue, Feb 15, 2011 at 9:33 AM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> Yes. That's how I'd fix it. Concerns about optimization seem to be
>> misplaced as well; I've run this through my collection of input files
>> and did not find a case where code generation changed. So, OK to install.
>
> I disagree, this isn't a regression so this isn't suitable for stage 4 as per
> http://gcc.gnu.org/ml/gcc/2011-02/msg00250.html
I can revert the change and recheck it in in stage 1.
> Did you look at the code generated on the x32 branch?
>
I didn't check the detail. But I think combine.c change is better.
--
H.J.
next prev parent reply other threads:[~2011-02-15 18:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 19:04 H.J. Lu
2011-02-14 19:07 ` Jeff Law
2011-02-14 19:11 ` H.J. Lu
2011-02-14 19:17 ` Jeff Law
2011-02-14 19:39 ` Eric Botcazou
2011-02-14 19:49 ` Bernd Schmidt
2011-02-14 19:51 ` Eric Botcazou
2011-02-15 23:09 ` Bernd Schmidt
2011-03-18 0:30 ` H.J. Lu
2011-03-18 4:01 ` H.J. Lu
2011-03-21 4:15 ` H.J. Lu
2011-03-22 20:10 ` Eric Botcazou
2011-03-23 3:29 ` H.J. Lu
2011-03-23 8:27 ` Eric Botcazou
2011-03-23 10:57 ` H.J. Lu
2011-03-24 15:56 ` Eric Botcazou
2011-03-29 17:50 ` H.J. Lu
2011-02-14 19:54 ` H.J. Lu
2011-02-15 15:53 ` Bernd Schmidt
2011-02-15 17:02 ` H.J. Lu
2011-02-15 17:49 ` Eric Botcazou
2011-02-15 18:14 ` H.J. Lu [this message]
2011-02-15 19:03 ` Eric Botcazou
2011-02-15 21:16 ` Jeff Law
2011-02-15 21:39 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikjug45BUcpHVj0ycd=h=cijdeNnMgQLrXEiZUY@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=bernds@codesourcery.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).