From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20602 invoked by alias); 30 Jun 2010 20:09:29 -0000 Received: (qmail 20590 invoked by uid 22791); 30 Jun 2010 20:09:28 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-qy0-f175.google.com (HELO mail-qy0-f175.google.com) (209.85.216.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Jun 2010 20:09:23 +0000 Received: by qyk7 with SMTP id 7so320298qyk.20 for ; Wed, 30 Jun 2010 13:09:21 -0700 (PDT) Received: by 10.224.87.214 with SMTP id x22mr6531329qal.72.1277928561205; Wed, 30 Jun 2010 13:09:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.74.18 with HTTP; Wed, 30 Jun 2010 13:08:51 -0700 (PDT) In-Reply-To: References: <4C2B8D56.3010007@google.com> From: Sebastian Pop Date: Wed, 30 Jun 2010 21:32:00 -0000 Message-ID: Subject: Re: Script to check formatting for GNU style patches To: =?ISO-8859-1?Q?Manuel_L=F3pez=2DIb=E1=F1ez?= , Gerald Pfeifer Cc: Diego Novillo , GCC Patches , Andreas.Krebbel@de.ibm.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-06/txt/msg03200.txt.bz2 On Wed, Jun 30, 2010 at 14:02, Manuel L=F3pez-Ib=E1=F1ez wrote: > On 30 June 2010 20:30, Diego Novillo wrote: >> On 10-06-30 12:05 , Sebastian Pop wrote: >>> >>> Hi, >>> >>> Some folks complained of not having a script that checks for >>> formatting issues in the patches to GCC. =A0The attached script checks >>> for some common formatting problems that occur in the code of new >>> contributors to GCC. =A0With time this script could be improved, but >>> this is already useful to avoid common mistakes. >>> >>> I would like to commit this script to the contrib directory. =A0Ok for >>> trunk? >> >> OK with a ChangeLog entry. =A0Thanks for doing this. =A0I agree that we = can keep >> adding to this as we go along. =A0It does not need to be pretty nor perf= ect to >> be useful. >> > > I would humbly suggest to mention this new script in > http://gcc.gnu.org/contribute.html#standards > > I would go as far as to add a direct link to the file in trunk. > Gerald, does this patch look good? Ok to apply after the script is committed to trunk? Thanks, Sebastian *** contribute.html.~1.73.~ 2010-03-31 15:08:49.000000000 -0500 --- contribute.html 2010-06-30 15:05:24.000000000 -0500 *************** *** 67,73 **** well as requirements on code formatting.

Submissions which do not conform to the standards will be returned ! with a request to address any such problems.

Testing Patches

--- 67,77 ---- well as requirements on code formatting.

Submissions which do not conform to the standards will be returned ! with a request to address any such problems. To help with the ! preparation of patches respecting these rules, one can use the script ! ! contrib/check_GNU_style.sh to detect some of the common ! mistakes.

Testing Patches