From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10284 invoked by alias); 22 Jul 2010 11:56:15 -0000 Received: (qmail 10267 invoked by uid 22791); 22 Jul 2010 11:56:14 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-bw0-f47.google.com (HELO mail-bw0-f47.google.com) (209.85.214.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Jul 2010 11:56:09 +0000 Received: by bwz10 with SMTP id 10so1040011bwz.20 for ; Thu, 22 Jul 2010 04:56:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.33.86 with SMTP id g22mr1394489bkd.26.1279799766824; Thu, 22 Jul 2010 04:56:06 -0700 (PDT) Received: by 10.204.57.197 with HTTP; Thu, 22 Jul 2010 04:56:06 -0700 (PDT) In-Reply-To: References: <4C475B71.4060202@redhat.com> Date: Thu, 22 Jul 2010 11:56:00 -0000 Message-ID: Subject: Re: [patch win32]: fix for PR target/41943 From: Kai Tietz To: Richard Guenther Cc: Danny Smith , Richard Henderson , Danny Smith , Dave Korn , GCC Patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-07/txt/msg01730.txt.bz2 2010/7/22 Richard Guenther : > On Thu, Jul 22, 2010 at 1:42 PM, Kai Tietz wrot= e: >> 2010/7/22 Danny Smith : >>>>> c:\mingw\bin\../lib/gcc/mingw32/4.6.0/include/float.h:278:24: fatal e= rror: float >>>>> .h: No such file or directory >>>>> compilation terminated. >>>>> >>>>> Danny >>>>> >>>> >>>> I know. But as the float.h from gcc's internal header always comes >>>> first in include order, this next_include in system-headers is wrong. >>> >>> >>> mingw CRT and winapi headers have long been placed in the >>> LOCAL_INCLUDE_DIR on window's hosts, since Windows doesn't really have >>> a system include directory. =A0This local include dir is defined as >>> being relative to exec_prefix in x-mingw32. >>> >>> The local include dir is included before gcc's internal headers. >>> >>> Danny >>> >> >> That's right and therefore I dislike this patch and would prefer to >> have that one Ozkan mentioned already. The issue is that sysroot & >> cross- includes come after gcc's internal header, which is causing the >> pain that it isn't absolutely predicatable, if system-headers are >> reached or not. >> By changing the order of gcc's internal to the end of the include >> chain, it would be solved for all cases. > > Well, I think moving gcc headers to the end of the include chain is > just wrong. =A0They are supposed to override host ones (which is > why they are called "fixincludes"). =A0Why not fixinclude mingw? > > Richard. > Because gcc's internal headers aren't the fixed-include ones. Secondly the fixed-include headers coming after gcc's internal headers, so using fixinclude leads nowhere and doesn't solve anything here. Kai --=20 |=A0 (\_/) This is Bunny. Copy and paste | (=3D'.'=3D) Bunny into your signature to help | (")_(") him gain world domination