Re: [patch c,c++,i386]:PR/15774 - Conflicting function decls not diagnosed

[Gabriel Dos Reis <gdr@integrable-solutions.net>]

On Wed, Dec 22, 2010 at 10:31 AM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> On Wed, 22 Dec 2010, Kai Tietz wrote:
>
>> Hi,  this patch fixes the bug described at
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15774 in bugzilla.
>
> Could you please explain more about how and why it fixes the bug?  The bug
> described there is:
>
>    The C++ frontend doesn't always call targetm.compare_type_attributes
>    when comparing function decls in decl.c: decls_match.  As a result
>    conflicting decls are not diagnosed.
>
> But your patch doesn't change the compatibility testing at all; it just
> changes how things are printed.  Is there code somewhere that generates
> strings for type names and compares those strings to determine
> compatibility?

I don't think the patch actually implement compatibility checking.
What it does is to print the conflicting attributes during
diagnostic report.  And that is something that needed to be fixed.
Also, I am skeptical that we should print all attributes.

I think the actual code generation stuff is orthogonal.

-- Gaby