* [vect, mips] run the vect testsuite even no paired single support
@ 2010-07-05 9:29 Eric Fisher
2010-07-05 13:31 ` Diego Novillo
0 siblings, 1 reply; 3+ messages in thread
From: Eric Fisher @ 2010-07-05 9:29 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
Hi,
This patch change the vect.exp to run the vect testsuite even the
target has no paired single support.
Tested on ia64 machine:
Running /tools/trunk/gcc/testsuite/gcc.dg/vect/vect.exp ...
FAIL: gcc.dg/vect/pr40254.c execution test
=== gcc Summary ===
# of expected passes 53
# of unexpected failures 1
# of expected failures 6
# of unsupported tests 487
tools/build-trunk/gcc/xgcc version 4.6.0 20100630 (experimental) (GCC)
Thanks,
Eric
[-- Attachment #2: vect.patch --]
[-- Type: text/x-diff, Size: 829 bytes --]
Index: gcc/testsuite/gcc.dg/vect/vect.exp
===================================================================
--- gcc/testsuite/gcc.dg/vect/vect.exp (revision 161820)
+++ gcc/testsuite/gcc.dg/vect/vect.exp (working copy)
@@ -76,10 +76,10 @@ if [istarget "powerpc-*paired*"] {
} else {
set dg-do-what-default compile
}
-} elseif { [istarget "mips*-*-*"]
- && [check_effective_target_mpaired_single]
- && [check_effective_target_nomips16] } {
- lappend DEFAULT_VECTCFLAGS "-mpaired-single"
+} elseif { [istarget "mips*-*-*"] && [check_effective_target_nomips16] } {
+ if { [check_effective_target_mpaired_single] } {
+ lappend DEFAULT_VECTCFLAGS "-mpaired-single"
+ }
set dg-do-what-default run
} elseif [istarget "sparc*-*-*"] {
lappend DEFAULT_VECTCFLAGS "-mcpu=ultrasparc" "-mvis"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [vect, mips] run the vect testsuite even no paired single support
2010-07-05 9:29 [vect, mips] run the vect testsuite even no paired single support Eric Fisher
@ 2010-07-05 13:31 ` Diego Novillo
2010-07-06 0:47 ` Eric Fisher
0 siblings, 1 reply; 3+ messages in thread
From: Diego Novillo @ 2010-07-05 13:31 UTC (permalink / raw)
To: Eric Fisher; +Cc: gcc-patches
On Mon, Jul 5, 2010 at 05:29, Eric Fisher <joefoxreal@gmail.com> wrote:
> Hi,
>
> This patch change the vect.exp to run the vect testsuite even the
> target has no paired single support.
>
> Tested on ia64 machine:
The code you changed affect mips targets. How will testing on ia64
help? Is this a cross compiler? Additionally, I don't see why the
change is necessary. You seem to be changing the logic that appends
mpaired-single, not the logic that decides whether to run vect.exp at
all.
Diego.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [vect, mips] run the vect testsuite even no paired single support
2010-07-05 13:31 ` Diego Novillo
@ 2010-07-06 0:47 ` Eric Fisher
0 siblings, 0 replies; 3+ messages in thread
From: Eric Fisher @ 2010-07-06 0:47 UTC (permalink / raw)
To: Diego Novillo; +Cc: gcc-patches
2010/7/5 Diego Novillo <dnovillo@google.com>:
> The code you changed affect mips targets. How will testing on ia64
> help? Is this a cross compiler? Additionally, I don't see why the
> change is necessary. You seem to be changing the logic that appends
> mpaired-single, not the logic that decides whether to run vect.exp at
> all.
Yes. It's a cross compiler for loongson2f. The original logic will
fall into the 'else' fragment when the target doesn't support
paired-single, hence 'return'. The change will make the test go ahead
even the target doesn't support paired-single such as loongson2f which
has SIMD instructions.
Here is the result for the original testsuite.
Running /tools/trunk/gcc/testsuite/gcc.dg/vect/vect.exp ...
=== gcc Summary ===
/tools/build-trunk/gcc/xgcc version 4.6.0 20100630 (experimental) (GCC)
Thanks.
Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-06 0:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-05 9:29 [vect, mips] run the vect testsuite even no paired single support Eric Fisher
2010-07-05 13:31 ` Diego Novillo
2010-07-06 0:47 ` Eric Fisher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).