From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28897 invoked by alias); 3 Sep 2010 17:45:53 -0000 Received: (qmail 28888 invoked by uid 22791); 3 Sep 2010 17:45:52 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-bw0-f47.google.com (HELO mail-bw0-f47.google.com) (209.85.214.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Sep 2010 17:45:47 +0000 Received: by bwz12 with SMTP id 12so1997063bwz.20 for ; Fri, 03 Sep 2010 10:45:45 -0700 (PDT) Received: by 10.204.121.77 with SMTP id g13mr624586bkr.206.1283535945257; Fri, 03 Sep 2010 10:45:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.118.194 with HTTP; Fri, 3 Sep 2010 10:45:13 -0700 (PDT) In-Reply-To: References: <20100903155938.AFAD85664F5@henry1.codesourcery.com> <4C812DE8.1010602@codesourcery.com> From: =?ISO-8859-1?Q?Manuel_L=F3pez=2DIb=E1=F1ez?= Date: Fri, 03 Sep 2010 17:51:00 -0000 Message-ID: Subject: Re: RFA: PATCH: -Wimplicit-double To: Mark Mitchell Cc: gcc-patches@gcc.gnu.org, "Joseph S. Myers" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-09/txt/msg00283.txt.bz2 On 3 September 2010 19:43, Manuel L=F3pez-Ib=E1=F1ez wrote: > On 3 September 2010 19:18, Mark Mitchell wrote: >> On 9/3/2010 8:59 AM, Mark Mitchell wrote: >> >>> This patch implements -Wimplicit-double, a new warning. =A0The goal of >>> the warning is to warn users when a "float" is implicitly converted to >>> a "double". >> >> Joseph asked me off-list to make a couple of low-level corrections: >> >> (a) Use warning_at where possible >> (b) Name the parameter to do_warn_implicit_double "gmsgid" for i18n >> >> Thanks, > > This is warned already by Wconversion for both C and C++ and Fortran! > If it doesn't catch all cases, then that should be fixed appropriately > to use existing code as much as possible. And there are testcases > already for this in the testsuite. In fact, the case without prototype is different and is warned by Wtraditional-conversion. There are also testcases in the testsuite. So that part seems to be also duplicated. Cheers, Manuel.