From: Kai Tietz <ktietz70@googlemail.com>
To: Dave Korn <dave.korn.cygwin@gmail.com>
Cc: Richard Henderson <rth@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch i386]: Add for win32 targets pre-prologue profiling feature
Date: Wed, 14 Jul 2010 12:11:00 -0000 [thread overview]
Message-ID: <AANLkTimA1yF5_qFfy4uz_-BbKNufJngnED7rKDzkRlKc@mail.gmail.com> (raw)
In-Reply-To: <4C3DA923.8030509@gmail.com>
2010/7/14 Dave Korn <dave.korn.cygwin@gmail.com>:
> On 14/07/2010 11:20, Kai Tietz wrote:
>
>> * config/i386/cygming.h (PROFILE_SUPPORT_BEFORE_PROLOGUE): New.
>> (MCOUNT_NAME): Win32 specific version.
>
>> +
>> +/* Choose the correct profiler mcount name. For checking we are using the
>> + ix86_profile_before_prologue function as flag_profile_top is tri-state. */
>> +#undef MCOUNT_NAME
>> +#define MCOUNT_NAME (ix86_profile_before_prologue () ? "_mcount_top" : "_mcount")
>> +
>> #if ! defined (USE_MINGW64_LEADING_UNDERSCORES)
>> #undef USER_LABEL_PREFIX
>> #define USER_LABEL_PREFIX (TARGET_64BIT ? "" : "_")
>
>
> Shouldn't MCOUNT_NAME take USER_LABEL_PREFIX into account?
>
> cheers,
> DaveK
>
>
Well, as this MCOUNT_NAME ("_mcount") is already used widely for
64-bit, I don't want to change here something. But in general you are
right.
Cheers,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination
next prev parent reply other threads:[~2010-07-14 12:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 12:47 Kai Tietz
2010-07-13 16:28 ` Richard Henderson
2010-07-14 10:20 ` Kai Tietz
2010-07-14 11:49 ` Dave Korn
2010-07-14 12:11 ` Kai Tietz [this message]
2010-07-14 12:16 ` Andi Kleen
2010-07-14 12:38 ` Kai Tietz
2010-07-15 18:08 ` Kai Tietz
2010-07-16 17:06 ` Richard Henderson
2010-07-17 6:52 ` Kai Tietz
2010-07-20 2:27 ` Richard Henderson
2010-07-28 8:36 ` Kai Tietz
2010-07-28 16:00 ` Richard Henderson
2010-07-28 16:01 ` Andi Kleen
2010-07-28 17:28 ` Kai Tietz
2010-07-28 17:40 ` Richard Henderson
2010-07-28 18:14 ` Kai Tietz
2010-07-16 20:53 ` Gerald Pfeifer
2010-07-18 12:20 ` Kai Tietz
2010-07-18 20:52 ` Gerald Pfeifer
2010-07-18 20:54 ` Kai Tietz
2010-07-28 18:06 ` Kai Tietz
2010-07-16 23:57 ` Andi Kleen
2010-07-17 5:34 ` Kai Tietz
2010-07-17 9:45 ` Andi Kleen
2010-07-18 11:37 ` Kai Tietz
2010-07-18 11:46 ` Kai Tietz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimA1yF5_qFfy4uz_-BbKNufJngnED7rKDzkRlKc@mail.gmail.com \
--to=ktietz70@googlemail.com \
--cc=dave.korn.cygwin@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).