From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-268152-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 27783 invoked by alias); 14 Jul 2010 12:11:34 -0000
Received: (qmail 27752 invoked by uid 22791); 14 Jul 2010 12:11:25 -0000
X-SWARE-Spam-Status: No, hits=-0.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE
X-Spam-Check-By: sourceware.org
Received: from mail-bw0-f47.google.com (HELO mail-bw0-f47.google.com) (209.85.214.47)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Jul 2010 12:11:21 +0000
Received: by bwz10 with SMTP id 10so4903328bwz.20        for <gcc-patches@gcc.gnu.org>; Wed, 14 Jul 2010 05:11:19 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.204.100.193 with SMTP id z1mr5421494bkn.176.1279109478269; 	Wed, 14 Jul 2010 05:11:18 -0700 (PDT)
Received: by 10.204.57.197 with HTTP; Wed, 14 Jul 2010 05:11:18 -0700 (PDT)
In-Reply-To: <4C3DA923.8030509@gmail.com>
References: <AANLkTimkEGrAkpdvwlTFV-Ad1wBUIQ02PV_8VG5BBRM9@mail.gmail.com>	<4C3C942D.3010101@redhat.com>	<AANLkTincDxzbxpCAMMiBbv52X2G3tE5lgortV820BqVq@mail.gmail.com>	<4C3DA923.8030509@gmail.com>
Date: Wed, 14 Jul 2010 12:11:00 -0000
Message-ID: <AANLkTimA1yF5_qFfy4uz_-BbKNufJngnED7rKDzkRlKc@mail.gmail.com>
Subject: Re: [patch i386]: Add for win32 targets pre-prologue profiling 	feature
From: Kai Tietz <ktietz70@googlemail.com>
To: Dave Korn <dave.korn.cygwin@gmail.com>
Cc: Richard Henderson <rth@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2010-07/txt/msg01148.txt.bz2

2010/7/14 Dave Korn <dave.korn.cygwin@gmail.com>:
> On 14/07/2010 11:20, Kai Tietz wrote:
>
>> =A0 =A0 =A0 * config/i386/cygming.h (PROFILE_SUPPORT_BEFORE_PROLOGUE): N=
ew.
>> =A0 =A0 =A0 (MCOUNT_NAME): Win32 specific version.
>
>> +
>> +/* Choose the correct profiler mcount name. For checking we are using t=
he
>> + =A0 ix86_profile_before_prologue function as flag_profile_top is tri-s=
tate. =A0*/
>> +#undef MCOUNT_NAME
>> +#define MCOUNT_NAME (ix86_profile_before_prologue () ? "_mcount_top" : =
"_mcount")
>> +
>> =A0#if ! defined (USE_MINGW64_LEADING_UNDERSCORES)
>> =A0#undef USER_LABEL_PREFIX
>> =A0#define USER_LABEL_PREFIX (TARGET_64BIT ? "" : "_")
>
>
> =A0Shouldn't MCOUNT_NAME take USER_LABEL_PREFIX into account?
>
> =A0 =A0cheers,
> =A0 =A0 =A0DaveK
>
>

Well, as this MCOUNT_NAME ("_mcount") is already used widely for
64-bit, I don't want to change here something. But in general you are
right.

Cheers,
Kai

--=20
|=A0 (\_/) This is Bunny. Copy and paste
| (=3D'.'=3D) Bunny into your signature to help
| (")_(") him gain world domination