From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15938 invoked by alias); 22 Sep 2010 02:33:39 -0000 Received: (qmail 15926 invoked by uid 22791); 22 Sep 2010 02:33:38 -0000 X-SWARE-Spam-Status: No, hits=-0.4 required=5.0 tests=AWL,BAYES_50,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,TW_GT X-Spam-Check-By: sourceware.org Received: from mail-qw0-f47.google.com (HELO mail-qw0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Sep 2010 02:33:33 +0000 Received: by qwb8 with SMTP id 8so4370qwb.20 for ; Tue, 21 Sep 2010 19:33:31 -0700 (PDT) Received: by 10.229.185.137 with SMTP id co9mr7917569qcb.189.1285122792148; Tue, 21 Sep 2010 19:33:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.1.81 with HTTP; Tue, 21 Sep 2010 19:32:52 -0700 (PDT) In-Reply-To: <20100921211628.969ed469.basile@starynkevitch.net> References: <20100921210301.d92889be.basile@starynkevitch.net> <20100921210829.5f2ea8b0.basile@starynkevitch.net> <20100921211217.df1ef337.basile@starynkevitch.net> <20100921211628.969ed469.basile@starynkevitch.net> From: Laurynas Biveinis Date: Wed, 22 Sep 2010 12:06:00 -0000 Message-ID: Subject: Re: gengtype improvements for plugins, thirdround! patch 4/7 [filerules] To: Basile Starynkevitch Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-09/txt/msg01772.txt.bz2 +/* Special file rules action for handling *.c source files using + * get_file_gtfilename to compute their output_name and + * get_file_basename to compute their for_name. The output_name is + * gt--.h for language specific source files, and + * gt-.h for common source files. */ Here and everywhere else, please drop the leading columns of '*'. Otherwise, the patch looks OK to me. (I was hoping for net code size savings here, but it looks like regexps only balloon it. Anyway, I still like the patch for its data-driveness). 2010/9/21 Basile Starynkevitch : > 2010-09-21 =C2=A0Jeremie Salvucci =C2=A0 > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Basile Starynkevitch =C2=A0 > > =C2=A0 =C2=A0 =C2=A0 =C2=A0* gengtype.c: Include xregex.h and obstack.h > =C2=A0 =C2=A0 =C2=A0 =C2=A0Added comments about role of get_output_file_w= ith_visibility and > =C2=A0 =C2=A0 =C2=A0 =C2=A0our regexpr machinery. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(frul_actionrout_t, struct file_rule_st): New. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(hader_dot_h_frul, source_dot_c_frul): New fun= ctions. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(NULL_REGEX, =C2=A0NULL_FRULACT): New. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(files_rules): New. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(matching_file_name_substitute): New function. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(get_output_file_with_visibility): Updated com= ments and rewritten > =C2=A0 =C2=A0 =C2=A0 =C2=A0to use the new files_rules machinery. --=20 Laurynas