public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [trunk] Comment of the gimple_body function
@ 2010-07-02 13:33 jeremie.salvucci
  2010-07-02 13:39 ` Paolo Carlini
  0 siblings, 1 reply; 4+ messages in thread
From: jeremie.salvucci @ 2010-07-02 13:33 UTC (permalink / raw)
  To: gcc-patches

hello all,

This is a comment for the gimple_body function of gimple.c (in reference to http://gcc.gnu.org/ml/gcc/2010-06/msg00775.html)

Cheers.

--
Jeremie Salvucci

Index: gcc/gimple.c
===================================================================
--- gcc/gimple.c	(revision 161714)
+++ gcc/gimple.c	(working copy)
@@ -1731,7 +1731,9 @@
 }
 
 
-/* Return the body of GIMPLE statements for function FN.  */
+/* Return the body of GIMPLE statements for function FN. After the CFG pass, the 
+   function body doesn't exist anymore because it has been splitted up into
+   basic blocks. In this case, it returns NULL.  */

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [trunk] Comment of the gimple_body function
  2010-07-02 13:33 [trunk] Comment of the gimple_body function jeremie.salvucci
@ 2010-07-02 13:39 ` Paolo Carlini
  2010-07-02 14:00   ` jeremie.salvucci
  0 siblings, 1 reply; 4+ messages in thread
From: Paolo Carlini @ 2010-07-02 13:39 UTC (permalink / raw)
  To: jeremie.salvucci; +Cc: gcc-patches

... always two spaces after the full stop.

Paolo.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [trunk] Comment of the gimple_body function
  2010-07-02 13:39 ` Paolo Carlini
@ 2010-07-02 14:00   ` jeremie.salvucci
  2010-07-02 14:57     ` Diego Novillo
  0 siblings, 1 reply; 4+ messages in thread
From: jeremie.salvucci @ 2010-07-02 14:00 UTC (permalink / raw)
  To: Paolo Carlini; +Cc: gcc-patches

Same patch, with two spaces after full stops. Ok for trunk ?

Index: gcc/gimple.c
===================================================================
--- gcc/gimple.c	(revision 161714)
+++ gcc/gimple.c	(working copy)
@@ -1731,7 +1731,10 @@
 }
 
 
-/* Return the body of GIMPLE statements for function FN.  */
+/* Return the body of GIMPLE statements for function FN.  After the
+   CFG pass, the function body doesn't exist anymore because it has
+   been splitted up into basic blocks.  In this case, it returns
+   NULL.  */

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [trunk] Comment of the gimple_body function
  2010-07-02 14:00   ` jeremie.salvucci
@ 2010-07-02 14:57     ` Diego Novillo
  0 siblings, 0 replies; 4+ messages in thread
From: Diego Novillo @ 2010-07-02 14:57 UTC (permalink / raw)
  To: jeremie.salvucci; +Cc: Paolo Carlini, gcc-patches

On Friday, July 2, 2010,  <jeremie.salvucci@free.fr> wrote:
> Same patch, with two spaces after full stops. Ok for trunk ?
>
> Index: gcc/gimple.c
> ===================================================================
> --- gcc/gimple.c        (revision 161714)
> +++ gcc/gimple.c        (working copy)
> @@ -1731,7 +1731,10 @@
>  }
>
>
> -/* Return the body of GIMPLE statements for function FN.  */
> +/* Return the body of GIMPLE statements for function FN.  After the
> +   CFG pass, the function body doesn't exist anymore because it has
> +   been splitted up into basic blocks.  In this case, it returns
> +   NULL.  */

,s/splitted/split/

Ok wirh that change and a ChangLog entry.

Diego.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-07-02 14:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-02 13:33 [trunk] Comment of the gimple_body function jeremie.salvucci
2010-07-02 13:39 ` Paolo Carlini
2010-07-02 14:00   ` jeremie.salvucci
2010-07-02 14:57     ` Diego Novillo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).