* [patch][graphite] Fix PR44726: avoid uninitialized variables
@ 2010-06-30 17:06 Sebastian Pop
2010-06-30 19:29 ` Richard Guenther
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Pop @ 2010-06-30 17:06 UTC (permalink / raw)
To: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 149 bytes --]
Hi,
I will commit this patch to trunk after it passes regstrap on amd64-linux.
Sebastian Pop
--
AMD / Open Source Compiler Engineering / GNU Tools
[-- Attachment #2: 0002-Fix-PR44726-use-gcc_assert-to-avoid-uninitialized-va.patch --]
[-- Type: text/x-patch, Size: 1869 bytes --]
From 4609d525c740b8d6710bd6f5e009431341e6dc7b Mon Sep 17 00:00:00 2001
From: Sebastian Pop <sebpop@gmail.com>
Date: Wed, 30 Jun 2010 11:21:49 -0500
Subject: [PATCH 2/2] Fix PR44726: use gcc_assert to avoid uninitialized variables.
---
gcc/graphite-sese-to-poly.c | 15 ++++++++-------
1 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/gcc/graphite-sese-to-poly.c b/gcc/graphite-sese-to-poly.c
index b73517d..7f83ffc 100644
--- a/gcc/graphite-sese-to-poly.c
+++ b/gcc/graphite-sese-to-poly.c
@@ -1778,10 +1778,11 @@ build_poly_dr (data_reference_p dr, poly_bb_p pbb)
accesses);
ppl_delete_Polyhedron (accesses);
- if (dr->aux)
- dr_base_object_set = ((base_alias_pair *)(dr->aux))->base_obj_set;
+ gcc_assert (dr->aux);
+ dr_base_object_set = ((base_alias_pair *)(dr->aux))->base_obj_set;
- new_poly_dr (pbb, dr_base_object_set, accesses_ps, DR_IS_READ (dr) ? PDR_READ : PDR_WRITE,
+ new_poly_dr (pbb, dr_base_object_set, accesses_ps,
+ DR_IS_READ (dr) ? PDR_READ : PDR_WRITE,
dr, DR_NUM_DIMENSIONS (dr));
}
@@ -1923,8 +1924,8 @@ build_alias_set_optimal_p (VEC (data_reference_p, heap) *drs)
data_reference_p dr = VEC_index (data_reference_p, drs, i);
base_alias_pair *bap;
- if (dr->aux)
- bap = (base_alias_pair *)(dr->aux);
+ gcc_assert (dr->aux);
+ bap = (base_alias_pair *)(dr->aux);
bap->alias_set = XNEW (int);
*(bap->alias_set) = g->vertices[i].component + 1;
@@ -2002,8 +2003,8 @@ build_base_obj_set_for_drs (VEC (data_reference_p, heap) *drs)
data_reference_p dr = VEC_index (data_reference_p, drs, i);
base_alias_pair *bap;
- if (dr->aux)
- bap = (base_alias_pair *)(dr->aux);
+ gcc_assert (dr->aux);
+ bap = (base_alias_pair *)(dr->aux);
bap->base_obj_set = g->vertices[i].component + 1;
}
--
1.7.0.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch][graphite] Fix PR44726: avoid uninitialized variables
2010-06-30 17:06 [patch][graphite] Fix PR44726: avoid uninitialized variables Sebastian Pop
@ 2010-06-30 19:29 ` Richard Guenther
2010-06-30 20:50 ` Sebastian Pop
0 siblings, 1 reply; 3+ messages in thread
From: Richard Guenther @ 2010-06-30 19:29 UTC (permalink / raw)
To: Sebastian Pop; +Cc: GCC Patches
On Wed, Jun 30, 2010 at 6:32 PM, Sebastian Pop <sebpop@gmail.com> wrote:
> Hi,
>
> I will commit this patch to trunk after it passes regstrap on amd64-linux.
Bootstrap & regtest passed for me on x86_64-linux, so I applied the patch
to unbreak bootstrap for me before the freeze.
Richard.
> Sebastian Pop
> --
> AMD / Open Source Compiler Engineering / GNU Tools
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch][graphite] Fix PR44726: avoid uninitialized variables
2010-06-30 19:29 ` Richard Guenther
@ 2010-06-30 20:50 ` Sebastian Pop
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Pop @ 2010-06-30 20:50 UTC (permalink / raw)
To: Richard Guenther; +Cc: GCC Patches
On Wed, Jun 30, 2010 at 13:35, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Wed, Jun 30, 2010 at 6:32 PM, Sebastian Pop <sebpop@gmail.com> wrote:
>> Hi,
>>
>> I will commit this patch to trunk after it passes regstrap on amd64-linux.
>
> Bootstrap & regtest passed for me on x86_64-linux, so I applied the patch
> to unbreak bootstrap for me before the freeze.
>
Thanks, it also passed regstrap on my machine.
Sebastian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-30 19:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-30 17:06 [patch][graphite] Fix PR44726: avoid uninitialized variables Sebastian Pop
2010-06-30 19:29 ` Richard Guenther
2010-06-30 20:50 ` Sebastian Pop
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).