From: Ramana Radhakrishnan <ramana.gcc@googlemail.com>
To: Chung-Lin Tang <cltang@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, paul@codesourcery.com, rearnsha@arm.com
Subject: Re: [patch, ARM] ICE in get_arm_condition_code()
Date: Thu, 13 Jan 2011 11:33:00 -0000 [thread overview]
Message-ID: <AANLkTimcHKoAmw+odBh3EHfja2GA9MKSmyE5YLGUD6O6@mail.gmail.com> (raw)
In-Reply-To: <4D2E4658.9090904@codesourcery.com>
On Thu, Jan 13, 2011 at 12:24 AM, Chung-Lin Tang
<cltang@codesourcery.com> wrote:
> Hi
> The report was on a 4.5 based compiler, but I verified it also occurs on
> current trunk, under Thumb-2.
>@@ -16942,6 +16943,23 @@
> static enum arm_cond_code
> get_arm_condition_code (rtx comparison)
> {
>+ enum arm_cond_code code = arm_comparison_to_cond_code (comparison);
>+ gcc_assert (code != ARM_COND_INVALID);
>+ return code;
>+}
>+
>+/* Tests if the comparison RTX is valid for ARM. */
Minor nits really that I spotted .
2 spaces after the end of a '.' before the end of comment.
>+/* Function that maps the relation between comparison RTX
>+ vs. ARM condition codes, */
s/,/. and the 2 spaces after the . rule apply.
cheers
Ramana
next prev parent reply other threads:[~2011-01-13 11:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 1:37 Chung-Lin Tang
2011-01-13 11:33 ` Ramana Radhakrishnan [this message]
2011-01-26 3:48 ` Chung-Lin Tang
2011-03-07 14:10 ` Ping " Chung-Lin Tang
2011-03-15 1:40 ` Ping^3 " Chung-Lin Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimcHKoAmw+odBh3EHfja2GA9MKSmyE5YLGUD6O6@mail.gmail.com \
--to=ramana.gcc@googlemail.com \
--cc=cltang@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=paul@codesourcery.com \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).