From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19739 invoked by alias); 13 Jan 2011 11:12:29 -0000 Received: (qmail 19729 invoked by uid 22791); 13 Jan 2011 11:12:28 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-fx0-f47.google.com (HELO mail-fx0-f47.google.com) (209.85.161.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Jan 2011 11:12:24 +0000 Received: by fxm17 with SMTP id 17so1520669fxm.20 for ; Thu, 13 Jan 2011 03:12:22 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.54.132 with SMTP id q4mr2227210fag.117.1294917142197; Thu, 13 Jan 2011 03:12:22 -0800 (PST) Received: by 10.223.70.129 with HTTP; Thu, 13 Jan 2011 03:12:22 -0800 (PST) In-Reply-To: <4D2E4658.9090904@codesourcery.com> References: <4D2E4658.9090904@codesourcery.com> Date: Thu, 13 Jan 2011 11:33:00 -0000 Message-ID: Subject: Re: [patch, ARM] ICE in get_arm_condition_code() From: Ramana Radhakrishnan To: Chung-Lin Tang Cc: gcc-patches@gcc.gnu.org, paul@codesourcery.com, rearnsha@arm.com Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-01/txt/msg00814.txt.bz2 On Thu, Jan 13, 2011 at 12:24 AM, Chung-Lin Tang wrote: > Hi > The report was on a 4.5 based compiler, but I verified it also occurs on > current trunk, under Thumb-2. >@@ -16942,6 +16943,23 @@ > static enum arm_cond_code > get_arm_condition_code (rtx comparison) > { >+ enum arm_cond_code code = arm_comparison_to_cond_code (comparison); >+ gcc_assert (code != ARM_COND_INVALID); >+ return code; >+} >+ >+/* Tests if the comparison RTX is valid for ARM. */ Minor nits really that I spotted . 2 spaces after the end of a '.' before the end of comment. >+/* Function that maps the relation between comparison RTX >+ vs. ARM condition codes, */ s/,/. and the 2 spaces after the . rule apply. cheers Ramana