From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12838 invoked by alias); 11 Mar 2011 13:10:32 -0000 Received: (qmail 12790 invoked by uid 22791); 11 Mar 2011 13:10:31 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-iy0-f175.google.com (HELO mail-iy0-f175.google.com) (209.85.210.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Mar 2011 13:10:26 +0000 Received: by iyb26 with SMTP id 26so2951216iyb.20 for ; Fri, 11 Mar 2011 05:10:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.231.171.205 with SMTP id i13mr1403840ibz.181.1299849024844; Fri, 11 Mar 2011 05:10:24 -0800 (PST) Received: by 10.231.10.130 with HTTP; Fri, 11 Mar 2011 05:10:24 -0800 (PST) In-Reply-To: References: <1299817406-16745-1-git-send-email-froydnj@codesourcery.com> <1299817406-16745-8-git-send-email-froydnj@codesourcery.com> Date: Fri, 11 Mar 2011 13:10:00 -0000 Message-ID: Subject: Re: [PATCH 07/18] generalize build_case_label to the rest of the compiler From: Richard Guenther To: "Joseph S. Myers" Cc: Nathan Froyd , gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org, java-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg00596.txt.bz2 On Fri, Mar 11, 2011 at 2:01 PM, Joseph S. Myers wrote: > On Thu, 10 Mar 2011, Nathan Froyd wrote: > >> This patch does lose location information on CASE_LABEL_EXPRs from the C >> family of front-ends; it did not seem worth it to have a number of >> places pass input_location when said information isn't even used. =A0I'm >> happy to add the location_t argument back to CASE_LABEL_EXPRs if people >> think that's worthwhile. > > Since implicit use of input_location is deprecated and should be being > phased out (making more locations explicit - including explicit > input_location until the places using it have a better location > available), I think you should keep the location argument. > > The C front-end changes in this patch series (including c-family changes) > are otherwise OK. Yep, please pass UNKNOWN_LOCATION at callers that didn't set a location (and add a location argument to build_case_label). Thanks, Richard. > -- > Joseph S. Myers > joseph@codesourcery.com >