From: "H.J. Lu" <hjl.tools@gmail.com>
To: Xinliang David Li <davidxl@google.com>
Cc: Pat Haugen <pthaugen@us.ibm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Zdenek Dvorak <rakdver@kam.mff.cuni.cz>
Subject: Re: IVOPT improvement patch
Date: Fri, 30 Jul 2010 15:06:00 -0000 [thread overview]
Message-ID: <AANLkTimk7qYPZ=dO-fsfLHwkEpP0XKufjQJ5Wrkw5GFT@mail.gmail.com> (raw)
In-Reply-To: <AANLkTinrNbZXtXiZYhyt0V_ijipZdPR=--KSbE4Ao5yy@mail.gmail.com>
On Wed, Jul 28, 2010 at 8:50 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Jul 28, 2010 at 6:07 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Tue, Jul 27, 2010 at 1:20 PM, Xinliang David Li <davidxl@google.com> wrote:
>>> On Tue, Jul 27, 2010 at 12:57 PM, Pat Haugen <pthaugen@us.ibm.com> wrote:
>>>>>
>>>>> Thanks Sebatian for testing it out. I also asked Pat to help testing
>>>>> the patch again on powerpc. I will first split off the unrelated
>>>>> patches and submit them first (e.g, multiple exit loop handling etc).
>>>>>
>>>>
>>>> There were 2 good improvements on PowerPC, the rest were pretty much a wash
>>>> (< +/-2%):
>>>>
>>>> 410.bwaves 10.0%
>>>> 434.zeusmp 6.6%
>>>>
>>>> One thing I did notice however is that comparing these results to the run I
>>>> did back in May on an earlier version of the patch is that both
>>>> improvements dropped. bwaves was 27% on that run and zeusmp was 8.4%. I
>>>> don't have the old builds around, but could recreate if you're not aware of
>>>> anything to explain the drop.
>>>>
>>>
>>> Thanks. I will check in this version first and do some triaging on the
>>> performance drop (with your help). One thing to be aware is that
>>> r161844 was checked in during this period of time which might be
>>> related, but not sure until further investigation -- the two stage
>>> initial iv set computation introduced by the patch may not be needed
>>> (if this patch is in).
>>>
>>
>> Your checkin caused:
>>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45119
>>
>
> This also caused:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45121
>
This bug isn't fixed. David, did you verify your change by
running "make check"?
Thanks.
--
H.J.
next prev parent reply other threads:[~2010-07-30 14:49 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 6:35 Xinliang David Li
2010-05-11 7:18 ` Zdenek Dvorak
2010-05-11 17:29 ` Xinliang David Li
2010-05-25 0:17 ` Xinliang David Li
2010-05-25 10:46 ` Zdenek Dvorak
2010-05-25 17:39 ` Xinliang David Li
2010-05-25 18:25 ` Zdenek Dvorak
2010-05-25 23:30 ` Xinliang David Li
2010-05-26 2:35 ` Zdenek Dvorak
2010-05-26 3:17 ` Xinliang David Li
2010-05-27 1:31 ` Xinliang David Li
2010-05-27 9:12 ` Zdenek Dvorak
2010-05-27 17:33 ` Xinliang David Li
2010-05-28 9:14 ` Zdenek Dvorak
2010-05-28 23:51 ` Xinliang David Li
2010-05-29 16:57 ` Zdenek Dvorak
2010-05-29 19:51 ` Xinliang David Li
2010-05-29 20:18 ` Zdenek Dvorak
2010-05-30 0:22 ` Xinliang David Li
[not found] ` <20100604105451.GB5105@kam.mff.cuni.cz>
2010-07-21 7:27 ` Xinliang David Li
2010-07-26 16:33 ` Sebastian Pop
2010-07-26 16:43 ` Xinliang David Li
2010-07-27 20:04 ` Pat Haugen
2010-07-27 20:25 ` Xinliang David Li
2010-07-29 3:50 ` H.J. Lu
2010-07-29 5:57 ` H.J. Lu
2010-07-29 7:44 ` Xinliang David Li
2010-07-29 8:28 ` Zdenek Dvorak
2010-07-29 14:37 ` H.J. Lu
2010-07-29 15:27 ` H.J. Lu
2010-07-29 16:09 ` H.J. Lu
2010-07-29 16:17 ` Richard Guenther
2010-07-29 16:55 ` H.J. Lu
2010-07-30 1:04 ` Xinliang David Li
2010-07-30 2:06 ` H.J. Lu
2010-07-30 5:41 ` Xinliang David Li
2010-07-30 7:19 ` Jakub Jelinek
2010-07-30 16:45 ` Xinliang David Li
2010-07-30 15:56 ` H.J. Lu
2010-07-30 16:58 ` Xinliang David Li
2010-07-30 17:07 ` Xinliang David Li
2010-07-30 17:43 ` H.J. Lu
2010-07-30 18:10 ` Xinliang David Li
2010-07-30 18:57 ` H.J. Lu
2010-07-30 21:04 ` H.J. Lu
2010-07-30 21:13 ` Xinliang David Li
2010-08-02 21:23 ` Xinliang David Li
2010-08-09 8:44 ` Zdenek Dvorak
2010-08-09 23:07 ` Xinliang David Li
2010-08-10 2:37 ` Xinliang David Li
2010-08-10 13:13 ` Zdenek Dvorak
2010-08-10 13:35 ` H.J. Lu
2010-08-10 14:18 ` H.J. Lu
2010-08-10 16:31 ` Xinliang David Li
2010-08-10 16:38 ` H.J. Lu
2010-08-10 17:13 ` Xinliang David Li
2010-08-10 17:26 ` H.J. Lu
2010-08-10 17:42 ` Xinliang David Li
2010-08-11 0:45 ` Xinliang David Li
2010-07-30 17:01 ` Xinliang David Li
2010-07-29 16:11 ` H.J. Lu
2010-07-29 14:17 ` H.J. Lu
2010-07-29 17:00 ` Xinliang David Li
2010-07-29 17:10 ` H.J. Lu
2010-10-28 19:28 ` H.J. Lu
2011-04-27 13:23 ` H.J. Lu
2010-07-30 15:06 ` H.J. Lu [this message]
2010-07-30 16:50 ` Xinliang David Li
2010-07-30 18:28 ` Bernd Schmidt
2010-07-30 18:34 ` Xinliang David Li
2010-07-29 7:26 ` Xinliang David Li
2010-12-30 17:23 ` H.J. Lu
2010-05-25 18:10 ` Toon Moene
2010-05-27 9:28 ` Zdenek Dvorak
2010-05-27 17:51 ` Xinliang David Li
2010-05-27 22:48 ` Zdenek Dvorak
2010-05-27 23:41 ` Xinliang David Li
2010-05-28 9:57 ` Zdenek Dvorak
2010-06-01 23:13 ` Xinliang David Li
2010-06-02 20:57 ` Zdenek Dvorak
2010-06-03 5:39 ` Xinliang David Li
2010-06-05 9:01 ` Zdenek Dvorak
2010-06-05 22:37 ` Xinliang David Li
2010-05-11 7:26 ` Steven Bosscher
2010-05-11 17:23 ` Xinliang David Li
2010-05-11 8:34 ` Richard Guenther
2010-05-11 9:48 ` Jan Hubicka
2010-05-11 10:04 ` Steven Bosscher
2010-05-11 14:24 ` Peter Bergner
2010-05-11 17:28 ` Xinliang David Li
2010-05-12 8:55 ` Richard Guenther
2010-05-11 17:19 ` Toon Moene
2010-05-11 17:49 ` Xinliang David Li
2010-05-11 21:52 ` Toon Moene
2010-05-11 22:31 ` Xinliang David Li
2010-05-11 22:44 ` Toon Moene
2010-05-13 13:00 ` Toon Moene
2010-05-13 13:30 ` Toon Moene
2010-05-13 16:23 ` Xinliang David Li
2010-05-14 4:26 ` Xinliang David Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimk7qYPZ=dO-fsfLHwkEpP0XKufjQJ5Wrkw5GFT@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=davidxl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pthaugen@us.ibm.com \
--cc=rakdver@kam.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).