From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12680 invoked by alias); 30 Jun 2010 10:52:47 -0000 Received: (qmail 12660 invoked by uid 22791); 30 Jun 2010 10:52:45 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM X-Spam-Check-By: sourceware.org Received: from mail-wy0-f175.google.com (HELO mail-wy0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Jun 2010 10:52:38 +0000 Received: by wye20 with SMTP id 20so507790wye.20 for ; Wed, 30 Jun 2010 03:52:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.174.142 with SMTP id x14mr6903653wel.8.1277895155743; Wed, 30 Jun 2010 03:52:35 -0700 (PDT) Received: by 10.216.182.129 with HTTP; Wed, 30 Jun 2010 03:52:35 -0700 (PDT) In-Reply-To: <4C2B1F59.8020205@codesourcery.com> References: <4BD075C9.1080502@codesourcery.com> <4C0D0656.4060903@codesourcery.com> <4C293731.4080500@redhat.com> <4C293DB0.8020201@codesourcery.com> <4C295B32.9070104@redhat.com> <4C29F386.2090006@codesourcery.com> <4C2B0569.3000500@codesourcery.com> <4C2B1340.5070202@codesourcery.com> <4C2B1A2C.50702@codesourcery.com> <4C2B1F59.8020205@codesourcery.com> Date: Wed, 30 Jun 2010 12:10:00 -0000 Message-ID: Subject: Re: Resubmit/ping: peephole2 vs cond-exec vs df From: Richard Guenther To: Bernd Schmidt Cc: "H.J. Lu" , Andrew Pinski , Richard Henderson , GCC Patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-06/txt/msg03110.txt.bz2 On Wed, Jun 30, 2010 at 12:41 PM, Bernd Schmidt w= rote: > On 06/30/2010 12:31 PM, Richard Guenther wrote: >> On Wed, Jun 30, 2010 at 12:19 PM, Bernd Schmidt wrote: >>> On 06/30/2010 12:00 PM, Richard Guenther wrote: >>> >>>> We're peepholing in circles after your patch. =A0The peephole2 >>>> dump isn't very informative - how can I see which peephole2s >>>> matched? >>> >>> Not easily. =A0Maybe breakpoints on all the gen_peephole2_ functions; we >>> should probably add that to the dumps. >>> >>> Seems to be something involving FIX insns, I suspect >>> >>> ;; Shorten x87->SSE reload sequences of fix_trunc?f?i_sse patterns. >>> (define_peephole2 >>> =A0[(set (match_operand:MODEF 0 "register_operand" "") >>> =A0 =A0 =A0 =A0(match_operand:MODEF 1 "memory_operand" "")) >>> =A0 (set (match_operand:SSEMODEI24 2 "register_operand" "") >>> =A0 =A0 =A0 =A0(fix:SSEMODEI24 (match_dup 0)))] >>> =A0"TARGET_SHORTEN_X87_SSE >>> =A0 && peep2_reg_dead_p (2, operands[0])" >>> =A0[(set (match_dup 2) (fix:SSEMODEI24 (match_dup 1)))] >>> =A0"") >> >> I suppose adding && !TARGET_AVOID_VECTOR_DECODE >> would fix it. =A0Testing that. > > I just added "0 &&" to one of the patterns, it also fixed the Fortran > testcase. =A0Also running a bootstrap... > > Do you want to take it from here with your version? Yes. I'm through bootstrap and into testing right now. Richard. > > Bernd >