From: Laurynas Biveinis <laurynas.biveinis@gmail.com>
To: crquan@gmail.com
Cc: gcc-patches@gcc.gnu.org, "Dennis,
CHENG Renquan" <crquan@fedoraproject.org>
Subject: Re: [PATCH] Try to fill crossref in passes.texi (GCC Internals)
Date: Fri, 09 Jul 2010 12:59:00 -0000 [thread overview]
Message-ID: <AANLkTimsi9GB45BTh74C-J_JmqSU4Pmp4u1Pn2Q71O8M@mail.gmail.com> (raw)
In-Reply-To: <1278092495-27709-1-git-send-email-crquan@gmail.com>
Hello,
> Hi, all,
> I'm new to Gcc hacking world, while reading these documentation (GCC Internals),
> found some places like this passes.texi may be unfinished, especially the places
> marked as CROSSREF, BUG, and TODO should be, right? I am trying to finish some
> parts in a series of patches; please give comments for anywhere I may be wrong;
> Thanks,
I am not too qualified to comment on the patch itself (to my limited
understanding of Texinfo, it looks fine), however:
- all GCC patches must have ChangeLog entries, including documentation ones;
- the patch submission needs to state how the patch was tested. In the
case of a documentation patch it amounts to running make info dvi, see
http://gcc.gnu.org/contribute.html under "Documentation Changes".
Could you resubmit the patch with these requirements addressed?
Thank you,
--
Laurynas
next prev parent reply other threads:[~2010-07-09 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 17:42 crquan
2010-07-09 12:59 ` Laurynas Biveinis [this message]
2010-07-09 13:12 ` Manuel López-Ibáñez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimsi9GB45BTh74C-J_JmqSU4Pmp4u1Pn2Q71O8M@mail.gmail.com \
--to=laurynas.biveinis@gmail.com \
--cc=crquan@fedoraproject.org \
--cc=crquan@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).