Re: RFA: PATCH: -Wimplicit-double

["Manuel López-Ibáñez" <lopezibanez@gmail.com>]

On 3 September 2010 19:18, Mark Mitchell <mark@codesourcery.com> wrote:
> On 9/3/2010 8:59 AM, Mark Mitchell wrote:
>
>> This patch implements -Wimplicit-double, a new warning.  The goal of
>> the warning is to warn users when a "float" is implicitly converted to
>> a "double".
>
> Joseph asked me off-list to make a couple of low-level corrections:
>
> (a) Use warning_at where possible
> (b) Name the parameter to do_warn_implicit_double "gmsgid" for i18n
>
> Thanks,

This is warned already by Wconversion for both C and C++ and Fortran!
If it doesn't catch all cases, then that should be fixed appropriately
to use existing code as much as possible. And there are testcases
already for this in the testsuite.

The name of the option suggests that existing Wimplicit-int should do
something similar for integers, which is not the case at all. So bad
name. I suggest Wconversion-double or Wdouble-conversion and make this
option enabled by Wconversion  similar to existing option
Wnull-conversion.

So I think this patch is not OK at all.

Cheers,

Manuel.