* [PATCH] Fix 2010-06-08 gc-improv-merge, for AVMS
@ 2010-06-26 9:35 Douglas B Rupp
2010-06-26 17:35 ` Laurynas Biveinis
2010-07-08 0:00 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Douglas B Rupp @ 2010-06-26 9:35 UTC (permalink / raw)
To: laurynas.biveinis; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 142 bytes --]
The above named patch breaks Alpha/VMS.
Please find proposed patch attached, to fix.
Is it correct and ok to commit?
--Douglas Rupp
AdaCore
[-- Attachment #2: splaytreevms.dif.txt --]
[-- Type: text/plain, Size: 1668 bytes --]
2010-06-25 Douglas B Rupp <rupp@gnat.com>
* alpha.c (alpha_need_linkage): Adjust splay_tree_new_ggc call.
(alpha_use_linkage): Likewise.
diff -rupN gcc/config/alpha/alpha.c gcc/config/alpha/alpha.c
--- gcc/config/alpha/alpha.c 2010-06-08 00:25:24.000000000 -0700
+++ gcc/config/alpha/alpha.c 2010-06-25 16:22:31.000000000 -0700
@@ -9900,8 +9900,11 @@ alpha_need_linkage (const char *name, in
struct alpha_funcs *cfaf;
if (!alpha_funcs_tree)
- alpha_funcs_tree = splay_tree_new_ggc ((splay_tree_compare_fn)
- splay_tree_compare_pointers);
+ alpha_funcs_tree = splay_tree_new_ggc
+ (splay_tree_compare_pointers,
+ ggc_alloc_splay_tree_tree_node_tree_node_splay_tree_s,
+ ggc_alloc_splay_tree_tree_node_tree_node_splay_tree_node_s);
+
cfaf = ggc_alloc_alpha_funcs ();
@@ -9937,7 +9940,10 @@ alpha_need_linkage (const char *name, in
}
}
else
- alpha_links_tree = splay_tree_new_ggc ((splay_tree_compare_fn) strcmp);
+ alpha_links_tree = splay_tree_new_ggc
+ ((splay_tree_compare_fn) strcmp,
+ ggc_alloc_splay_tree_str_alpha_links_splay_tree_s,
+ ggc_alloc_splay_tree_str_alpha_links_splay_tree_node_s);
al = ggc_alloc_alpha_links ();
name = ggc_strdup (name);
@@ -9995,7 +10001,10 @@ alpha_use_linkage (rtx func, tree cfunde
al = (struct alpha_links *) lnode->value;
}
else
- cfaf->links = splay_tree_new_ggc ((splay_tree_compare_fn) strcmp);
+ cfaf->links = splay_tree_new_ggc
+ ((splay_tree_compare_fn) strcmp,
+ ggc_alloc_splay_tree_str_alpha_links_splay_tree_s,
+ ggc_alloc_splay_tree_str_alpha_links_splay_tree_node_s);
if (!al)
{
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix 2010-06-08 gc-improv-merge, for AVMS
2010-06-26 9:35 [PATCH] Fix 2010-06-08 gc-improv-merge, for AVMS Douglas B Rupp
@ 2010-06-26 17:35 ` Laurynas Biveinis
2010-07-08 0:00 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Laurynas Biveinis @ 2010-06-26 17:35 UTC (permalink / raw)
To: Douglas B Rupp; +Cc: gcc-patches
2010/6/26 Douglas B Rupp <rupp@gnat.com>:
> The above named patch breaks Alpha/VMS.
> Please find proposed patch attached, to fix.
> Is it correct and ok to commit?
>
> --Douglas Rupp
> AdaCore
>
>
> 2010-06-25 Douglas B Rupp <rupp@gnat.com>
>
> * alpha.c (alpha_need_linkage): Adjust splay_tree_new_ggc call.
> (alpha_use_linkage): Likewise.
I cannot approve this, but it looks correct to me and IMHO you can
apply it as an obvious patch.
I don't know how this slipped past my testing; thanks for fixing it.
--
Laurynas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix 2010-06-08 gc-improv-merge, for AVMS
2010-06-26 9:35 [PATCH] Fix 2010-06-08 gc-improv-merge, for AVMS Douglas B Rupp
2010-06-26 17:35 ` Laurynas Biveinis
@ 2010-07-08 0:00 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2010-07-08 0:00 UTC (permalink / raw)
To: Douglas B Rupp; +Cc: laurynas.biveinis, gcc-patches
> 2010-06-25 Douglas B Rupp <rupp@gnat.com>
>
> * alpha.c (alpha_need_linkage): Adjust splay_tree_new_ggc call.
> (alpha_use_linkage): Likewise.
Ok.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-08 0:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-26 9:35 [PATCH] Fix 2010-06-08 gc-improv-merge, for AVMS Douglas B Rupp
2010-06-26 17:35 ` Laurynas Biveinis
2010-07-08 0:00 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).