From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-270202-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 14335 invoked by alias); 10 Aug 2010 14:12:24 -0000
Received: (qmail 14320 invoked by uid 22791); 10 Aug 2010 14:12:23 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE
X-Spam-Check-By: sourceware.org
Received: from mail-pv0-f175.google.com (HELO mail-pv0-f175.google.com) (74.125.83.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Aug 2010 14:12:18 +0000
Received: by pvg6 with SMTP id 6so1253740pvg.20        for <gcc-patches@gcc.gnu.org>; Tue, 10 Aug 2010 07:12:16 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.114.39.18 with SMTP id m18mr20266769wam.225.1281449536692; 	Tue, 10 Aug 2010 07:12:16 -0700 (PDT)
Received: by 10.220.194.197 with HTTP; Tue, 10 Aug 2010 07:12:15 -0700 (PDT)
In-Reply-To: <AANLkTimZvYj-k3Lc9tyVJ0rMGMinFBWZ2VbXWj0NRrBi@mail.gmail.com>
References: <AANLkTinguXaw6KR1xi2Tz3O+wpRxiwAqW28+g+yJC6Lf@mail.gmail.com>	<AANLkTinNyB83vfkwZp0Lxu03H+DNpD-AvBt803pt=4qi@mail.gmail.com>	<AANLkTikX01vs8_taOwuEnULBkXaRhr1rQHQR4KUMXuM7@mail.gmail.com>	<AANLkTiktVKVmNnQRyp=OQfJ1+DAYkRQgTso3Qb-kV3nJ@mail.gmail.com>	<AANLkTi=dFqKHoU=xkTuq6bKMvg9f2oGX4UaCot1XS-gP@mail.gmail.com>	<AANLkTimEGjvDmFe1qjFvn5gfiNpnnt9ORM6RA6RCXpdY@mail.gmail.com>	<AANLkTi=4HF2sKUPfhS5GRJTLW1g7rYRTn8iihkmYH6k2@mail.gmail.com>	<AANLkTimk3b3tmDr3g8KKDGvJ6HczpPJXNdGoV9cE0a9A@mail.gmail.com>	<AANLkTima5mV3OL=HuY_Sw54NtNU4-0RaY+z6jaNzA0Sc@mail.gmail.com>	<AANLkTinXtucQKd-c1XLAFZj1Q25ibbTq1gDE4Xm1korU@mail.gmail.com>	<20100809075525.GA16026@kam.mff.cuni.cz>	<AANLkTi=1EV2b8ZLQ5wNtWbJmh-21xrLd_R1R3KdK62L+@mail.gmail.com>	<AANLkTik-5LWK57_mYadOF1n1_s32=sWucAT6H7i41s4O@mail.gmail.com>	<AANLkTimZvYj-k3Lc9tyVJ0rMGMinFBWZ2VbXWj0NRrBi@mail.gmail.com>
Date: Tue, 10 Aug 2010 14:18:00 -0000
Message-ID: <AANLkTin4o_-usDikk-TphbYtFz=kX+_iuyyG4TEOcFJV@mail.gmail.com>
Subject: Re: IVOPT improvement patch
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Xinliang David Li <davidxl@google.com>
Cc: Zdenek Dvorak <rakdver@kam.mff.cuni.cz>, GCC Patches <gcc-patches@gcc.gnu.org>, 	Richard Guenther <richard.guenther@gmail.com>, Pat Haugen <pthaugen@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2010-08/txt/msg00748.txt.bz2

On Tue, Aug 10, 2010 at 6:16 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Aug 9, 2010 at 4:47 PM, Xinliang David Li <davidxl@google.com> wr=
ote:
>> Wrong patch in the last email. Here is the one.
>>
>
> You changed the code from setting "off" to setting "offset":
>
> - =A0 =A0 =A0data->min_offset =3D i =3D=3D start ? 0 : -(i >> 1);
> + =A0 =A0 =A0data->max_offset =3D (i =3D=3D -1? 0 : off);
> + =A0 =A0 =A0offset =3D data->max_offset;
>
> "off" is used later:
>
> 3345 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (off_p)
> 3346 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 base =3D gen_rtx_fmt_e (CONST, addre=
ss_mode,
> 3347 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 gen_rtx_fmt_ee
> 3348 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 (PLUS, address_mode, base,
> 3349 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0gen_int_mode (off,
> address_mode))) =A0 =A0 ;
> 3350 =A0 =A0 =A0 =A0 =A0 =A0 }
> 3351 =A0 =A0 =A0 =A0 =A0 else if (off_p)
> 3352 =A0 =A0 =A0 =A0 =A0 =A0 base =3D gen_int_mode (off, address_mode);
> 3353 =A0 =A0 =A0 =A0 =A0 else
>
> You can just add
>
> off =3D 0;
>
> before the loop. Then you can use
>
> data->min_offset =3D off;
> data->max_offset =3D off;
>
> after the loop. It is faster.
>

Never mind this comment. But "off" is different from before.



--=20
H.J.