From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21982 invoked by alias); 14 Dec 2010 08:14:46 -0000 Received: (qmail 21971 invoked by uid 22791); 14 Dec 2010 08:14:44 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qy0-f182.google.com (HELO mail-qy0-f182.google.com) (209.85.216.182) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Dec 2010 08:14:38 +0000 Received: by qyk36 with SMTP id 36so436784qyk.20 for ; Tue, 14 Dec 2010 00:14:37 -0800 (PST) Received: by 10.229.235.142 with SMTP id kg14mr4547738qcb.42.1292314477037; Tue, 14 Dec 2010 00:14:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.181.193 with HTTP; Tue, 14 Dec 2010 00:14:16 -0800 (PST) In-Reply-To: References: <1291979498-1604-1-git-send-email-dodji@redhat.com> <1291979498-1604-5-git-send-email-dodji@redhat.com> <4D063157.3050901@gnu.org> From: Paolo Bonzini Date: Tue, 14 Dec 2010 08:31:00 -0000 Message-ID: Subject: Re: [PATCH 3/6] Emit macro expansion related diagnostics To: Gabriel Dos Reis Cc: Dodji Seketeli , gcc-patches@gcc.gnu.org, tromey@redhat.com, joseph@codesourcery.com, lopezibanez@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-12/txt/msg01071.txt.bz2 On Tue, Dec 14, 2010 at 08:28, Gabriel Dos Reis wrote: > Agreed. =A0But I also agree with Paolo's observation: the prefix "= : note" > has to precede the diagnostic message. =A0I know there are other compilers > that do it differently, but GCC convention has been to precede diagnostics > with loci That was my main point, yes. I'm not sure about the verboseness of having two lines per level of macro expansion, but I can live with that and it was secondary in my message. Paolo