Re: gengtype improvements for plugins, thirdround! patch 2/7 [verbosity]

[Laurynas Biveinis <laurynas.biveinis@gmail.com>]

2010/9/21 Basile Starynkevitch <basile@starynkevitch.net>:
> In addition of verbose messages, we added a tiny but useful feature to
> gengtype. When given a backup directory thru the -B program option and
> when it is generating a file gt-foo.h, gengtype renames the old
> version into the backup directory so that the user could compare the
> old version with the current one.  Verbosity & backing up of old files
> go together (in verbose mode, the renaming is told to the
> user). Backing up is no longer by default.  Per Laurynas' wish, it
> should be enabled by its program option.

Although I agree that if backups go in, they should have their own
switch, my wish was to remove the backup feature altogether. Merits of
backups aside, since now backup is independent from verbosity, it
should be submitted in a separate patch.

@@ -1511,8 +1520,15 @@ static void
 set_gc_used (pair_p variables)
 {
   pair_p p;
+  int nbvars = 0;
   for (p = variables; p; p = p->next)
+    {
+      DBGPRINTF ("set_gc_used p %p '%s' nbvars %d", (void*) p,
p->name, nbvars);
     set_gc_used_type (p->type, GC_USED, NULL);

Indentation is wrong.

+      if (!is_file_equal (of))
+	{

Indentation is wrong.

@@ -2894,11 +2941,26 @@ write_types (outf_p output_header, type_
 	  {
 	    type_p ss;
 	    for (ss = s->u.s.lang_struct; ss; ss = ss->next)
+	      {
+		nbfun++;
+		DBGPRINTF ("writing func #%d lang_struct ss @ %p '%s'",
+			   nbfun, (void*) ss, ss->u.s.tag);
 	      write_func_for_structure (s, ss, NULL, wtd);
 	  }
+	  }
 	else
+	  {
+	    nbfun++;
+	    DBGPRINTF ("writing func #%d struct s @ %p '%s'",
+		       nbfun, (void*) s, s->u.s.tag);
 	  write_func_for_structure (s, s, NULL, wtd);
       }
+      }

Indentation is wrong.

+	  DBGPRINTF ("write_enum_defn s %p #%d is unionorstruct tagged %s",

union or struct. Also indentation is wrong in the code surrounding this line.

> 2010-09-20  Jeremie Salvucci  <jeremie.salvucci@free.fr>
>            Basile Starynkevitch  <basile@starynkevitch.net>
>
>        * gengtype.c (verbosity_level, backup_dir): Added variables.
>        (set_gc_used): Count variables for verbosity.
>        (close_output_files): Backing up files, counting written ones
>        verbosily.
>        (write_types): Count emitted functions for verbosity. Added
>        debug messages.
>        (write_enum_defn): Count structures for verbosity. Added debug
>        messages.
>        (gengtype_long_options): Added "verbose".
>        (print_usage): Ditto.
>        (main): Verbose display of parsed files.
>
>        * gengtype.h (verbosity_level): Added declaration.

-- 
Laurynas