From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26770 invoked by alias); 19 Oct 2010 02:48:29 -0000 Received: (qmail 26762 invoked by uid 22791); 19 Oct 2010 02:48:28 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-qy0-f182.google.com (HELO mail-qy0-f182.google.com) (209.85.216.182) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Oct 2010 02:48:24 +0000 Received: by qyk30 with SMTP id 30so1671219qyk.20 for ; Mon, 18 Oct 2010 19:48:22 -0700 (PDT) Received: by 10.229.182.3 with SMTP id ca3mr4600594qcb.173.1287456502640; Mon, 18 Oct 2010 19:48:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.25.208 with HTTP; Mon, 18 Oct 2010 19:48:02 -0700 (PDT) In-Reply-To: <20101018190058.f77cb42c.basile@starynkevitch.net> References: <20100921210301.d92889be.basile@starynkevitch.net> <20100921210829.5f2ea8b0.basile@starynkevitch.net> <20100921211217.df1ef337.basile@starynkevitch.net> <20101018190058.f77cb42c.basile@starynkevitch.net> From: Laurynas Biveinis Date: Tue, 19 Oct 2010 06:57:00 -0000 Message-ID: Subject: Re: gengtype patch removing location_s To: Basile Starynkevitch Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-10/txt/msg01579.txt.bz2 2010/10/18 Basile Starynkevitch : > 2010-10-18 =C2=A0Basile Starynkevitch =C2=A0 > =C2=A0 =C2=A0 =C2=A0 =C2=A0* gengtype (new_structure): Remove ad-hoc "loc= ation_s" processing. * gengtype.c OK with ChangeLog fix and... /* temporary kludge - gengtype doesn't handle conditionals or macros. Ignore any attempt to define struct location_s, unless it is coming from this file (main() sets it up safely). */ if (!strcmp (name, "location_s") && !isunion && pos->file !=3D this_file) return find_structure (name, 0); ...this fragment removed too (beginning of new_structure). BTW grep shows that location_s is mentioned in a comment in libcpp/include/input.h, bonus points if you take care of that too :) Thanks, --=20 Laurynas