From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9301 invoked by alias); 21 Sep 2010 13:59:02 -0000 Received: (qmail 9277 invoked by uid 22791); 21 Sep 2010 13:59:01 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-bw0-f47.google.com (HELO mail-bw0-f47.google.com) (209.85.214.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Sep 2010 13:58:52 +0000 Received: by bwz2 with SMTP id 2so5889905bwz.20 for ; Tue, 21 Sep 2010 06:58:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.112.129 with SMTP id w1mr7575206bkp.204.1285077529598; Tue, 21 Sep 2010 06:58:49 -0700 (PDT) Received: by 10.204.81.211 with HTTP; Tue, 21 Sep 2010 06:58:49 -0700 (PDT) In-Reply-To: <20100920222130.27269.77777@gimli.local> References: <20100920222130.27269.49914@gimli.local> <20100920222130.27269.77777@gimli.local> Date: Tue, 21 Sep 2010 14:34:00 -0000 Message-ID: Subject: Re: [Patch, fortran] [4/5] PR 45648: Inline transpose part 2: Remove ss lookup From: Paul Richard Thomas To: Mikael Morin Cc: gfortran , patches Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-09/txt/msg01666.txt.bz2 Mikael, This is OK. Cheers Paul On 9/21/10, Mikael Morin wrote: > This one is optional. > I noticed while working on these patches that there were loops to get the ss > corresponding to the expr to be evaluated. This is a contradiction with > other places in the code where se->ss is supposed to be in sync (this is the > point of gfc_advance_se_ss_chain) with the expression to be calculated (grep > "ss->expr == expr"). Furthermore, the first half of the function was using > secss (with lookup) and the second ss (without). > Thus, this removes the ss lookup and replaces the asserts with their > equivalent without lookup. There is no behavioural change and this is not > directly related to the patchset, so this is optional. > > OK for trunk? > > > -- The knack of flying is learning how to throw yourself at the ground and miss. --Hitchhikers Guide to the Galaxy