From: "H.J. Lu" <hjl.tools@gmail.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: Andrew Pinski <pinskia@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Uros Bizjak <ubizjak@gmail.com>
Subject: PATCH: Turn on -fomit-frame-pointer by default for 32bit Linux/x86
Date: Mon, 26 Jul 2010 16:41:00 -0000 [thread overview]
Message-ID: <AANLkTinR6uC2_Vqd+_R17KO+_zL0+FwJFPYPLxu0Jkdc@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2884 bytes --]
On Wed, Jul 14, 2010 at 2:55 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Jul 14, 2010 at 6:46 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Wed, Jul 14, 2010 at 1:09 AM, Richard Guenther
>> <richard.guenther@gmail.com> wrote:
>>> On Tue, Jul 13, 2010 at 11:44 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>> On Tue, Jul 13, 2010 at 2:02 PM, Andrew Pinski <pinskia@gmail.com> wrote:
>>>>> On Tue, Jul 13, 2010 at 2:01 PM, Andrew Pinski <pinskia@gmail.com> wrote:
>>>>>> On Tue, Jul 13, 2010 at 1:59 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>>>>> What will stop working when -fomit-frame-pointer is on?
>>>>>>
>>>>>> backtraces when debugging information is not turned on.
>>>>>
>>>>> See http://gcc.gnu.org/ml/gcc-patches/2004-08/msg01033.html and many
>>>>> more. This is not the first time this has been discussed.
>>>>
>>>> Most of 32bit x86 assembly codes in glibc have .eh_frame section.
>>>> If backtrace is absolutely needed, they can add -fasynchronous-unwind-tables
>>>> or -fno-omit-frame-pointer.
>>>
>>> We build opensuse with -fomit-frame-pointer -fasynchronous-unwind-tables.
>>> If you want to make -fomit-frame-pointer the default then you should enable
>>> unwind tables by default.
>>>
>>
>> I will try and make it target/OS dependent.
>>
>
> Here is a patch. How does it look?
>
Here are the updated patch and spread sheet for SPEC CPU 2000/2006 on
Intel Core i7 which shows that -fomit-frame-pointer -fasynchronous-unwind-tables
improves performance by up to 12% at -O2 and 8% at -O3. For -Os, it improves
performance by up to 20%, but also increases code by up to 36%.
This patch turns on -fomit-frame-pointer -fasynchronous-unwind-tables only if
-Os isn't used.
Tested on Linux/ia32 and Linux/x86-64 with -m32. OK for trunk?
Thanks.
--
H.J.
---
gcc/
2010-07-25 H.J. Lu <hongjiu.lu@intel.com>
* config/i386/i386.c (override_options): For 32bit, default
flag_omit_frame_pointer and flag_asynchronous_unwind_tables
to TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT and
TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT.
* config/i386/i386.h (TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT):
New.
(TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT): Likewise.
* config/i386/linux.h (TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT):
Likewise.
(TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT): Likewise.
* config/i386/linux64.h (TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT):
Likewise.
(TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT): Likewise.
gcc/testsuite/
2010-07-25 H.J. Lu <hongjiu.lu@intel.com>
* gcc.target/i386/frame-pointer-1.c: New.
* gcc.target/i386/frame-pointer-2.c: Likewise.
* gcc.target/i386/frame-pointer-3.c: Likewise.
* gcc.target/i386/frame-pointer-4.c: Likewise.
* gcc.target/i386/frame-pointer-5.c: Likewise.
[-- Attachment #2: gcc-i386-fp-3.patch --]
[-- Type: text/plain, Size: 6781 bytes --]
gcc/
2010-07-25 H.J. Lu <hongjiu.lu@intel.com>
* config/i386/i386.c (override_options): For 32bit, default
flag_omit_frame_pointer and flag_asynchronous_unwind_tables
to TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT and
TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT.
* config/i386/i386.h (TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT):
New.
(TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT): Likewise.
* config/i386/linux.h (TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT):
Likewise.
(TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT): Likewise.
* config/i386/linux64.h (TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT):
Likewise.
(TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT): Likewise.
gcc/testsuite/
2010-07-25 H.J. Lu <hongjiu.lu@intel.com>
* gcc.target/i386/frame-pointer-1.c: New.
* gcc.target/i386/frame-pointer-2.c: Likewise.
* gcc.target/i386/frame-pointer-3.c: Likewise.
* gcc.target/i386/frame-pointer-4.c: Likewise.
* gcc.target/i386/frame-pointer-5.c: Likewise.
diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index dbb8949..640243e 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -2985,10 +2985,27 @@ override_options (bool main_args_p)
{
if (flag_zee == 2)
flag_zee = 0;
+ /* Unwind info is not correct around the CFG unless either a
+ frame pointer is present or -maccumulate-outgoing-args is
+ set. When both -fasynchronous-unwind-tables and
+ -fomit-frame-pointer are turned on by default, turn off
+ both if -mno-accumulate-outgoing-args is used. When
+ optimizing for size, don't turn on -fomit-frame-pointer nor
+ -fasynchronous-unwind-tables by default. */
if (flag_omit_frame_pointer == 2)
- flag_omit_frame_pointer = 0;
+ flag_omit_frame_pointer
+ = (!optimize_size
+ && TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT
+ && (!TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT
+ || !(target_flags_explicit
+ & MASK_ACCUMULATE_OUTGOING_ARGS)));
if (flag_asynchronous_unwind_tables == 2)
- flag_asynchronous_unwind_tables = 0;
+ flag_asynchronous_unwind_tables
+ = (!optimize_size
+ && TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT
+ && (!TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT
+ || !(target_flags_explicit
+ & MASK_ACCUMULATE_OUTGOING_ARGS)));
if (flag_pcc_struct_return == 2)
flag_pcc_struct_return = DEFAULT_PCC_STRUCT_RETURN;
}
diff --git a/gcc/config/i386/i386.h b/gcc/config/i386/i386.h
index e153920..2bb6d3e 100644
--- a/gcc/config/i386/i386.h
+++ b/gcc/config/i386/i386.h
@@ -467,6 +467,8 @@ extern tree x86_mfence;
/* Extra bits to force on w/ 32-bit mode. */
#define TARGET_SUBTARGET32_DEFAULT 0
#define TARGET_SUBTARGET32_ISA_DEFAULT 0
+#define TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT 0
+#define TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT 0
/* Extra bits to force on w/ 64-bit mode. */
#define TARGET_SUBTARGET64_DEFAULT 0
diff --git a/gcc/config/i386/linux.h b/gcc/config/i386/linux.h
index 81dfd1e..61d53b5 100644
--- a/gcc/config/i386/linux.h
+++ b/gcc/config/i386/linux.h
@@ -219,3 +219,10 @@ along with GCC; see the file COPYING3. If not see
/* i386 glibc provides __stack_chk_guard in %gs:0x14. */
#define TARGET_THREAD_SSP_OFFSET 0x14
#endif
+
+/* Turn on -fomit-frame-pointer and -fasynchronous-unwind-tables by
+ default. */
+#undef TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT
+#define TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT 1
+#undef TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT
+#define TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT 1
diff --git a/gcc/config/i386/linux64.h b/gcc/config/i386/linux64.h
index 33b4dc9..5a02205 100644
--- a/gcc/config/i386/linux64.h
+++ b/gcc/config/i386/linux64.h
@@ -123,3 +123,10 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
x86_64 glibc provides it in %fs:0x28. */
#define TARGET_THREAD_SSP_OFFSET (TARGET_64BIT ? 0x28 : 0x14)
#endif
+
+/* Turn on -fomit-frame-pointer and -fasynchronous-unwind-tables by
+ default. */
+#undef TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT
+#define TARGET_SUBTARGET32_OMIT_FRAME_POINTER_DEFAULT 1
+#undef TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT
+#define TARGET_SUBTARGET32_ASYNCHRONOUS_UNWIND_TABLES_DEFAULT 1
diff --git a/gcc/testsuite/gcc.target/i386/frame-pointer-1.c b/gcc/testsuite/gcc.target/i386/frame-pointer-1.c
new file mode 100644
index 0000000..ed4bff6
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/frame-pointer-1.c
@@ -0,0 +1,13 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -mtune=i686" } */
+/* { dg-require-effective-target ilp32 } */
+
+void bar (int);
+
+void
+foo (void)
+{
+ bar (1);
+}
+
+/* { dg-final { scan-assembler-not "pushl\[\\t \]*%ebp" } } */
diff --git a/gcc/testsuite/gcc.target/i386/frame-pointer-2.c b/gcc/testsuite/gcc.target/i386/frame-pointer-2.c
new file mode 100644
index 0000000..b951ff4
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/frame-pointer-2.c
@@ -0,0 +1,13 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -mtune=i686 -mno-accumulate-outgoing-args" } */
+/* { dg-require-effective-target ilp32 } */
+
+void bar (int);
+
+void
+foo (void)
+{
+ bar (1);
+}
+
+/* { dg-final { scan-assembler "pushl\[\\t \]*%ebp" } } */
diff --git a/gcc/testsuite/gcc.target/i386/frame-pointer-3.c b/gcc/testsuite/gcc.target/i386/frame-pointer-3.c
new file mode 100644
index 0000000..7a1d4d1
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/frame-pointer-3.c
@@ -0,0 +1,13 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -mtune=i686 -mpush-args" } */
+/* { dg-require-effective-target ilp32 } */
+
+void bar (int);
+
+void
+foo (void)
+{
+ bar (1);
+}
+
+/* { dg-final { scan-assembler-not "pushl\[\\t \]*%ebp" } } */
diff --git a/gcc/testsuite/gcc.target/i386/frame-pointer-4.c b/gcc/testsuite/gcc.target/i386/frame-pointer-4.c
new file mode 100644
index 0000000..330a9ce
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/frame-pointer-4.c
@@ -0,0 +1,13 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -mtune=i686 -mpush-args -mno-accumulate-outgoing-args" } */
+/* { dg-require-effective-target ilp32 } */
+
+void bar (int);
+
+void
+foo (void)
+{
+ bar (1);
+}
+
+/* { dg-final { scan-assembler "pushl\[\\t \]*%ebp" } } */
diff --git a/gcc/testsuite/gcc.target/i386/frame-pointer-5.c b/gcc/testsuite/gcc.target/i386/frame-pointer-5.c
new file mode 100644
index 0000000..11240a2
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/frame-pointer-5.c
@@ -0,0 +1,13 @@
+/* { dg-do compile } */
+/* { dg-options "-Os -mtune=i686" } */
+/* { dg-require-effective-target ilp32 } */
+
+void bar (int);
+
+void
+foo (void)
+{
+ bar (1);
+}
+
+/* { dg-final { scan-assembler "pushl\[\\t \]*%ebp" } } */
[-- Attachment #3: gcc frame pointer.xlsx --]
[-- Type: application/vnd.openxmlformats-officedocument.spreadsheetml.sheet, Size: 53995 bytes --]
next reply other threads:[~2010-07-26 16:33 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 16:41 H.J. Lu [this message]
2010-08-02 17:55 ` H.J. Lu
2010-08-03 9:18 ` Uros Bizjak
2010-08-03 9:38 ` Andrew Haley
2010-08-03 14:03 ` H.J. Lu
2010-08-03 14:18 ` Daniel Jacobowitz
2010-08-03 14:28 ` H.J. Lu
2010-08-03 15:13 ` Daniel Jacobowitz
2010-08-03 15:35 ` H.J. Lu
2010-08-03 14:05 ` H.J. Lu
2010-08-03 14:11 ` Mark Mitchell
2010-08-03 17:12 ` Mark Mitchell
2010-08-03 17:24 ` Andrew Haley
2010-08-03 17:29 ` H.J. Lu
2010-08-03 17:57 ` Mark Mitchell
2010-08-04 13:21 ` Andrew Haley
2010-08-04 14:29 ` Mark Mitchell
2010-08-04 14:44 ` Andrew Haley
2010-08-04 14:48 ` Bernd Schmidt
2010-08-04 15:00 ` Jan Hubicka
2010-08-04 15:54 ` Andrew Haley
2010-08-04 16:08 ` H.J. Lu
2010-08-04 16:23 ` Andrew Haley
2010-08-04 17:05 ` Andrew Haley
2010-08-04 17:06 ` Andrew Haley
2010-08-04 17:08 ` H.J. Lu
2010-08-09 12:07 ` Mark Wielaard
2010-08-04 17:07 ` H.J. Lu
2010-08-04 17:09 ` Andrew Haley
2010-08-04 17:12 ` H.J. Lu
2010-08-04 17:15 ` Andrew Haley
2010-08-04 17:20 ` H.J. Lu
2010-08-04 17:08 ` Chris Lattner
2010-08-04 17:36 ` Andi Kleen
2010-08-04 17:41 ` H.J. Lu
2010-08-04 17:47 ` Andrew Haley
2010-08-04 17:53 ` H.J. Lu
2010-08-04 18:05 ` Andi Kleen
2010-08-04 18:12 ` Mark Mitchell
2010-08-04 18:18 ` H.J. Lu
2010-08-17 1:47 ` Maciej W. Rozycki
2010-08-03 17:58 ` David Daney
2010-08-03 17:25 ` H.J. Lu
2010-08-03 17:48 ` Mark Mitchell
2010-08-03 18:18 ` Richard Henderson
2010-08-04 18:52 Paul Pluzhnikov
2010-08-04 19:13 ` H.J. Lu
2010-08-04 19:24 ` Paul Pluzhnikov
2010-08-04 19:25 ` Xinliang David Li
2010-08-04 20:39 ` Andi Kleen
2010-08-04 20:57 ` David Daney
2010-08-04 21:09 ` Paul Pluzhnikov
2010-08-04 21:16 ` Andi Kleen
2010-08-04 22:07 ` Paul Pluzhnikov
2010-08-04 22:16 ` Andi Kleen
2010-08-04 22:45 ` David Daney
2010-08-05 7:00 ` Andi Kleen
2010-08-04 23:11 ` Richard Henderson
2010-08-05 7:23 ` Andi Kleen
2010-08-04 21:13 ` Andi Kleen
2010-08-12 16:22 H.J. Lu
2010-08-12 16:28 ` Richard Henderson
2010-08-12 16:35 ` Uros Bizjak
2010-08-12 16:52 ` H.J. Lu
2010-08-12 17:03 ` Uros Bizjak
2010-08-12 17:07 ` H.J. Lu
2010-08-12 17:12 ` H.J. Lu
2010-08-12 17:13 ` Uros Bizjak
2010-08-12 17:20 ` H.J. Lu
2010-08-12 17:26 ` Jack Howarth
2010-08-12 17:39 ` Uros Bizjak
2010-08-12 17:39 ` Jack Howarth
2010-08-12 17:46 ` Richard Henderson
2010-08-12 17:58 ` IainS
2010-08-12 18:22 ` Richard Henderson
2010-08-12 17:50 ` Uros Bizjak
2010-08-12 23:02 ` Mike Stump
2013-01-30 22:24 ` Ryan Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinR6uC2_Vqd+_R17KO+_zL0+FwJFPYPLxu0Jkdc@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gmail.com \
--cc=richard.guenther@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).