From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12287 invoked by alias); 17 Nov 2010 10:36:58 -0000 Received: (qmail 12234 invoked by uid 22791); 17 Nov 2010 10:36:57 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-iw0-f175.google.com (HELO mail-iw0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Nov 2010 10:36:52 +0000 Received: by iwn38 with SMTP id 38so682633iwn.20 for ; Wed, 17 Nov 2010 02:36:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.231.16.195 with SMTP id p3mr6936272iba.62.1289990210337; Wed, 17 Nov 2010 02:36:50 -0800 (PST) Received: by 10.231.10.66 with HTTP; Wed, 17 Nov 2010 02:36:50 -0800 (PST) In-Reply-To: <4CE2DC0B.8090206@gmail.com> References: <4CE2B477.4040209@gmail.com> <4CE2DC0B.8090206@gmail.com> Date: Wed, 17 Nov 2010 11:03:00 -0000 Message-ID: Subject: Re: [PATCH,lto] Fix PR42690 and related LTO-vs-static-linking issues. From: Richard Guenther To: Dave Korn Cc: "Joseph S. Myers" , GCC Patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-11/txt/msg01792.txt.bz2 On Tue, Nov 16, 2010 at 8:31 PM, Dave Korn wro= te: > On 16/11/2010 16:33, Joseph S. Myers wrote: >> On Tue, 16 Nov 2010, Richard Guenther wrote: >> >>> Are we sure that all -l options are joined ones? =A0The driver accepts >>> -l =A0m just fine. >> >> The driver converts -l options to joined form when passing them to >> add_infile. =A0I don't know about the -l options contained directly in >> specs; that's what would need checking. =A0(Specs other than those in >> driver_self_specs do not go through the option processing machinery; they >> are generating command lines for programs other than the driver.) >> >>> I'm ok with the patch if Joseph thinks it is ok. >> >> I have no comments on this patch. > > > =A0Right you are. =A0I'll test the patch with separated -l options and se= e if it > works; if not, I'll submit a respin, but if it does work, can I take this > discussion as approval? Yes. >=A0(Also, bear in mind that the spec function only gets > applied to link_gcc_c_sequence: it doesn't need to be fully generic, exce= pt of > course that we haven't ever explicitly banned separated -l options in spe= cs; > that said, there probably aren't any.) > > =A0BTW, the lto-bootstrap completed even on Cygwin (I don't know however = if > this implies that PR45325 is resolved, or was just lucky not to trip it on > this occasion). =A0Test results will take a day or two to arrive, as ever. Thanks, Richard. > =A0 =A0cheers, > =A0 =A0 =A0DaveK >