From: Janne Blomqvist <blomqvist.janne@gmail.com>
To: Tobias Burnus <burnus@net-b.de>
Cc: gcc patches <gcc-patches@gcc.gnu.org>, gfortran <fortran@gcc.gnu.org>
Subject: Re: [Patch, libgFortran] Fix MinGW64 compile warning
Date: Sat, 26 Mar 2011 09:27:00 -0000 [thread overview]
Message-ID: <AANLkTinbBBNhChTjGDb+7S40Od7hdaKfUBtTv+dktHOM@mail.gmail.com> (raw)
In-Reply-To: <4D8CCC8D.5060206@net-b.de>
On Fri, Mar 25, 2011 at 19:10, Tobias Burnus <burnus@net-b.de> wrote:
> The attached patch fixes a compiler warning on MinGW64
>
> ../../../../../build/gcc/src/libgfortran/io/unix.c:51:0: warning: "lseek"
> redefined [enabled by default]
>
> which is due to MinGW64 now supporting LFS. (Seemingly, using a similar
> define as libgfortran.) The following patch should fix the issue.
>
> Thanks for Kai for suggestions and testing the patch on MinGW64. The goal is
> that it also works with older MinGW64 and with 32bit MinGW, but that has not
> been tested ...
>
> OK for the trunk?
Since the reason for adding the gfstat_t typedef was that on mingw we
needed to use struct _stati64 instead of struct stat, and that
justification now seems to be gone with this patch, please also remove
gfstat_t and just use struct stat everywhere.
Otherwise Ok.
--
Janne Blomqvist
next prev parent reply other threads:[~2011-03-26 7:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 17:14 Tobias Burnus
2011-03-26 9:27 ` Janne Blomqvist [this message]
2011-04-03 15:11 ` Tobias Burnus
2011-04-03 15:26 ` Janne Blomqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinbBBNhChTjGDb+7S40Od7hdaKfUBtTv+dktHOM@mail.gmail.com \
--to=blomqvist.janne@gmail.com \
--cc=burnus@net-b.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).