* [PATCH] Fix -fwhopr again
@ 2010-09-01 21:52 Andi Kleen
2010-09-01 22:40 ` Diego Novillo
0 siblings, 1 reply; 2+ messages in thread
From: Andi Kleen @ 2010-09-01 21:52 UTC (permalink / raw)
To: gcc-patches
Hi,
My earlier -fwhopr=jobserver patch unfortunately broke the
"-fwhopr" without anything case, resulting in no LTO
sections being generated in this case. This resulted
in no visible failures because the backup code
in the object files saved the day, but resulted in no
real link time optimization.
Following patch passed non LTO bootstrap C only on x86-64,
currently running a full LTO bootstrap and a full test.
Ok to commit if it passes?
-Andi
2010-09-01 Andi Kleen <ak@linux.intel.com>
* opts.c (common_handle_option): Fix OPT_fwhopr/fwhopr_ handling.
diff --git a/gcc/opts.c b/gcc/opts.c
index fbee8f6..7425fa4 100644
--- a/gcc/opts.c
+++ b/gcc/opts.c
@@ -2088,10 +2088,14 @@ common_handle_option (const struct cl_decoded_option *decoded,
global_dc->pedantic_errors = 1;
break;
- case OPT_fwhopr:
+ case OPT_fwhopr_:
flag_whopr = arg;
break;
+ case OPT_fwhopr:
+ flag_whopr = "";
+ break;
+
case OPT_w:
global_dc->inhibit_warnings = true;
break;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix -fwhopr again
2010-09-01 21:52 [PATCH] Fix -fwhopr again Andi Kleen
@ 2010-09-01 22:40 ` Diego Novillo
0 siblings, 0 replies; 2+ messages in thread
From: Diego Novillo @ 2010-09-01 22:40 UTC (permalink / raw)
To: Andi Kleen; +Cc: gcc-patches
On Wed, Sep 1, 2010 at 17:32, Andi Kleen <andi@firstfloor.org> wrote:
> Ok to commit if it passes?
Yes.
Diego.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-01 21:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-01 21:52 [PATCH] Fix -fwhopr again Andi Kleen
2010-09-01 22:40 ` Diego Novillo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).