From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-264960-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 6546 invoked by alias); 11 Jun 2010 09:12:16 -0000
Received: (qmail 6536 invoked by uid 22791); 11 Jun 2010 09:12:16 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM
X-Spam-Check-By: sourceware.org
Received: from mail-wy0-f175.google.com (HELO mail-wy0-f175.google.com) (74.125.82.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Jun 2010 09:12:10 +0000
Received: by wyi11 with SMTP id 11so639814wyi.20        for <gcc-patches@gcc.gnu.org>; Fri, 11 Jun 2010 02:12:07 -0700 (PDT)
Received: by 10.216.85.74 with SMTP id t52mr705669wee.99.1276247527308; Fri, 	11 Jun 2010 02:12:07 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.216.21.6 with HTTP; Fri, 11 Jun 2010 02:11:47 -0700 (PDT)
In-Reply-To: <4C11B4BB.5060102@oracle.com>
References: <4C0DC2B4.3080200@oracle.com> <4C0E94C8.4070807@redhat.com> 	<4C0F4D3A.6010207@oracle.com> <4C0F8F5B.9000208@redhat.com> 	<4C10874E.9030400@oracle.com> <4C10DED2.7060600@redhat.com> 	<4C11B4BB.5060102@oracle.com>
From: =?ISO-8859-1?Q?Manuel_L=F3pez=2DIb=E1=F1ez?= <lopezibanez@gmail.com>
Date: Fri, 11 Jun 2010 09:33:00 -0000
Message-ID: <AANLkTinmo0-q9tbvTlG-QXGcsBAQcRMUgNIQQMZCxYqm@mail.gmail.com>
Subject: Re: [PATCH C/C++] Fix some diagnostics problems
To: Shujing Zhao <pearly.zhao@oracle.com>
Cc: Jason Merrill <jason@redhat.com>, Joseph <joseph@codesourcery.com>, 	Gcc-Patches <gcc-patches@gcc.gnu.org>, Paolo Carlini <paolo.carlini@oracle.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2010-06/txt/msg01183.txt.bz2

On 11 June 2010 05:59, Shujing Zhao <pearly.zhao@oracle.com> wrote:
>
> + =A0 =A0 =A0 =A0 =A0 case ICR_ARGPASS:
> + =A0 =A0 =A0 =A0 =A0 case ICR_DEFAULT_ARGUMENT:
> + =A0 =A0 =A0 =A0 =A0 =A0 if (fndecl)
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 warning (OPT_Wmissing_format_attribute,
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"parameter %d of %qD mig=
ht be a candidate "
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"for a format attribute"=
, parmnum, fndecl);
> + =A0 =A0 =A0 =A0 =A0 =A0 else

You have to use %qP for parmnum, otherwise the offsets would be
inconsistent with other diagnostics. See a previous error in the same
function.

Manuel.