From: David Edelsohn <dje.gcc@gmail.com>
To: Pat Haugen <pthaugen@linux.vnet.ibm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Bump alignment for small loops on PowerPC
Date: Tue, 02 Nov 2010 19:20:00 -0000 [thread overview]
Message-ID: <AANLkTinq+26avBR7ux8iko=+4h73J--U++9nPJHjfa8x@mail.gmail.com> (raw)
In-Reply-To: <4CC1F004.2000505@linux.vnet.ibm.com>
On Fri, Oct 22, 2010 at 4:11 PM, Pat Haugen <pthaugen@linux.vnet.ibm.com> wrote:
> The following patch increases the alignment for certain small loops (5-8
> insns) on PowerPC for improved performance. Small loops can benefit by being
> contained within a single 32-byte icache sector. Spec testing was neutral,
> but it should eliminate variations in performance I have seen in the past
> due to whether one of these loops crossed a 32-byte boundary.
>
> Bootstrap/regtested on powerpc64-linux with no new regressions. OK for
> trunk?
>
>
> 2010-10-22 Pat Haugen <pthaugen@us.ibm.com>
>
> * final.c (compute_alignments): Compute/free loop info all the time.
> * config/rs6000/rs6000.h (LOOP_ALIGN): Define.
> * config/rs6000/rs6000-protos.h (rs6000_loop_align): Declare.
> * config/rs6000/t-rs6000 (rs6000.o): Add cfgloop.h.
> * config/rs6000/rs6000.c (cfgloop.h): Include.
> (can_override_loop_align): New.
> (rs6000_option_override_internal): Set it.
> (TARGET_ASM_LOOP_ALIGN_MAX_SKIP): Define target hook.
> (rs6000_loop_align): New function.
> (rs6000_loop_align_max_skip): Likewise.
> * testsuite/gcc.target/powerpc/loop_align.c: New.
The rs6000 parts are okay; I do not have the authority to approve the
final.c change.
As Eric mentioned, please note the separate file for testsuite ChangeLog.
Thanks, David
next prev parent reply other threads:[~2010-11-02 19:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 21:12 Pat Haugen
2010-10-23 6:58 ` Eric Botcazou
2010-11-02 19:20 ` David Edelsohn [this message]
[not found] ` <4CD2FFF7.9080301@linux.vnet.ibm.com>
2010-11-04 19:53 ` [PING] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinq+26avBR7ux8iko=+4h73J--U++9nPJHjfa8x@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pthaugen@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).