public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Guenther <richard.guenther@gmail.com>
To: "Fang, Changpeng" <Changpeng.Fang@amd.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	"rguenther@suse.de" <rguenther@suse.de>,
		"pinskia@gcc.gnu.org" <pinskia@gcc.gnu.org>,
	Zdenek Dvorak <rakdver@kam.mff.cuni.cz>,
		"sebpop@gmail.com" <sebpop@gmail.com>
Subject: Re: [Patch PR 45260]: [4.5/4.6 Regression] g++4.5: -prefetch-loop-arrays internal compiler error: in verify_expr, at tree-cfg.c:2541
Date: Mon, 23 Aug 2010 16:39:00 -0000	[thread overview]
Message-ID: <AANLkTinr-w7QERO7uDMFossAOwJHxCg7A_8+3no=oA7Y@mail.gmail.com> (raw)
In-Reply-To: <D4C76825A6780047854A11E93CDE84D05B04FB49@SAUSEXMBP01.amd.com>

On Sat, Aug 21, 2010 at 12:44 AM, Fang, Changpeng
<Changpeng.Fang@amd.com> wrote:
> Hi,
>
> The attached patch fixes PR 45260:  [4.5/4.6 Regression] g++4.5: -prefetch-loop-arrays internal compiler error: in verify_expr, at tree-cfg.c:2541
>
> Problem: The prefetch pass generates an ADDR_EXPR for COMPONENT_REF(VIEW_CONVERT_EXPR(SSA_NAME)) whose
> address could not be taken, and thus invokes an assertion failure in verify_expr.
>
> Solution: Don't generate prefetch for references whose base address could not be taken.
>
> In this patch, we make may_be_nonaddressable_p (tree expr) global and use it in the prefetch pass.
>
> This patch passed bootstrapping and gcc regression tests on x86_64-unknown-linux-gnu systems ib both
> trunk and 4.5 branch.
>
> Is it OK to commit to trunk and 4.5 branch?

Ok.

Thanks,
Richard.

> Thanks and have a wonderful weekend!
>
> Changpeng

      reply	other threads:[~2010-08-23 16:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-20 23:18 Fang, Changpeng
2010-08-23 16:39 ` Richard Guenther [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTinr-w7QERO7uDMFossAOwJHxCg7A_8+3no=oA7Y@mail.gmail.com' \
    --to=richard.guenther@gmail.com \
    --cc=Changpeng.Fang@amd.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=pinskia@gcc.gnu.org \
    --cc=rakdver@kam.mff.cuni.cz \
    --cc=rguenther@suse.de \
    --cc=sebpop@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).