From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29477 invoked by alias); 30 Aug 2010 15:54:39 -0000 Received: (qmail 29453 invoked by uid 22791); 30 Aug 2010 15:54:35 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-ew0-f47.google.com (HELO mail-ew0-f47.google.com) (209.85.215.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Aug 2010 15:54:01 +0000 Received: by ewy7 with SMTP id 7so3569076ewy.20 for ; Mon, 30 Aug 2010 08:53:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.181.15 with SMTP id i15mr380884mup.122.1283183638646; Mon, 30 Aug 2010 08:53:58 -0700 (PDT) Received: by 10.220.78.193 with HTTP; Mon, 30 Aug 2010 08:53:58 -0700 (PDT) In-Reply-To: References: <20100830144016.GA31228@intel.com> Date: Mon, 30 Aug 2010 16:17:00 -0000 Message-ID: Subject: Re: PATCH: Enable TARGET_HAS_SINCOS if x87 FPU fsincos is available From: "H.J. Lu" To: Richard Guenther Cc: gcc-patches@gcc.gnu.org, Uros Bizjak , Maxim Kuvyrkov Content-Type: multipart/mixed; boundary=001636417e1bf69143048f0c78dd X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-08/txt/msg02109.txt.bz2 --001636417e1bf69143048f0c78dd Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 949 On Mon, Aug 30, 2010 at 7:57 AM, Richard Guenther wrote: > On Mon, Aug 30, 2010 at 4:40 PM, H.J. Lu wrote: >> Hi, >> >> On x86, sincos is always available if x87 FPU fsincos is available. >> This patch enables TARGET_HAS_SINCOS for -ffast-math and x87 FPU. =A0Also >> x86 Bionic C library doesn't provide sincos and we shouldn't enable >> TARGET_HAS_SINCOS with OPTION_BIONIC on x86. =A0OK for trunk? > > Hm. =A0Shouldn't it be conditional on USE_FANCY_MATH_387 > && !NO_FANCY_MATH_387 as well? You are right. Here is the updated patch. > Also a flag dependency breaks with the target/option attributes, The current target/option attributes have many problems. It shouldn't prevent us from generating better codes. > so I'm not sure it is a good idea. =A0Does anyone care for FP > execution performance on 32bit anyway? > Intel cares FP execution performance on 32bit Thanks. --=20 H.J. --001636417e1bf69143048f0c78dd Content-Type: text/plain; charset=US-ASCII; name="gcc-sincos-3.patch" Content-Disposition: attachment; filename="gcc-sincos-3.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gdhi9si50 Content-length: 4360 MjAxMC0wOC0zMCAgSC5KLiBMdSAgPGhvbmdqaXUubHVAaW50ZWwuY29tPgoK CSogY29uZmlnL2xpbnV4LmggKFRBUkdFVF9IQVNfU0lOQ09TKTogRGVmaW5l IG9ubHkgaWYgbm90CglkZWZpbmVkLgoKCSogY29uZmlnL2kzODYvaTM4Ni5o IChUQVJHRVRfSEFTX1NJTkNPUyk6IE5ldy4gIEVuYWJsZWQgaWYgeDg3CglG UFUgZnNpbmNvcyBpcyBhdmFpbGFibGUuCgkqIGNvbmZpZy9pMzg2L3g4Ni02 NC5oIChUQVJHRVRfSEFTX1NJTkNPUyk6IExpa2V3aXNlLgoJKiBjb25maWcv aTM4Ni9saW51eC5oIChUQVJHRVRfSEFTX1NJTkNPUyk6IExpa2V3aXNlLgoJ KiBjb25maWcvaTM4Ni9saW51eDY0LmggKFRBUkdFVF9IQVNfU0lOQ09TKTog TGlrZXdpc2UuCgpkaWZmIC0tZ2l0IGEvZ2NjL2NvbmZpZy9pMzg2L2kzODYu aCBiL2djYy9jb25maWcvaTM4Ni9pMzg2LmgKaW5kZXggNWJhZTk5ZC4uMTZh MTdjNCAxMDA2NDQKLS0tIGEvZ2NjL2NvbmZpZy9pMzg2L2kzODYuaAorKysg Yi9nY2MvY29uZmlnL2kzODYvaTM4Ni5oCkBAIC0yNDkyLDYgKzI0OTIsMTMg QEAgc3RydWN0IEdUWSgoKSkgbWFjaGluZV9mdW5jdGlvbiB7CiAjdW5kZWYg VEFSR19DT05EX05PVF9UQUtFTl9CUkFOQ0hfQ09TVAogI2RlZmluZSBUQVJH X0NPTkRfTk9UX1RBS0VOX0JSQU5DSF9DT1NUIGl4ODZfY29zdC0+Y29uZF9u b3RfdGFrZW5fYnJhbmNoX2Nvc3QKIAorLyogVXNlIHg4NyBGUFUgZnNpbmNv cyBpZiBpdCBpcyBhdmFpbGFibGUuICAqLworI3VuZGVmIFRBUkdFVF9IQVNf U0lOQ09TCisjZGVmaW5lIFRBUkdFVF9IQVNfU0lOQ09TCQkJCVwKKyAgKFRB UkdFVF9VU0VfRkFOQ1lfTUFUSF8zODcJCQkJXAorICAgJiYgZmxhZ191bnNh ZmVfbWF0aF9vcHRpbWl6YXRpb25zCSAJCVwKKyAgICYmICghVEFSR0VUX1NT RV9NQVRIIHx8IFRBUkdFVF9NSVhfU1NFX0kzODcpKQorCiAvKgogTG9jYWwg dmFyaWFibGVzOgogdmVyc2lvbi1jb250cm9sOiB0CmRpZmYgLS1naXQgYS9n Y2MvY29uZmlnL2kzODYvbGludXguaCBiL2djYy9jb25maWcvaTM4Ni9saW51 eC5oCmluZGV4IDJhMzE4ODAuLjQyZGI0MTYgMTAwNjQ0Ci0tLSBhL2djYy9j b25maWcvaTM4Ni9saW51eC5oCisrKyBiL2djYy9jb25maWcvaTM4Ni9saW51 eC5oCkBAIC0zNSw2ICszNSwxNiBAQCBhbG9uZyB3aXRoIEdDQzsgc2VlIHRo ZSBmaWxlIENPUFlJTkczLiAgSWYgbm90IHNlZQogI3VuZGVmIFRBUkdFVF9U TFNfRElSRUNUX1NFR19SRUZTX0RFRkFVTFQKICNkZWZpbmUgVEFSR0VUX1RM U19ESVJFQ1RfU0VHX1JFRlNfREVGQVVMVCBNQVNLX1RMU19ESVJFQ1RfU0VH X1JFRlMKIAorLyogV2hldGhlciB3ZSBoYXZlIHNpbmNvcyB0aGF0IGZvbGxv d3MgdGhlIEdOVSBleHRlbnNpb24uICBUaGVyZSBpcyBubworICAgc2luY29z IGluIEJpb25pYyBDIGxpYnJhcnkuICBXZSBjYW4gb25seSB1c2UgeDg3IEZQ VSBmc2luY29zIGlmIGl0CisgICBpcyBhdmFpbGFibGUuICAqLworI3VuZGVm IFRBUkdFVF9IQVNfU0lOQ09TCisjZGVmaW5lIFRBUkdFVF9IQVNfU0lOQ09T CQkJCVwKKyAgKE9QVElPTl9HTElCQwkJCQkJCVwKKyAgIHx8IChUQVJHRVRf VVNFX0ZBTkNZX01BVEhfMzg3CQkJXAorICAgICAgICYmIGZsYWdfdW5zYWZl X21hdGhfb3B0aW1pemF0aW9ucwkJXAorICAgICAgICYmICghVEFSR0VUX1NT RV9NQVRIIHx8IFRBUkdFVF9NSVhfU1NFX0kzODcpKSkKKwogI3VuZGVmIEFT TV9DT01NRU5UX1NUQVJUCiAjZGVmaW5lIEFTTV9DT01NRU5UX1NUQVJUICIj IgogCmRpZmYgLS1naXQgYS9nY2MvY29uZmlnL2kzODYvbGludXg2NC5oIGIv Z2NjL2NvbmZpZy9pMzg2L2xpbnV4NjQuaAppbmRleCA4NjdkZTU5Li43YmMx MmI3IDEwMDY0NAotLS0gYS9nY2MvY29uZmlnL2kzODYvbGludXg2NC5oCisr KyBiL2djYy9jb25maWcvaTM4Ni9saW51eDY0LmgKQEAgLTUwLDYgKzUwLDE2 IEBAIHNlZSB0aGUgZmlsZXMgQ09QWUlORzMgYW5kIENPUFlJTkcuUlVOVElN RSByZXNwZWN0aXZlbHkuICBJZiBub3QsIHNlZQogI3VuZGVmIFRBUkdFVF9U TFNfRElSRUNUX1NFR19SRUZTX0RFRkFVTFQKICNkZWZpbmUgVEFSR0VUX1RM U19ESVJFQ1RfU0VHX1JFRlNfREVGQVVMVCBNQVNLX1RMU19ESVJFQ1RfU0VH X1JFRlMKIAorLyogV2hldGhlciB3ZSBoYXZlIHNpbmNvcyB0aGF0IGZvbGxv d3MgdGhlIEdOVSBleHRlbnNpb24uICBUaGVyZSBpcyBubworICAgc2luY29z IGluIEJpb25pYyBDIGxpYnJhcnkuICBXZSBjYW4gb25seSB1c2UgeDg3IEZQ VSBmc2luY29zIGlmIGl0CisgICBpcyBhdmFpbGFibGUuICAqLworI3VuZGVm IFRBUkdFVF9IQVNfU0lOQ09TCisjZGVmaW5lIFRBUkdFVF9IQVNfU0lOQ09T CQkJCVwKKyAgKE9QVElPTl9HTElCQwkJCQkJCVwKKyAgIHx8IChUQVJHRVRf VVNFX0ZBTkNZX01BVEhfMzg3CQkJXAorICAgICAgICYmIGZsYWdfdW5zYWZl X21hdGhfb3B0aW1pemF0aW9ucwkJXAorICAgICAgICYmICghVEFSR0VUX1NT RV9NQVRIIHx8IFRBUkdFVF9NSVhfU1NFX0kzODcpKSkKKwogLyogUHJvdmlk ZSBhIExJTktfU1BFQy4gIEhlcmUgd2UgcHJvdmlkZSBzdXBwb3J0IGZvciB0 aGUgc3BlY2lhbCBHQ0MKICAgIG9wdGlvbnMgLXN0YXRpYyBhbmQgLXNoYXJl ZCwgd2hpY2ggYWxsb3cgdXMgdG8gbGluayB0aGluZ3MgaW4gb25lCiAgICBv ZiB0aGVzZSB0aHJlZSBtb2RlcyBieSBhcHBseWluZyB0aGUgYXBwcm9wcmlh dGUgY29tYmluYXRpb25zIG9mCmRpZmYgLS1naXQgYS9nY2MvY29uZmlnL2xp bnV4LmggYi9nY2MvY29uZmlnL2xpbnV4LmgKaW5kZXggZTI4M2E5YS4uNTc2 YTJhYyAxMDA2NDQKLS0tIGEvZ2NjL2NvbmZpZy9saW51eC5oCisrKyBiL2dj Yy9jb25maWcvbGludXguaApAQCAtMTU5LDcgKzE1OSw5IEBAIHNlZSB0aGUg ZmlsZXMgQ09QWUlORzMgYW5kIENPUFlJTkcuUlVOVElNRSByZXNwZWN0aXZl bHkuICBJZiBub3QsIHNlZQogICAgaXMgcHJlc2VudCBpbiB0aGUgcnVudGlt ZSBsaWJyYXJ5LiAgKi8KICNkZWZpbmUgVEFSR0VUX0M5OV9GVU5DVElPTlMg KE9QVElPTl9HTElCQykKIAorI2lmbmRlZiBUQVJHRVRfSEFTX1NJTkNPUwog LyogV2hldGhlciB3ZSBoYXZlIHNpbmNvcyB0aGF0IGZvbGxvd3MgdGhlIEdO VSBleHRlbnNpb24uICAqLwogI2RlZmluZSBUQVJHRVRfSEFTX1NJTkNPUyAo T1BUSU9OX0dMSUJDIHx8IE9QVElPTl9CSU9OSUMpCisjZW5kaWYKIAogI2Rl ZmluZSBUQVJHRVRfUE9TSVhfSU8K --001636417e1bf69143048f0c78dd--