From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpbgsg1.qq.com (smtpbgsg1.qq.com [54.254.200.92]) by sourceware.org (Postfix) with ESMTPS id 7A2333858D20 for ; Tue, 14 Nov 2023 05:37:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A2333858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7A2333858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=54.254.200.92 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699940261; cv=none; b=CNhcB1x1jetOTpu2ij2i3H4s2rAOUMxw8x6v00k54dgbrjm6pTO8iTzGugS+R53bV/nxdxoBJ6vchcCLQBdJn6qpB0uvH3RTSebataW9HCh2kvxLcTvBbfOIJp45IieAWAPZpneWQPe7wVFMoSa8cHhjE9pjUfutSjkpW6W8+Sk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699940261; c=relaxed/simple; bh=eMTe4Sy1vOMupOGY0ZHoaL//q5Ze6MHT8w9XEyeRsYI=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=bz39shmI4Bn2GD1TyLqCva3wSrxchVz5m4XEaDSCLBRk6HDWedrQQIi4mgGCSmNiasbSR9Q/uoSZ678+HZr/UeKfW0rjaTLkmvf9HlvSwJiqMIiRLu70PNdm0swEA383jfxFBAfZHqWzWGcqbrAq2EkwCOI4OdnaUVumr1pycLE= ARC-Authentication-Results: i=1; server2.sourceware.org X-QQ-mid: bizesmtp90t1699940253tzl8zhu0 Received: from [10.101.11.9] ( [121.35.182.237]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 14 Nov 2023 13:37:32 +0800 (CST) X-QQ-SSF: 01400000000000C0F000000A0000000 X-QQ-FEAT: PS/N6jJLnDbea0vjV/xwuEeHawMRF4upRPRmgy9ivYVpvFN4suUoBv2/OYUKn vYBuEtHGQuMtdKgbd4pL2Tdqrz0mmpnw/tB75kxnS4Kt691dPTzwOvolwSveyL72+t5LrB3 6Hizz5jrLmT5SYGjdt53JzFGQWdyv8s9lafZNxqDU/3LgO0wXElpLA5CL018QhSRKniaOld CXTY7XGF5849wIvqv4o3ZCO4UZb1sfORvHS8fglkn29QMzOoyISU/Y5xRkzl+hoXivxEkaE tI+QIIYAZCX/twaNXQez0I8qTf/V+qC6QDVZPQEgErleroIoX6GGDIMq8jFHDelC5Z6WndZ tmSzOJOqtG9XMozQc1HTu3PG6Cog9YX3bnTRl/iivVEaLihWtN4iU+LzmQ+1A== X-QQ-GoodBg: 2 X-BIZMAIL-ID: 5944358301102683794 Message-ID: Date: Tue, 14 Nov 2023 13:37:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 0/7] ira/lra: Support subreg coalesce Content-Language: en-US To: Vladimir Makarov , gcc-patches@gcc.gnu.org Cc: richard.sandiford@arm.com, juzhe.zhong@rivai.ai References: <20231112120817.2635864-1-lehua.ding@rivai.ai> <279a7599-7204-e8f7-3a1f-b8cf4ccffc0c@redhat.com> From: Lehua Ding In-Reply-To: <279a7599-7204-e8f7-3a1f-b8cf4ccffc0c@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz6a-0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,FORGED_MUA_MOZILLA,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Vladimir, On 2023/11/14 3:37, Vladimir Makarov wrote: > > On 11/12/23 07:08, Lehua Ding wrote: >> V3 Changes: >>    1. fix three ICE. >>    2. rebase >> >> Hi, >> >> These patchs try to support subreg coalesce feature in >> register allocation passes (ira and lra). >> > I've started review of v3 patches and here is my initial general > criticism of your patches: > >   * Absence of comments for some functions, e.g. for `HARD_REG_SET > operator>> (unsigned int shift_amount) const`. > >   * Adding significant functionality to existing functions is not > reflected in the function comment, e.g. in ira_set_allocno_class. > >   * A lot of typos, e.g. `pesudo` or `reprensent`.  I think you need to > check spelling of you comments (I myself do spell checking in emacs by > ispell-region command). > >   * Grammar mistakes, e.g `Flag means need track subreg live range for > the allocno`.  I understand English is not your native languages (as for > me).  In case of some doubts I'd recommend to check grammar in ChatGPT > (Proofread: text). > >   * Some local variables use upper case letters (e.g. `int A`) which > should be used for macros or enums according to GNU coding standard > (https://www.gnu.org/prep/standards/standards.html) . > >   * Sometimes you put one space at the end of sentence.  Please see GNU > coding standard and GCC coding conventions > (https://gcc.gnu.org/codingconventions.html) > >   * There is no uniformity in your code, e.g. sometimes you use 'i++', > sometimes `++i` or `i += 1`.  Although the uniformity is not necessary, > it makes a better impression about the patches. Sorry for these issue, I'll address all those comments. > I also did not find what targets did you use for testing.  I am asking > this because I see new testsuite failures (apx-spill_to_egprs-1.c) even > on x86-64.  It might be nothing as the test expects a specific code > generation. There was testing x86, aarch64, riscv not long ago, but it looks like I'm missing something, I just locally tested with the latest code and also reproduced this fail you mentioned, along with a c++ fail (pr106877.C). I'll have a look at the cause. > Also besides testing major targets I'd recommend testing at least one > big endian target (I'd recommend ppc64be. gcc110.fsfrance.org could be > used for this).  Plenty RA issues occur because BE targets are not tested. You said the address looks a bit wrong, it should be this gcc110.fsffrance.org right? I looked for it and it looks like you have to go to portal.cfarm.net first to apply for an account on this site, I'll try that, thanks a lot. -- Best, Lehua (RiVAI) lehua.ding@rivai.ai