* Turn on -pie on darwin11 and later
@ 2011-06-16 5:51 Mike Stump
2011-06-16 12:11 ` Pedro Alves
2011-06-19 18:39 ` Mike Stump
0 siblings, 2 replies; 5+ messages in thread
From: Mike Stump @ 2011-06-16 5:51 UTC (permalink / raw)
To: gcc-patches List; +Cc: Jack Howarth
[-- Attachment #1: Type: text/plain, Size: 53 bytes --]
* mh-darwin: Turn off -pie on darwin11 and later.
[-- Attachment #2: no-pie.patch.txt --]
[-- Type: text/plain, Size: 641 bytes --]
2011-06-15 Mike Stump <mikestump@comcast.net>
* mh-darwin: Turn off -pie on darwin11 and later.
Index: mh-darwin
===================================================================
--- mh-darwin (revision 174625)
+++ mh-darwin (working copy)
@@ -1,5 +1,7 @@
# The -mdynamic-no-pic ensures that the compiler executable is built without
# position-independent-code -- the usual default on Darwin. This fix speeds
# compiles by 3-5%.
-
BOOT_CFLAGS += -mdynamic-no-pic
+
+# Ensure we don't try and use -pie, as it is incompatible with pch.
+BOOT_LDFLAGS=`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Turn on -pie on darwin11 and later
2011-06-16 5:51 Turn on -pie on darwin11 and later Mike Stump
@ 2011-06-16 12:11 ` Pedro Alves
2011-06-16 19:40 ` Mike Stump
2011-06-19 18:39 ` Mike Stump
1 sibling, 1 reply; 5+ messages in thread
From: Pedro Alves @ 2011-06-16 12:11 UTC (permalink / raw)
To: gcc-patches; +Cc: Mike Stump, Jack Howarth
On Thursday 16 June 2011 02:33:50, Mike Stump wrote:
> BOOT_CFLAGS += -mdynamic-no-pic
> +
> +# Ensure we don't try and use -pie, as it is incompatible with pch.
> +BOOT_LDFLAGS=`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
Shouldn't this use += like BOOT_CFLAGS?
--
Pedro Alves
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Turn on -pie on darwin11 and later
2011-06-16 12:11 ` Pedro Alves
@ 2011-06-16 19:40 ` Mike Stump
2011-06-19 19:43 ` Mike Stump
0 siblings, 1 reply; 5+ messages in thread
From: Mike Stump @ 2011-06-16 19:40 UTC (permalink / raw)
To: Pedro Alves; +Cc: gcc-patches, Jack Howarth
On Jun 16, 2011, at 5:01 AM, Pedro Alves wrote:
> On Thursday 16 June 2011 02:33:50, Mike Stump wrote:
>> BOOT_CFLAGS += -mdynamic-no-pic
>> +
>> +# Ensure we don't try and use -pie, as it is incompatible with pch.
>> +BOOT_LDFLAGS=`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
>
> Shouldn't this use += like BOOT_CFLAGS?
Yes, fixed. Thanks for the review.
Index: config/mh-darwin
===================================================================
--- config/mh-darwin (revision 175089)
+++ config/mh-darwin (working copy)
@@ -4,4 +4,4 @@
BOOT_CFLAGS += -mdynamic-no-pic
# Ensure we don't try and use -pie, as it is incompatible with pch.
-BOOT_LDFLAGS=`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
+BOOT_LDFLAGS += `case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Turn on -pie on darwin11 and later
2011-06-16 19:40 ` Mike Stump
@ 2011-06-19 19:43 ` Mike Stump
0 siblings, 0 replies; 5+ messages in thread
From: Mike Stump @ 2011-06-19 19:43 UTC (permalink / raw)
To: gcc-patches List; +Cc: Jack Howarth
On Jun 16, 2011, at 12:22 PM, Mike Stump wrote:
> On Jun 16, 2011, at 5:01 AM, Pedro Alves wrote:
>> On Thursday 16 June 2011 02:33:50, Mike Stump wrote:
>>> BOOT_CFLAGS += -mdynamic-no-pic
>>> +
>>> +# Ensure we don't try and use -pie, as it is incompatible with pch.
>>> +BOOT_LDFLAGS=`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
>>
>> Shouldn't this use += like BOOT_CFLAGS?
>
> Yes, fixed. Thanks for the review.
Also backported for gcc 4.5.4 and 4.6.1.
> Index: config/mh-darwin
> ===================================================================
> --- config/mh-darwin (revision 175089)
> +++ config/mh-darwin (working copy)
> @@ -4,4 +4,4 @@
> BOOT_CFLAGS += -mdynamic-no-pic
>
> # Ensure we don't try and use -pie, as it is incompatible with pch.
> -BOOT_LDFLAGS=`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
> +BOOT_LDFLAGS += `case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Turn on -pie on darwin11 and later
2011-06-16 5:51 Turn on -pie on darwin11 and later Mike Stump
2011-06-16 12:11 ` Pedro Alves
@ 2011-06-19 18:39 ` Mike Stump
1 sibling, 0 replies; 5+ messages in thread
From: Mike Stump @ 2011-06-19 18:39 UTC (permalink / raw)
To: gcc-patches List; +Cc: Jack Howarth
On Jun 15, 2011, at 6:33 PM, Mike Stump wrote:
> * mh-darwin: Turn off -pie on darwin11 and later.
Also backported for gcc 4.5.4 and 4.6.1.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-06-19 18:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-16 5:51 Turn on -pie on darwin11 and later Mike Stump
2011-06-16 12:11 ` Pedro Alves
2011-06-16 19:40 ` Mike Stump
2011-06-19 19:43 ` Mike Stump
2011-06-19 18:39 ` Mike Stump
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).