From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id C91D23858C60 for ; Thu, 2 Sep 2021 11:30:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C91D23858C60 Received: by mail-wr1-x432.google.com with SMTP id t15so2359340wrg.7 for ; Thu, 02 Sep 2021 04:30:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=J3tHHurMNLrOvWOdhq4+tR/neLMkeVauHxOI/ngMICE=; b=bfEi+gz7WCqR/eBf45FPPNaVOdouJDGXWhZpbq6cyBBqbV0GgXvysl9xZg/oMexbjM Ua2uKaf0rx602Gqh/2/p9Q12Ah82ur50oft7rqp2d2yYqfcIe1f6B0ZceN7sWqsq+YLV nj4BUwvwkQ3QdiBjlN9euBYSYWjXQZCcWvU2hS6X90f3efhD5nf0NOx4JjwJuIllqcWB B1EGbOVGAcKABr3bezV14cZJTxbdBIJrYg4H9zY3JWrDDwkpqf4Xi0hIvVb8hRCiLcC/ 5TjBXwJTK2RuX9hG1TacqNvazUVGYRoGoyGyiYd8wz2sAHSj8uMsi1iCliSNSwnxXEgM tkRg== X-Gm-Message-State: AOAM530SDPy0G6A5U8Zdgqb3ibk05t4msL2q2oH6IeIzf+4TIDx5MO6Z zELNqE7UhJzKfJElq9iDgX4= X-Google-Smtp-Source: ABdhPJx5xwYPD16h6Wnv6R2NORF/JVZJR3iRIwoBJgGDyYM6MXvOajxpwJqd7SvRgIX7FWE0qslMhQ== X-Received: by 2002:adf:f3c4:: with SMTP id g4mr3238054wrp.409.1630582236657; Thu, 02 Sep 2021 04:30:36 -0700 (PDT) Received: from [192.168.1.214] (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.googlemail.com with ESMTPSA id i4sm1636214wmd.5.2021.09.02.04.30.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Sep 2021 04:30:35 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [PATCH V3 0/6] Initial support for AVX512FP16 From: Iain Sandoe In-Reply-To: Date: Thu, 2 Sep 2021 12:30:34 +0100 Cc: liuhongt , GCC Patches , Joseph Myers Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210802063116.999830-1-hongtao.liu@intel.com> To: Hongtao Liu X-Mailer: Apple Mail (2.3445.104.21) X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2021 11:30:48 -0000 Hi Hongtao. > On 2 Sep 2021, at 07:06, Hongtao Liu via Gcc-patches = wrote: >=20 > I'm going to check in the first 3 patches which are already approved. >=20 > Update hf soft-fp from glibc. > [i386] Enable _Float16 type for TARGET_SSE2 and above. > [i386] libgcc: Enable hfmode soft-sf/df/xf/tf extensions and > truncations. Bootstrap on Darwin x86_64 is broken on at least AVX512 and i5 cpus at = revision r12-3311-g1e6267b33526. "fp-machine.h:81:22: error: unknown type name 'TFtype'; did you mean = 'HFtype=E2=80=99?=E2=80=9D any immediate ideas on what might be the issue? thanks Iain >=20 > On Mon, Aug 2, 2021 at 2:31 PM liuhongt wrote: >>=20 >> Update from v2: >>=20 >> 1. Support -fexcess-precision=3D16 which will enable >> FLT_EVAL_METHOD_PROMOTE_TO_FLOAT16 when backend supports _Float16. >> 2. Update ix86_get_excess_precision, so -fexcess-precision=3Dstandard >> should not do anything different from -fexcess-precision=3Dfast >> regarding _Float16. >> 3. Avoiding macroization of HFmode patterns. >> 4. Allow (subreg:SI (reg:HF)). >> 5. Update documents corresponding exactly to the code changes in >> the same patch. >> 6. According to 32bit abi, pass vector _Float16 by sse registers >> for 32-bit mode, not stack. >>=20 >> Guo, Xuepeng (1): >> AVX512FP16: Initial support for AVX512FP16 feature and scalar = _Float16 >> instructions. >>=20 >> liuhongt (5): >> Update hf soft-fp from glibc. >> [i386] Enable _Float16 type for TARGET_SSE2 and above. >> [i386] libgcc: Enable hfmode soft-sf/df/xf/tf extensions and >> truncations. >> Support -fexcess-precision=3D16 which will enable >> FLT_EVAL_METHOD_PROMOTE_TO_FLOAT16 when backend supports _Float16. >> AVX512FP16: Support vector init/broadcast/set/extract for FP16. >>=20 >> gcc/ada/gcc-interface/misc.c | 3 + >> gcc/c-family/c-common.c | 6 +- >> gcc/c-family/c-cppbuiltin.c | 6 +- >> gcc/common.opt | 5 +- >> gcc/common/config/i386/cpuinfo.h | 2 + >> gcc/common/config/i386/i386-common.c | 26 +- >> gcc/common/config/i386/i386-cpuinfo.h | 1 + >> gcc/common/config/i386/i386-isas.h | 1 + >> gcc/config.gcc | 2 +- >> gcc/config/aarch64/aarch64.c | 1 + >> gcc/config/arm/arm.c | 1 + >> gcc/config/i386/avx512fp16intrin.h | 225 ++++++++++ >> gcc/config/i386/cpuid.h | 1 + >> gcc/config/i386/i386-builtin-types.def | 7 +- >> gcc/config/i386/i386-builtins.c | 23 + >> gcc/config/i386/i386-c.c | 2 + >> gcc/config/i386/i386-expand.c | 129 +++++- >> gcc/config/i386/i386-isa.def | 1 + >> gcc/config/i386/i386-modes.def | 13 +- >> gcc/config/i386/i386-options.c | 4 +- >> gcc/config/i386/i386.c | 243 +++++++++-- >> gcc/config/i386/i386.h | 29 +- >> gcc/config/i386/i386.md | 291 ++++++++++++- >> gcc/config/i386/i386.opt | 4 + >> gcc/config/i386/immintrin.h | 4 + >> gcc/config/i386/sse.md | 397 = +++++++++++++----- >> gcc/config/m68k/m68k.c | 2 + >> gcc/config/s390/s390.c | 2 + >> gcc/coretypes.h | 3 +- >> gcc/doc/extend.texi | 22 + >> gcc/doc/invoke.texi | 10 +- >> gcc/doc/tm.texi | 14 +- >> gcc/doc/tm.texi.in | 3 + >> gcc/emit-rtl.c | 5 + >> gcc/flag-types.h | 3 +- >> gcc/fortran/options.c | 3 + >> gcc/lto/lto-lang.c | 3 + >> gcc/target.def | 11 +- >> gcc/testsuite/g++.dg/other/i386-2.C | 2 +- >> gcc/testsuite/g++.dg/other/i386-3.C | 2 +- >> gcc/testsuite/g++.target/i386/float16-1.C | 8 + >> gcc/testsuite/g++.target/i386/float16-2.C | 14 + >> gcc/testsuite/g++.target/i386/float16-3.C | 10 + >> gcc/testsuite/gcc.target/i386/avx-1.c | 2 +- >> gcc/testsuite/gcc.target/i386/avx-2.c | 2 +- >> gcc/testsuite/gcc.target/i386/avx512-check.h | 3 + >> .../gcc.target/i386/avx512fp16-12a.c | 21 + >> .../gcc.target/i386/avx512fp16-12b.c | 27 ++ >> gcc/testsuite/gcc.target/i386/float16-3a.c | 10 + >> gcc/testsuite/gcc.target/i386/float16-3b.c | 10 + >> gcc/testsuite/gcc.target/i386/float16-4a.c | 10 + >> gcc/testsuite/gcc.target/i386/float16-4b.c | 10 + >> gcc/testsuite/gcc.target/i386/float16-5.c | 12 + >> gcc/testsuite/gcc.target/i386/float16-6.c | 8 + >> gcc/testsuite/gcc.target/i386/funcspec-56.inc | 2 + >> gcc/testsuite/gcc.target/i386/pr54855-12.c | 14 + >> gcc/testsuite/gcc.target/i386/sse-13.c | 2 +- >> gcc/testsuite/gcc.target/i386/sse-14.c | 2 +- >> gcc/testsuite/gcc.target/i386/sse-22.c | 4 +- >> gcc/testsuite/gcc.target/i386/sse-23.c | 2 +- >> .../gcc.target/i386/sse2-float16-1.c | 8 + >> .../gcc.target/i386/sse2-float16-2.c | 16 + >> .../gcc.target/i386/sse2-float16-3.c | 12 + >> gcc/testsuite/lib/target-supports.exp | 13 +- >> gcc/tree.c | 3 +- >> libgcc/config.host | 5 +- >> libgcc/config/i386/32/sfp-machine.h | 1 + >> libgcc/config/i386/32/t-softfp | 1 + >> libgcc/config/i386/64/sfp-machine.h | 1 + >> libgcc/config/i386/64/t-softfp | 1 + >> libgcc/config/i386/sfp-machine.h | 1 + >> libgcc/config/i386/t-softfp | 5 + >> libgcc/soft-fp/eqhf2.c | 49 +++ >> libgcc/soft-fp/extendhfdf2.c | 53 +++ >> libgcc/soft-fp/extendhfsf2.c | 49 +++ >> libgcc/soft-fp/half.h | 1 + >> libgcc/soft-fp/truncdfhf2.c | 52 +++ >> libgcc/soft-fp/truncsfhf2.c | 48 +++ >> 78 files changed, 1781 insertions(+), 223 deletions(-) >> create mode 100644 gcc/config/i386/avx512fp16intrin.h >> create mode 100644 gcc/testsuite/g++.target/i386/float16-1.C >> create mode 100644 gcc/testsuite/g++.target/i386/float16-2.C >> create mode 100644 gcc/testsuite/g++.target/i386/float16-3.C >> create mode 100644 gcc/testsuite/gcc.target/i386/avx512fp16-12a.c >> create mode 100644 gcc/testsuite/gcc.target/i386/avx512fp16-12b.c >> create mode 100644 gcc/testsuite/gcc.target/i386/float16-3a.c >> create mode 100644 gcc/testsuite/gcc.target/i386/float16-3b.c >> create mode 100644 gcc/testsuite/gcc.target/i386/float16-4a.c >> create mode 100644 gcc/testsuite/gcc.target/i386/float16-4b.c >> create mode 100644 gcc/testsuite/gcc.target/i386/float16-5.c >> create mode 100644 gcc/testsuite/gcc.target/i386/float16-6.c >> create mode 100644 gcc/testsuite/gcc.target/i386/pr54855-12.c >> create mode 100644 gcc/testsuite/gcc.target/i386/sse2-float16-1.c >> create mode 100644 gcc/testsuite/gcc.target/i386/sse2-float16-2.c >> create mode 100644 gcc/testsuite/gcc.target/i386/sse2-float16-3.c >> create mode 100644 libgcc/config/i386/64/t-softfp >> create mode 100644 libgcc/soft-fp/eqhf2.c >> create mode 100644 libgcc/soft-fp/extendhfdf2.c >> create mode 100644 libgcc/soft-fp/extendhfsf2.c >> create mode 100644 libgcc/soft-fp/truncdfhf2.c >> create mode 100644 libgcc/soft-fp/truncsfhf2.c >>=20 >> -- >> 2.27.0 >>=20 >=20 >=20 > --=20 > BR, > Hongtao