From: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
To: Fangrui Song <maskray@google.com>
Cc: Kito Cheng <kito.cheng@gmail.com>,
gcc-patches@gcc.gnu.org, Rui Ueyama <rui314@gmail.com>,
ruiu@bluewhale.systems, Jeff Law <jeffreyalaw@gmail.com>
Subject: Re: [PATCH v2] RISC-V: Implement TLS Descriptors.
Date: Thu, 16 Nov 2023 10:39:33 +0900 [thread overview]
Message-ID: <AFE9B889-1FA7-4B9B-8A21-13414F55EAE8@gmail.com> (raw)
In-Reply-To: <CAFP8O3K9dDjwmt3iHrFNoSmbbUKuEqOmGXVW4O-=0c_An7LXqA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 4116 bytes --]
> On Nov 16, 2023, at 10:17, Fangrui Song <maskray@google.com> wrote:
>
> On Mon, Oct 2, 2023 at 7:10 AM Kito Cheng <kito.cheng@gmail.com <mailto:kito.cheng@gmail.com>> wrote:
>>
>> Just one nit and one more comment for doc:
>>
>> Could you add some doc something like that? mostly I grab from other
>> target, so you can just included in the patch.
>>
>> diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
>> index 31f2234640f..39396668da2 100644
>> --- a/gcc/doc/install.texi
>> +++ b/gcc/doc/install.texi
>> @@ -1174,6 +1174,9 @@ Specify the default TLS dialect, for systems
>> were there is a choice.
>> For ARM targets, possible values for @var{dialect} are @code{gnu} or
>> @code{gnu2}, which select between the original GNU dialect and the GNU TLS
>> descriptor-based dialect.
>> +For RISC-V targets, possible values for @var{dialect} are @code{trad} or
>> +@code{desc}, which select between the traditional GNU dialect and the GNU TLS
>> +descriptor-based dialect.
>>
>> @item --enable-multiarch
>> Specify whether to enable or disable multiarch support. The default is
>> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
>> index 4085fc90907..459e266d426 100644
>> --- a/gcc/doc/invoke.texi
>> +++ b/gcc/doc/invoke.texi
>> @@ -1239,7 +1239,8 @@ See RS/6000 and PowerPC Options.
>> -minline-atomics -mno-inline-atomics
>> -minline-strlen -mno-inline-strlen
>> -minline-strcmp -mno-inline-strcmp
>> --minline-strncmp -mno-inline-strncmp}
>> +-minline-strncmp -mno-inline-strncmp
>> +-mtls-dialect=desc -mtls-dialect=trad}
>>
>> @emph{RL78 Options}
>> @gccoptlist{-msim -mmul=none -mmul=g13 -mmul=g14 -mallregs
>> @@ -29538,6 +29539,17 @@ which register to use as base register for
>> reading the canary,
>> and from what offset from that base register. There is no default
>> register or offset as this is entirely for use within the Linux
>> kernel.
>> +
>> +@opindex mtls-dialect=desc
>> +@item -mtls-dialect=desc
>> +Use TLS descriptors as the thread-local storage mechanism for dynamic accesses
>> +of TLS variables. This is the default.
>> +
>> +@opindex mtls-dialect=trad
>> +@item -mtls-dialect=traditional
>
> -mtls-dialect=trad.
> aarch64-linux-gnu-gcc doesn't support -mtls-dialect=traditional
>
>> +Use traditional TLS as the thread-local storage mechanism for dynamic accesses
>> +of TLS variables.
>> +
>> @end table
>
> This is the default :)
>
> I am happy that we change the default like AArch64, but probably not
> now when linker support is not widely available yet.
>
> I cannot comment on the code side as I am not familiar with GCC internals.
>
>> @node RL78 Options
>>
>>
>>
>>
>>> +(define_insn "@tlsdesc<mode>"
>>> + [(set (reg:P A0_REGNUM)
>>> + (unspec:P
>>> + [(match_operand:P 0 "symbolic_operand" "")
>>> + (match_operand:P 1 "const_int_operand")]
>>> + UNSPEC_TLSDESC))
>>> + (clobber (reg:SI T0_REGNUM))]
>>
>> P rather than SI here.
>>
>>> + "TARGET_TLSDESC"
>>> + {
>>> + return ".LT%1: auipc\ta0, %%tlsdesc_hi(%0)\;"
>>> + "<load>\tt0,%%tlsdesc_load_lo(.LT%1)(a0)\;"
>>> + "addi\ta0,a0,%%tlsdesc_add_lo(.LT%1)\;"
>>> + "jalr\tt0,t0,%%tlsdesc_call(.LT%1)";
>>> + }
>>> + [(set_attr "type" "multi")
>>> + (set_attr "length" "16")
>>> + (set_attr "mode" "<MODE>")])
>>> +
>>> (define_insn "auipc<mode>"
>>> [(set (match_operand:P 0 "register_operand" "=r")
>>> (unspec:P
>
> It seems that x86-64 supports non-adjacent code sequence. Writing the
> pattern this way does not allow interleaving, but I assume
> interleaving doesn't enable much.
> https://reviews.llvm.org/D114416
As mentioned in the commit message, the use of relaxation-only labels does not seem well supported in current GCC. Creating a label seems to force a basic block and I’m not sure how we can avoid it.
If there’s a better way to implement this I’m happy to adopt.
Tatsuyuki.
>
> --
> 宋方睿
next prev parent reply other threads:[~2023-11-16 1:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 18:12 [PATCH] " Tatsuyuki Ishi
2023-08-29 13:40 ` Kito Cheng
2023-09-08 10:49 ` [PATCH v2] " Tatsuyuki Ishi
2023-10-02 14:10 ` Kito Cheng
2023-11-16 1:17 ` Fangrui Song
2023-11-16 1:39 ` Tatsuyuki Ishi [this message]
2023-11-16 5:21 ` Jeff Law
2023-11-16 5:18 ` Jeff Law
2023-11-16 1:07 ` Jeff Law
2023-11-16 1:51 ` Tatsuyuki Ishi
2023-11-16 5:23 ` Jeff Law
2023-11-16 5:33 ` Fangrui Song
2023-11-16 5:36 ` Jeff Law
2023-11-16 5:37 ` Tatsuyuki Ishi
2023-11-20 13:17 ` [PATCH v3] " Tatsuyuki Ishi
2023-11-21 6:59 ` Fangrui Song
2023-11-21 7:07 ` Tatsuyuki Ishi
2023-12-05 16:49 ` Tatsuyuki Ishi
2023-11-23 10:57 ` Florian Weimer
2023-11-23 11:34 ` Tatsuyuki Ishi
2023-11-23 11:40 ` Florian Weimer
2023-12-05 7:01 ` [PATCH v4] " Tatsuyuki Ishi
2024-01-27 3:24 ` Fangrui Song
2024-03-29 5:52 ` [PATCH v5] " Tatsuyuki Ishi
2024-03-29 6:32 ` Kito Cheng
2024-04-08 14:31 ` Kito Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AFE9B889-1FA7-4B9B-8A21-13414F55EAE8@gmail.com \
--to=ishitatsuyuki@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=kito.cheng@gmail.com \
--cc=maskray@google.com \
--cc=rui314@gmail.com \
--cc=ruiu@bluewhale.systems \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).