From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2100.outbound.protection.outlook.com [40.107.247.100]) by sourceware.org (Postfix) with ESMTPS id E73C33858C55 for ; Wed, 2 Nov 2022 08:40:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E73C33858C55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=Syrmia.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Syrmia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hsmdzrDe9y2lpxm/SBbe3SoUBka0/JSnOaEHZB6d7fhrwLoR1yPeJMfeJGqygjCQ+tLtsO2fMqSQK4Xj0jnF0lIxP7zWJyDIHCM8O1dzbghK8aPNVZEF40eYFDbyhNvkQF+h0Sht5ROZP3WW0eEwZHlDfPGirSWQt1wpE2uZWwNJxSb/ORgxSsKTCo0E+e0iE46r76NAlxwhCXnne3dQ/Yz1gv4NUD9dtQ6PYODoVBldNg3z4h8VKLlkv9FZ+GEG5w6gcz7jns/BAn/OheaqVtheQNzGiyYe2jkrJdGkHNE8Pkr3sMEzgGi+ePh/RZZArcbAKLwgvjcxkO01+2SDVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nLHYIdSs+c4rcZtVptCK5+9WN0isrZBxzN3R4BuhImI=; b=R/XdgUspMTrM/J+GAVM9DdmqSnDG+1lT4AUa69j+6jKxStwaJb2jwjmtDLRP+O4q4xHXkcxqpYlYXxMLiHJWC6zOZfnia2J2m5gPW1hXg2eoNzkJvgL/uTgmJU57X6Ly4EGFUqOkwxR3qhOYFFZXcMbIJh2A+Eu6xFZVTe5WNENyinvpyU5FoZrXIUdE+KMWNFy1t6aC7XknZiCWa6lpCwdlMBh3pQDqe1T1sjZLZd+YG7DUGh6IArrF7CKr0urPFVSEg/Ul9xamDHstYm25AzrRuQ6mdrHRaCtdGFkO9NMtHPJPWvaA77gzCtjfOmDT4rSLIm0eZj9H4eBwjaeIlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nLHYIdSs+c4rcZtVptCK5+9WN0isrZBxzN3R4BuhImI=; b=w9p/4C1nV5+vH/QEwue8VWr0CAjfD16KNOOU/ee4N51VWTwC0JSBx8BfM7Rf+O9VJbHgzqhOo1Ehj2PtqVElpEhhDPUzxdzV/Q/zH6bwBtWbKIIa+O3BETHBFn8lzEao65G2IjAS3WtlRsDtRshuQAuFH6llIFsf6OaoskJumqc= Received: from AM0PR03MB4882.eurprd03.prod.outlook.com (2603:10a6:208:fb::17) by DU2PR03MB9943.eurprd03.prod.outlook.com (2603:10a6:10:46f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 2 Nov 2022 08:40:49 +0000 Received: from AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::7f26:4554:fc25:8412]) by AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::7f26:4554:fc25:8412%3]) with mapi id 15.20.5769.019; Wed, 2 Nov 2022 08:40:49 +0000 From: Dimitrije Milosevic To: Jeff Law , Richard Biener CC: "gcc-patches@gcc.gnu.org" , Djordje Todorovic Subject: Re: [PATCH 1/2] ivopts: Revert computation of address cost complexity. Thread-Topic: [PATCH 1/2] ivopts: Revert computation of address cost complexity. Thread-Index: AQHY5VSpCkpNZ9wRE0qr2B1vutRVJa4i5Z0AgAB9V4aAAAhsgIAHDpgAgADoiyI= Date: Wed, 2 Nov 2022 08:40:49 +0000 Message-ID: References: <20221021135203.626255-1-dimitrije.milosevic@syrmia.com> <20221021135203.626255-2-dimitrije.milosevic@syrmia.com> <3c50de1f-c00b-9f8a-a604-a71bc546f1c2@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=Syrmia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM0PR03MB4882:EE_|DU2PR03MB9943:EE_ x-ms-office365-filtering-correlation-id: ad72361c-6e23-4536-cd9b-08dabcadf1ab x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Hh/iquFTc4wyol3po/gd+RGmFABffUhbfkQZo6PlRR/ZqmTajqkR6Re8BQGsLcV2KI3XSPVOedXoH49DbigMxRpzKdZUZEGx33LEwM7Ye/5PYVSqmjsutrxSIoyy9GXtRKv3LpPi/5x4foHTspGAfcAv6gusVSfLIPJveGUUwLO80ShXtXNoRmK9VytOG6LoWSi6IpIPVqAQmkMzE1sT36nKAMCee8DZFAt6A1nJGds0Eu7m/uJp7px9nHj6oB52wGQGTngr/0Qn7hQDElMsmTRD5H19czF3DHVxiPDD0Ovm/hOIZ5QHdpdCFZvMc728rzS5qKEph7F2D6GJ3jr5XJHPthi8cgHfiXk54rdmYUKzruweyAebUuNrQpeHo3qTjYcvty73bpiL3TEm0ncqiX3AMqMrbwz/Zj+M+AEQ0v5asXNHIKNF8QK7EuPVg+I1A1zWZpB22EMqxDjzUxmuW+vikkR+IgRwPDey0Ft/E02BJDOkQbvBICw5WzSYyh+BGVF03zYzTY1jMPyuOuvWJkJUm44PfwKAoJVySe4/z6v67nCCS+L/VcjfEXJRh0FxuN70Uoua1Dx2IlqYJA/R1jKCnH9mAkHOlAPOFUNlKtu7sc+fGsuEPmOWX3H0QHieBJ5n9hl8GKURdF2+CyUmRcYa4tQN9P5qE8kZ7CQ3jR7ms4vX0KmiK4jQmsQP28qPRSDslmdtNM0jkx/bpZhwaHQqLALPNDaKxEU+VYvk6IMZHMiqkKK5vVMUdVzMegknNKW6MFtGWiQiLVxG1B4J0w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB4882.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39840400004)(376002)(136003)(396003)(346002)(366004)(451199015)(86362001)(122000001)(33656002)(2906002)(38100700002)(8936002)(53546011)(5660300002)(6506007)(7696005)(52536014)(107886003)(54906003)(41300700001)(26005)(8676002)(4326008)(64756008)(66556008)(66476007)(66446008)(66946007)(76116006)(91956017)(316002)(110136005)(478600001)(186003)(55016003)(9686003)(71200400001)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LplwEyhLVcbqvHzMey/J/BkiHlbJxWzaXe9yQt+zZJhMAkxMw43DK3Uhe/q9?= =?us-ascii?Q?XnRFkP0smod1c+9dXTSIfMkhqiVSlxz+AoZRvmFzBsknTna7Tv8ZprI+jHL4?= =?us-ascii?Q?hVYwbDWxRw5Jzc67ixU7HRYmB1vE65rJc+owli41XWZ4hj00O5XEyyB32KP+?= =?us-ascii?Q?MMgkSIbZ41oNmUO6OtgngjfrSbyr1/5PzCfkuwLNct76YeoT0VpUMgK1Hfu8?= =?us-ascii?Q?f+0S5AubF4NoMcPb3movzzL3hiY+17QcT6YyuZ7tI2dNqMa8yDM2tGlXVa0W?= =?us-ascii?Q?spSa5ZPTmwevGMCuHSglaBDianzVevUoZj6y0rQ15fE+mSEVm7bOkqYycefV?= =?us-ascii?Q?pPDKYJfmL+WHTYc899/l+wo9ALGDCNGEke0Fel4Vw18Fi7s+dAwJyE/rbXd9?= =?us-ascii?Q?QqT3JJROgqNsGExx/xnR5ALCoR8ixR/NQU+y7/qAuJxxidGGsn0YVjadb82o?= =?us-ascii?Q?WNEXC9LpIIq8IOKrxCn9N3A4nARS7MQqLFNWBjfm6Rc5g3YB9wjQy1bJ7JBT?= =?us-ascii?Q?U86b7ssASUxH7b2SxKy1TihYQi4Pj4YyO4ZW4xDHUpqM4rlIbo8CMuL73c8N?= =?us-ascii?Q?xT/70oM7x3G1OPh38XrvJF00Dlk75xTwcU4AEaMV4h9UsigaRFvHTNx4CGEB?= =?us-ascii?Q?oqg7AWq0zrdaJZFc3DEcjrHZlZZ1YDlo/o8+s5swhsRwbxbbfsZelDuNTGdi?= =?us-ascii?Q?Y/JhRTY5YfivbOCaZmJG2aTW0W6aYxhD2ILdP4a3XmWonvECl9CgC+hGjjpS?= =?us-ascii?Q?a89N+IukSz5L+kfhuJlmJTb3WzGbLmJ2Vf2Lz5fI5wDn2bJxsJY9Ixmxu0iE?= =?us-ascii?Q?JQaXAh44OUXC4utTzoY6tBps4+rpkR1s048hBK3eOOPN4a3/jYxaazXGAatH?= =?us-ascii?Q?BJuhkwHCiq5Yco3VGAW0yjnxKEI/6Qf0IqmomdRQJS9m+r7lLHbljLVYEm4I?= =?us-ascii?Q?XplBCcmDuUU85YXUPXWxe0G7A2jMQ6y0nN7FjyZU15w/5iyJbtzfSArc5tB4?= =?us-ascii?Q?q+VzxmDTMG86BtBZLJIXEbjFl6iXVLk4Jwzr4t7O8JySNECvbqWvdQNyApJ1?= =?us-ascii?Q?+gbQvzmd8R7Ze5zfma3mC6X6pJTSNtsToKAWA12xBpL/A1BQ4os1EXvasRHy?= =?us-ascii?Q?kLZNGAv0Jkj5hNR/vaURtVuvrVC+cs2y7VJj+Z9OeRrVt4V/Iy++LgJ1Tqh3?= =?us-ascii?Q?qy1VjseYmyG6w0fOTJjMOMsSbOu22Y4/OqFMBw4WnVuqgO0xYPg8cXdM/t5p?= =?us-ascii?Q?OM7Z6+wgsVhl3YJgmFdIpctrjAFMUTVbD7qhryD/m68Ye2soywzfXvTpcRqR?= =?us-ascii?Q?NX2nXQG1ZgVUgCCx1ORfCz5ovRoZBQEFm+XgGM3eZ48IHeQklIeizO7nD/qE?= =?us-ascii?Q?kVpH/3OPLQQPWBlCYHzW/8FL1tovVF7kCx8idopP2U7C0QvfqB5JK5wYDeMT?= =?us-ascii?Q?viQGipoGMaPBPJ4PuduZgcifR+8MgIiyoG/nQMc66/hXKYgfVB+m5X9vSVYt?= =?us-ascii?Q?Mb0NdzaYbqdCg8m6WUES4NK6Stp+SJ1rtCy3mnASU6XHHzeGZXXDi6dR3mJ4?= =?us-ascii?Q?707PxCqFJ4GqWomDh2187nD0cFXBlnGsdG4sGTwa19BmqfWOP0SJB7x7/D01?= =?us-ascii?Q?NA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB4882.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad72361c-6e23-4536-cd9b-08dabcadf1ab X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 08:40:49.5654 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5N1W5al+XaSD8akCoXOxPHE8035yR6hSP/M3jqJITKHGeS72BoUzSHaSs/WazE6YKABze1OGSFOurdc5+n/UMbUTYhp4ae2548ZPbT/h4oo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR03MB9943 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jeff, > This is exactly what I was trying to get to. If the addressing mode > isn't supported, then we shouldn't be picking it as a candidate. If it > is, then we've probably got a problem somewhere else in this code and > this patch is likely papering over it. I'll take a deeper look into the candidate selection algorithm then. Will get back to you. Regards, Dimitrije ________________________________________ From: Jeff Law Sent: Tuesday, November 1, 2022 7:46 PM To: Richard Biener; Dimitrije Milosevic Cc: gcc-patches@gcc.gnu.org; Djordje Todorovic Subject: Re: [PATCH 1/2] ivopts: Revert computation of address cost complex= ity. On 10/28/22 01:00, Richard Biener wrote: > On Fri, Oct 28, 2022 at 8:43 AM Dimitrije Milosevic > wrote: >> Hi Jeff, >> >>> THe part I don't understand is, if you only have BASE+OFF, why does >>> preventing the calculation of more complex addressing modes matter? ie= , >>> what's the point of computing the cost of something like base + off + >>> scaled index when the target can't utilize it? >> Well, the complexities of all addressing modes other than BASE + OFFSET = are >> equal to 0. For targets like Mips, which only has BASE + OFFSET, it woul= d still >> be more complex to use a candidate with BASE + INDEX << SCALE + OFFSET >> than a candidate with BASE + INDEX, for example, as it has to compensate >> the lack of other addressing modes somehow. If complexities for both of >> those are equal to 0, in cases where complexities decide which candidate= is >> to be chosen, a more complex candidate may be picked. > But something is wrong then - it shouldn't ever pick a candidate with > an addressing > mode that isn't supported? So you say that the cost of expressing > 'BASE + INDEX << SCALE + OFFSET' as 'BASE + OFFSET' is not computed > accurately? This is exactly what I was trying to get to. If the addressing mode isn't supported, then we shouldn't be picking it as a candidate. If it is, then we've probably got a problem somewhere else in this code and this patch is likely papering over it. Jeff