From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2122.outbound.protection.outlook.com [40.107.20.122]) by sourceware.org (Postfix) with ESMTPS id 704CE382C5E2 for ; Tue, 7 Jun 2022 10:12:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 704CE382C5E2 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=Syrmia.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Syrmia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dklQWCKBvlLIVq2lsSrMTVt6zEs0+egWAXAOPmpv0iaN7PSmj/BM1+/7qjcp4AXvXjCjv4y7I58ECV3+MyUz/4QgEKM6x5ThdQUev2tD8SoeGpuTFhrOqYEBMpMQQlmBx8SKA5GROgjiqgz7WCCDqSMJ7nUNuCtAbHpZcRbQMdXwEY/U/ZR3FTuIBjZa+R/bnjGfUPDM9Jin8XrxsVFJeC4nKBUdarfIjUOsBmomZX1aMhWcMOpXIZMxARjHuQKqpQkeTvUJKH5WWMElsXdT7dZl5YL+EYr3jYG+npDsI1x0Rk9sWfRAwyujm3rCqI4q7la8QtEC3emsQ+ebyJCxdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Am1hhNPJvF9nlMxClWMUG/DP8hX4YaCTVpWNcf2hArI=; b=V5jb+WkaWssV9Vu5fu/chnhpcHqwO3gbg8vryJc0UjF/kPL41CnmPEVT8Sa9aZMbtv4QTk1+puE9AJoKcSA3xKYDFwfle+jLVZU+rfSJo4O2/uCvDmg7JGy6fBbM1Wc6MNCpPzz7+s70f1GpqKABbpdKO0LtJsfS0kil5CDp0Ndm21NeYjTptV0HDzfFryjn4JCFeBHDhQvlDhiUTRu9nS/Ly7cBtfzf8/r/yp69kQBbo00WHWIXyDyrjiJ+Qh8gas+6mkz84gwVzb8kdPZ+oESg0I6d39vp9FSHyyHFrJfFOwAfVBbl7LibhTWc9Nb5KKc7UOX2Z0JHUTq8DMTLGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Am1hhNPJvF9nlMxClWMUG/DP8hX4YaCTVpWNcf2hArI=; b=ma81iOwMSEzLeKtlhtXI96YnZG0LxhgQKkhxS/S3WnPTDa/n9b13bivsH3ELK3lgYZADH6aX3JrTPRHtakQG/+E0y9WqSm1owyfjNrj0fk+9JWysQ11SxvrMG63O81lWX+D3bVg/NhTNS7kmXY+AY8xagvhh4+sFfGdAWpocHHA= Received: from AM0PR03MB4882.eurprd03.prod.outlook.com (2603:10a6:208:fb::17) by AS8PR03MB7655.eurprd03.prod.outlook.com (2603:10a6:20b:34f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.19; Tue, 7 Jun 2022 10:12:29 +0000 Received: from AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::3926:6805:c765:27ec]) by AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::3926:6805:c765:27ec%7]) with mapi id 15.20.5314.019; Tue, 7 Jun 2022 10:12:29 +0000 From: Dimitrije Milosevic To: Xi Ruoyao , "gcc-patches@gcc.gnu.org" CC: Djordje Todorovic Subject: Re: [PATCH] Mips: Fix the ASAN shadow offset hook for the n32 ABI Thread-Topic: [PATCH] Mips: Fix the ASAN shadow offset hook for the n32 ABI Thread-Index: AQHYeXLW+Ux1t4W5F0O8YudMGLDc5q1DmyIAgAAf+1w= Date: Tue, 7 Jun 2022 10:12:29 +0000 Message-ID: References: <5e2a5b29aaa1243b30946af478852cda50fb226b.camel@xry111.site> In-Reply-To: <5e2a5b29aaa1243b30946af478852cda50fb226b.camel@xry111.site> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: 60bf2e8c-d3a9-1c19-9a55-24ad9498bec4 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=Syrmia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c10c6c8-140f-4666-d1cf-08da486e3abe x-ms-traffictypediagnostic: AS8PR03MB7655:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PNx2//VDEvvO0cpLk4wngsOwr/0ytis4XUFV35VXmnXNz8XO91zGt0YhLb/f2CkOmQfWD+tTKmJwZWERA75BbVRI/8xUc1AFIYE4/kJzfqofHdGC0pEBvhPQpcYY45JqzRNIMyrq6M1GflqUCQwEpuR+m2Fwslhgl8PDTvu4TQwPcdtTSZ2kZ4NCVQAaUEjJHpUrCqfh2fbI0yXDlnjZWHcR1WDtfg2agaoqXJcFDMeiJCcPk5rK0gZh2O+59emGrZytJEawxEEqGDylX+f0DQ9sDmSuucxvoFbIA0dxELCfEf0PA9ZgMu66gVsAkXRFwoxyQCh6aw6I23D5WGJAIrPGFIrR6tlopPTBqpdgfn1EsrTmLKjRDGyZy+fEfEX9rjcezga0BX1L9rjT4kzxOwMYBB1fj2gSiOnjoVdLJknBSJPO/MJuOM9Wm7wrngRwBEuwJIsBUC0YZ7/hMZNctstlf3wISqB99O33k+PrzcmBb+qiNzK9oo47SywDa/eWv+2JG28tCoWAHt39Yu0xSzOgrjxZQkY6izd443MekBWWb0vkjUD4y14HayrJTjC50mzXtD2i+SO3sP7auP1FBXKX4IVGEMoI9gyGLRkC6vJ2EgWfW4T5ADhLRxujsD0bOUBAKDbKQai3DW2teOA9J94RURL/5E6AB3x3A3VZg8J/C3h8nrDhKSOuufxMXnKrrhhoyEH5wzbuh3SQuTXOZ8QisofZttZDS6Ra4hjD/pjkcNhormOcUzqUxt8VUlM6BP+1IxZqhEIUUMeKB9ciLd3oO87qtY16AI62HEx7bb8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR03MB4882.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(136003)(346002)(39840400004)(396003)(366004)(33656002)(316002)(8936002)(26005)(38070700005)(86362001)(186003)(83380400001)(53546011)(9686003)(110136005)(71200400001)(508600001)(55016003)(52536014)(966005)(2906002)(41300700001)(38100700002)(166002)(19627405001)(7696005)(6506007)(122000001)(5660300002)(8676002)(4326008)(91956017)(66476007)(76116006)(66556008)(64756008)(66446008)(107886003)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KWZjUqpUMkuWB5trSilzY3xLTYCPqx9BPAgcNIu2w/RZ8NgPLgE79eRoNnZw?= =?us-ascii?Q?CficrWWgVZZ0iG76lcO1WQ4Rn4RqQxouF6BlXViBi9ux6/kHg8o+uWWK6ZZJ?= =?us-ascii?Q?ySc3B/4SsV+bEQWY0lbP0YsIxXQ/1FyAZhwxOjMWrE2mPjpRW/My1gvFMVUV?= =?us-ascii?Q?NgbCZLEGhaRUvBHIeLmFTwUjS7ZzWJidqA/V/gF45909ywoOCfruqJM1PzzU?= =?us-ascii?Q?bBfQ06ggSN17ELu6Hy0xGUCukD3iW8VuRGdBNZWKI9e2MxFWR6Eht/eO7IGK?= =?us-ascii?Q?NP34L5ZIZh8CgC9JwW+cvNTBDJ3JUlZsKNOi0SJmBmiWMkJFVnWQDSryYKsp?= =?us-ascii?Q?wivJgKTQ38gxCeCAimIC3eWv/ALVHZNTZ85zMug9QHv//3LB66LqUkRh27QH?= =?us-ascii?Q?xuM07LAnrtVGSURA5igEQsnF8fwvpZUWoVbUkH3YYuA+x9spRsQ/uxdQaCgt?= =?us-ascii?Q?y9hj4zk1Mvi5sBQ6tmKQJZYgoqFnAyF1nTBoLC6R2xQxASadVZIkenBslZUE?= =?us-ascii?Q?/0ZKSi6Br34xYBp/mGkiHFIj9vIUoT/cnQAqEnXtHpNCkzi5sHf04V1mwUGC?= =?us-ascii?Q?UMHBbEn4MmT8jVvksQueDnztMTGq9dRmEvMcuLR1hhPfekFw/HShMrSWHkrX?= =?us-ascii?Q?R+e9dlV5TKzR8xvC8QEYDO06l+0QlNO+GjOI39I+1RWKrzu4SHHxuFbADyQ3?= =?us-ascii?Q?em3towCCieztkg/1jH0HekpxqwzYqUuU/JNKt/M+ahUDd5/HJuDpf2Y26TP3?= =?us-ascii?Q?mIYuqLFnOQMSPJWoUc7aEe8tAdH2CvLNK37I0lz1bGpXOpsyMbQX/tSlpEhU?= =?us-ascii?Q?Crw+Pds4dIoWKb0v5oEFRON32Y+NclYPmYPD2/ABaStnh5fnfKurWQ9v4pIf?= =?us-ascii?Q?7BMNdh7rw/hJndjelBKhpZzjuPzEKI0FKcLlHjA25oSdtAHXAsT0OFmpluTP?= =?us-ascii?Q?gDszZvnEwcu3twctgWpiHZUZA0a15BhFKHJxKq2OH3UBohesYpC8nHYrbLbF?= =?us-ascii?Q?HLnpSMtAiZtKR6T4+pQx/ThGgVGjSqLy/AsJg99oaR+7hrM0dYVnXQ/Ca4Jr?= =?us-ascii?Q?HzEDuKZwyLfKyvhkzpYfXQdbYzAO0Pu60iOkh9Zo9m6dAvtEu3NL4rNjTSaM?= =?us-ascii?Q?UEV+GwEKHTqYrS+6q8yDk0DJh+iGBAsu63cEaFdKKT/e1keiHqEvhBVZiw1J?= =?us-ascii?Q?aw/YpekYrMojz1XASQ4OprEPQWWITqUySSMYvV1qqzerI9Rco5Z2aSpc76yD?= =?us-ascii?Q?xnr7lizU+OZTBGErV5SGTzQVvNEqbtUuBCiZhDZ5pzXnbGdlPrcSe0JGPMX+?= =?us-ascii?Q?84Ymz0sOEUeo3MyhPeXYtp1wglisaJ4bLGQR4p4CTJLysVomjE6phSTq/0PJ?= =?us-ascii?Q?Inz0UFFIsDkS8LwdopwK9wigRVJe4NSJ8/0uQpuXe0Jguscmj95hA/ptngMu?= =?us-ascii?Q?PGiH9R2Snap6pOFX6cD2w3kd54KRcKid0lpUTWO4jE5U+aL2j2zu26hCwhZv?= =?us-ascii?Q?S72yOM9pPzJDwu7qV5FNAGEz7djKxXWnQYn90cRrg7RuIQrX6q1kv9/WMV6s?= =?us-ascii?Q?X4SwTYcaiz7YavSksh9WYpW1rEy5+7+fctSjWxPSFOE1HOVeIsbe5r+XOHBA?= =?us-ascii?Q?moDeWjCKqRLpF4tfQ9JmqCr0RC7zeUR2N4YjxXenjpsA0tXij0w+5nKCmykD?= =?us-ascii?Q?m3iT8Ed0ZDj+lPguzSr6jZKGRSArwWyA7wCuoMPsHpPXG9Oj7NmADyrdNK26?= =?us-ascii?Q?m0fyIEyf1qz0FDOEdO5OswUtFqTqrUY=3D?= MIME-Version: 1.0 X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB4882.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c10c6c8-140f-4666-d1cf-08da486e3abe X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2022 10:12:29.5376 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sXMzbW/07zRsvxxvmSqUSzQnwvs2YB3lntwcRGbFqrUWGsDWBox5HMNv0pSMAYKlnrZpCnWCEVftCl0whsoZVrgRq3BhfbnkkEkIAWw7Wdk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7655 X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 10:12:33 -0000 Correct, it should be committed very soon. ________________________________ From: Xi Ruoyao Sent: Tuesday, June 7, 2022 10:17 AM To: Dimitrije Milosevic ; gcc-patches@gcc.g= nu.org Cc: Djordje Todorovic Subject: Re: [PATCH] Mips: Fix the ASAN shadow offset hook for the n32 ABI On Mon, 2022-06-06 at 09:28 +0000, Dimitrije Milosevic wrote: > Fix the ASAN shadow offset hook for the n32 ABI. > > gcc/ChangeLog: > > * config/mips/mips.cc (mips_asan_shadow_offset): Reformat > to handle the N32 ABI. > * config/mips/mips.h (SUBTARGET_SHADOW_OFFSET): Remove > the macro, as it is not needed anymore. > > --- > > gcc/config/mips/mips.cc | 7 ++++++- > gcc/config/mips/mips.h | 7 ------- > 2 files changed, 6 insertions(+), 8 deletions(-) > > diff --git a/gcc/config/mips/mips.cc b/gcc/config/mips/mips.cc > index 2dce4007678..91e651c458e 100644 > --- a/gcc/config/mips/mips.cc > +++ b/gcc/config/mips/mips.cc > @@ -22745,7 +22745,12 @@ mips_constant_alignment (const_tree exp, > HOST_WIDE_INT align) > static unsigned HOST_WIDE_INT > mips_asan_shadow_offset (void) > { > - return SUBTARGET_SHADOW_OFFSET; > + if (mips_abi =3D=3D ABI_N32) > + return (HOST_WIDE_INT_1 << 29); > + if (POINTER_SIZE =3D=3D 64) > + return (HOST_WIDE_INT_1 << 37); > + else > + return HOST_WIDE_INT_C (0x0aaa0000); > } > > /* Implement TARGET_STARTING_FRAME_OFFSET. See > mips_compute_frame_info > diff --git a/gcc/config/mips/mips.h b/gcc/config/mips/mips.h > index 858bbba3a36..0029864fdcd 100644 > --- a/gcc/config/mips/mips.h > +++ b/gcc/config/mips/mips.h > @@ -3463,10 +3463,3 @@ struct GTY(()) machine_function { > && !TARGET_MICROMIPS && !TARGET_FIX_24K) > > #define NEED_INDICATE_EXEC_STACK 0 > - > -/* Define the shadow offset for asan. Other OS's can override in the > - respective tm.h files. */ > -#ifndef SUBTARGET_SHADOW_OFFSET > -#define SUBTARGET_SHADOW_OFFSET \ > - (POINTER_SIZE =3D=3D 64 ? HOST_WIDE_INT_1 << 37 : HOST_WIDE_INT_C > (0x0aaa0000)) > -#endif > > --- I think this depends on https://reviews.llvm.org/D127096 (not committed yet)? -- Xi Ruoyao School of Aerospace Science and Technology, Xidian University