From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2099.outbound.protection.outlook.com [40.107.22.99]) by sourceware.org (Postfix) with ESMTPS id 8BF3C3858C51 for ; Tue, 12 Jul 2022 06:42:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8BF3C3858C51 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=Syrmia.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Syrmia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O/KHBMZoK1lGonbA+E51fec0zdB+BgeIOnvMvJOLKb6nn8S4DBcAVWagqayk98Mpjg47Vd2MJpgUEx3QrAsxYQ1EDeZJFaC9EWdx8QQSeddp4o4iNYHflc3Si2O/gNVJjvGuwh2kdmfGubQOlqmrDO6kUHiW6LM4ftwwLbkLpG9MXTdTAwoXQi4puGK3ZS0X0dt+FzZ9NrSe2EY7uPui4eU7jLt6eZs33AfXRmllx5KgtgDJphQwtRMEi9pA3FZ/TXtXRPEDl5sxK3SmAKwTxux3g8DC1jM3FA+7/arQE57tkvip2hUiC1ZGeW5kZC21K2TsmtWj9Y3K+vo9dHkBaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1S84xam4syXWG1d+rCfbcypgWheRiEl1YoXtm+suTmw=; b=iwXoJ98M95OqmWiWG3jUTgrK95RgcJVrMVKqpkAP0hR0Ph+VyE1ZXtFBZGj9mPjpFoiMuv/kBZGIJ1XIVUVaZRkF3b5S+LARSmvACxPSDfnx7KLRql8JPy5kjDXrFbqq5rVRe3zOQj4ju8llfydwnj/xXzqVfJOIgPVNoTkdKUSnwHoQ/osr6v+4vKgpBTvlXAAAC5GLj6WaIcvWsuFyNgW6kcV8ZTmCTv1m7oIG2FNUyFYrSzbDqgnC1OTgD+dQZvoXRTAI3NVopjEpzxgjxNhA4+fUIRNsewM+398AJsS7yoiJyknnj+MFBNKM9FWmNoK+d41YPhtPUYZdMtUxDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1S84xam4syXWG1d+rCfbcypgWheRiEl1YoXtm+suTmw=; b=WtqemGLMdo4t7Eac4hGcebqomZCaPSeVJqgclq7s8dRZY9+UGX2OYSPA2CM3F7DhjZo4pkBvGrN1XBqZ0naC4LW7ApkkGyqMuvEiwRsWVYS6rBA5tISpQoxiD4kDPIO80VrbW3/0ZocOHtnSEz5ETHG/2nZp6ru7zP60w1fHslY= Received: from AM0PR03MB4882.eurprd03.prod.outlook.com (2603:10a6:208:fb::17) by AS4PR03MB8316.eurprd03.prod.outlook.com (2603:10a6:20b:507::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Tue, 12 Jul 2022 06:42:03 +0000 Received: from AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::3926:6805:c765:27ec]) by AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::3926:6805:c765:27ec%7]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 06:42:02 +0000 From: Dimitrije Milosevic To: Hans-Peter Nilsson , Xi Ruoyao CC: Djordje Todorovic , "gcc-patches@gcc.gnu.org" Subject: Re: Mips: Fix kernel_stat structure size Thread-Topic: Mips: Fix kernel_stat structure size Thread-Index: AQHYjUL/Q7GnLzDA50urYJcPdtpP9611T6gAgAAB9oCAANiIgIAELJ1N Date: Tue, 12 Jul 2022 06:42:02 +0000 Message-ID: References: <56af834718d603a4175a10df0a047d92b0b6d139.camel@xry111.site> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: 540ee4b6-684d-cd22-4802-95951d2ff0b4 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=Syrmia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d6c1230a-b1de-4d11-eb84-08da63d1a10d x-ms-traffictypediagnostic: AS4PR03MB8316:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8xsWDGybhYGbi6JOk60L2a6Shud3qICR2yW8fvkQ9kmcO6q2hUhKr1DdeqW/3jDIgJj/J+/lVxo4jS9xRi6GKnVPLGPMdrPtT3hfWYcL+A2u3hxI9hbSp9c1QVD5/auLf/VWYgc0LgaNLMFBKsco6Eb6qr3d3mky3MlZf5GZ83jmhIbK0Bb0yVPKkhlT59dJk/U1s0p5aO5hETnpECPDNdZ/RauKO/fj+Rv8NZASDCHdyGrp7xnasYeU/V3tfSdYRRK20iAmeptK3FeEkUQk93cVZtjLNiGWugjDMbIgfFf2P98C93p17wJ7Y9SyFEnzRhvWu6KCPsnc1mmCFGzE3sO4WpArHrBeUFEUlpZhpLT3umtPetUAFLNQMlhRLuQ1kIFFaRbLIVdtNiVR22d7UQWFYGEuOSoP6R4BBerqshWjol8Y7HR7okbv9eW/RemmYSc6qPa38OJNZgBnLUhsA6eG+TntVMav0ynuS17Gdb7eGGE6udgTfycbLFcqU31NVSNVQGUl7cgE3GKQ3z4FcYo1qxCtcp/S4pwWnUseuYcvd/KGbnODnFpKZmGdH8dXMRLaIoVYPDW9vNR+Ir3uLIBSmfWTTdLn4rmyrq995HMW52qeDk6Tz5jqhvxUOGVk3cZFxIFq/22wEjQsywlY2kxxxCmRvS99Q1mxGR2ajubAx6VpOHZRgV8aoAe1O9E1PZTyh67u6OEzfEJtVvLn/TnudD2bJCQ1m1+/m9/L1SB9fj8056YJMR4Z5Q98k3NcGnppELMXKGLwLKjwfI9EWFP+QnozUH5dW6/ioB0sqv80vnIRM03ASJLG5Cm9QfvJ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR03MB4882.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(39830400003)(376002)(366004)(136003)(346002)(38100700002)(55016003)(71200400001)(41300700001)(478600001)(7696005)(8936002)(33656002)(52536014)(186003)(38070700005)(4326008)(66556008)(2906002)(91956017)(54906003)(64756008)(316002)(66476007)(26005)(76116006)(66446008)(110136005)(122000001)(9686003)(86362001)(6506007)(83380400001)(53546011)(5660300002)(66946007)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?MejTe4c54GqqFzdt5OmbMe4dh1pskiYO/CpahbVFzn3wR1c1OKdUj2Srt8?= =?iso-8859-1?Q?x9GgVJDLlagD6i9L89JCMKdzFbcWzb7LAw9lONP8Um03Kjq7BrVGKVY6fW?= =?iso-8859-1?Q?lErYhGofV+2UuZb7kgjgfcGZADPcDaa7qoEwmUJiHF5YcONXpGCm6xKQks?= =?iso-8859-1?Q?EfDEpM4Q0Ys56gDXkiDKjlp7WRqSpnI0SPCSCl6hGuzjm6EtgIWQXU6GI8?= =?iso-8859-1?Q?sWi7bxSr7Sl13jiNw16XgOyAsvveXbteSHjlT6g9O1kOFlKOTc6Wn3RrsN?= =?iso-8859-1?Q?4cLojNTrqznnkUX643FXRdige3PIFjSPYBtwJmtO5Sw9o0mbikiruJc9gY?= =?iso-8859-1?Q?dcV2jMGSB/qj7jWlsmvviTemMw9lVLwYz04+/YsuzWKOUsOUJ7zQ+5OeqS?= =?iso-8859-1?Q?0AR97flC3O1p3djwjAJNiGEpbZtq8WUAb7k4iQJ+P65WgwWYaKBIwwi4HU?= =?iso-8859-1?Q?Lfx3zRsr3nMGcGwodW1f83HDELXjYJhoq57tYabMa4bBO2Ttv7zlL+dE6g?= =?iso-8859-1?Q?NdWas9AWKTIbmvV9SgP9331mRj09QygRvCebwZfWnCoCglX5dnpIukFkF9?= =?iso-8859-1?Q?cinS3gVougKLXRKWmwL19ls2S8XKH7mi3H7UVIjHnofA3v4n1/pXp/jMZ7?= =?iso-8859-1?Q?+a/JIqeN5hM/TBSz+NjvoPPidNg1JMbaSMiOBUxK7coy8AJiEJ/OjOKzpt?= =?iso-8859-1?Q?Cmhyf95ReYkS253m/RPHKfKi+kVnXa10N69G37KIPuxGYMKYFOrGtw1eZC?= =?iso-8859-1?Q?uPEZcpr9jC8PxzZz+w8gVyU0zvZlCw/kVo40pBq9O5z3WJ0ncIfTovJ2fC?= =?iso-8859-1?Q?xfVugQtX4srHfrRVWoj7Oq2O9+P9iwc+lg6azSprPQkgy4WXzonOCSjP1E?= =?iso-8859-1?Q?BbhTmOjmVoKstFFHEvKifaESK2Ju4y2PloymzhGtNE2eWsprqbAO08OFD9?= =?iso-8859-1?Q?h/CMGTbVQh5JpUpL2yeD0HOEqMl8D8Ch3+2++Qjn/QaU94nWuVXgN0V2pH?= =?iso-8859-1?Q?qZO0Ts5CIb21XZqaRFWtO/5spZPPBM2uNWK5K2nOzMgKTinmO4NaVhBHEY?= =?iso-8859-1?Q?JRP2bTRUwNnFvk1TRg5CFLLwhHzwJiljM0UhmvCMHeIRSzwO2ZuJ3nSSbJ?= =?iso-8859-1?Q?GTxPQqwpLJgg7dc37MtHEGzTKgQTZDibnNdoGK1CfOvYI7jB4oGMW9u11a?= =?iso-8859-1?Q?JjlI+Ad2ORrXfM19j1Op5AwZFmAqXiGHEYwwsIEW9eWJREbAwqs3uRL31y?= =?iso-8859-1?Q?Mn7LhhiehH3LJzhUZ1S7H8t1xD6JryYBgTOC1U6+eYTUFPmNotlPZBdkVM?= =?iso-8859-1?Q?5J1O+VTL4d5GMAjN7Fr3uWeydtrlmmjKgmu1qFG7fmsy7mNz5U5KjJxGiw?= =?iso-8859-1?Q?JsKSCWrdAKPE4/737+lRNtwQMALexAXuJUOfNySGQQHriKUpUAf08RBv3J?= =?iso-8859-1?Q?YrUe5Z/AigY/UHOQ71aX74u5yU8LDY7hfehpujviXRfGbrUprreJt3qyG+?= =?iso-8859-1?Q?JEMPoeK2SzA+u7EITCO8Bgpi2GqutDZMxMlSn8Nu5dfcnOx9gT/mkEgpML?= =?iso-8859-1?Q?mVbPRY/ZmlaNbvvD8SSe2d2HQyGsMZVICVKNkB5ovHrP7BaVeSXAAnv23P?= =?iso-8859-1?Q?p5l38DbQdh7JhOxIjzGQe4HIQmLNrGu71RWB6lYr9U/jvdQNCsxro2Vw?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB4882.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6c1230a-b1de-4d11-eb84-08da63d1a10d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2022 06:42:02.7236 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b945DVSZEx7CLPTYBBvGytvfbGR62eLr2DAcw99Pu5fN7diwCZ01oh/lFjWcw+WvgZ4KEfIvA0W8NFqli6gGBy5jhNmzy2bsZdAvm3WbXWo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR03MB8316 X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 06:42:06 -0000 Hi Hans-Peter,=0A= You're right, this is not ok for the O32 ABI. Your change however, broke th= e functionality=0A= for the N32 ABI. AFAIK, the changes like this should go through LLVM first = (yours didn't),=0A= so I will send out a review, covering both 32 ABIs, meaning that both O32 a= nd N32 ABIs =0A= will be working properly. As for this change, I'm not sure what should be d= one? =0A= Should this be committed now, while the LLVM change is cherry-picked once i= t's committed.=0A= Best regards,=0A= Dimitrije Milosevic=0A= =0A= =0A= From: Hans-Peter Nilsson =0A= Sent: Saturday, July 9, 2022 4:44 PM=0A= To: Xi Ruoyao =0A= Cc: Dimitrije Milosevic ; Djordje Todorovic= ; gcc-patches@gcc.gnu.org =0A= Subject: Re: Mips: Fix kernel_stat structure size =0A= =A0=0A= On Sat, 9 Jul 2022, Xi Ruoyao wrote:=0A= =0A= > On Fri, 2022-07-08 at 21:42 -0400, Hans-Peter Nilsson wrote:=0A= > > On Fri, 1 Jul 2022, Dimitrije Milosevic wrote:=0A= > >=0A= > > > Fix kernel_stat structure size for non-Android 32-bit Mips.=0A= > > > LLVM currently has this value for the kernel_stat structure size,=0A= > > > as per compiler-rt/lib/sanitizer-=0A= > > > common/sanitizer_platform_limits_posix.h.=0A= > > > This also resolves one of the build issues for non-Android 32-bit=0A= > > > Mips.=0A= > >=0A= > > I insist that PR105614 comment #7 is the way to go, i.e. fix=0A= > > the merge error, avoiding the faulty include that it=0A= > > reintroduced.? Was this tested on O32?=0A= >=0A= > I'm pretty sure it is *not* the way to go.=0A= >=0A= > Sanitizer does not really intercept system call.=A0 It intercepts libc=0A= > stat() or lstat() etc. calls.=A0 So you need to keep struct_kernel_stat_s= z=0A= > same as the size of struct stat in libc, i. e. "the size of buffer which= =0A= > *libc* stat()-like functions writing into".=0A= >=0A= > The "kernel_" in the name is just misleading.=0A= =0A= You make a sound argument, and I just refer to my old commit=0A= 9f943b2446f2d0a.=A0 Either way, the proof is in the pussing: was=0A= this tested for O32 or not?=0A= =0A= > And, if you still think it should be the way to go, let's submit the=0A= > change to LLVM and get it reviewed properly.=0A= =0A= Sorry, I've no longer interest in mips besides I'd like to see=0A= un-broken what I helped getting in a working state (support ASAN=0A= in gcc for mips O32).=0A= =0A= brgds, H-P=