From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2102.outbound.protection.outlook.com [40.107.22.102]) by sourceware.org (Postfix) with ESMTPS id 4BC2E3857B80 for ; Fri, 28 Oct 2022 06:43:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4BC2E3857B80 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=Syrmia.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Syrmia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KcEtODJQVIruIHCR2VbPdpyopyFNw4InGaBHBqtz5jQLEElkWo39tFB2+dbRW41VTeHjjrZexXaaLziXZXkNzy5Mh7gtAi5XxKqEWIHWUnZxicgMgxt/mtORQXtxKHFAb9D6Imi6Ki7Nh7dA2XNTN2hYh/0YxYktZzcS/qhVJmKE2EvcAlKyYctvPk2z/MSFhmzMTuivCoHVYiHy1mujDH9WnIWZCjY6vIgO6HFGAQl0EPSiofXt3eY/XNRl+WUNru+PoFTijP8vY0bf1OxOEYN1jxkGcFbhdTrvLqbApSh/CNcgbrs6oyY3om0QTfz/g4zSr28xLIyTJznI33bNgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bB85adF7x60w+AuIVZBJ4kGG24O2s++UovnKddRYxiY=; b=RZpXdmlZlKFgTCh93liaRmv9AQpkj2Gln51RsQhaxFtKzUg8A1Q2rMVt2LTfdDb9zYkQi3e1TAFc0UBiFCb700D47P+lbyyZ0hfFMuwHPmZZbMfQgWpqL3rWV2PdhasHuW1e8XFQJbL5OnYfCg37xr1822kpQaofIIYWdfdnCqJddM3dcykobK/1gSea0u5c4WhNJf2nD4ObdoutljcJTMNBxBwcJ1S6gx8DvS3Bmart3et8oCH40JeYO+Xcr6ajmLp3LSdfPZiLW1YeH7/4bilxvghDbdkeHbp/izXzL8zZNlKaVJg3ZoDok8z0Dumls+/8GtqBf2gXrMZN0x4wAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bB85adF7x60w+AuIVZBJ4kGG24O2s++UovnKddRYxiY=; b=R3Nv4VD+7P9FBNS4Gf88/Kd7k4nM48CnMmKFzbImmMFMrx95XgkuVrg5bsj1TFI0cE3YMy18aTqE1kEsXbBf0W5dkP/YUH49u26oP5IyijxD6U4xI9EdrPJ4OJUNqW3kTwCQ8mCSAZsgh5VYcc7UflGWo83+8AnqWftGDJdAwXc= Received: from AM0PR03MB4882.eurprd03.prod.outlook.com (2603:10a6:208:fb::17) by AS8PR03MB7414.eurprd03.prod.outlook.com (2603:10a6:20b:2ed::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Fri, 28 Oct 2022 06:43:37 +0000 Received: from AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::7f26:4554:fc25:8412]) by AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::7f26:4554:fc25:8412%3]) with mapi id 15.20.5746.028; Fri, 28 Oct 2022 06:43:37 +0000 From: Dimitrije Milosevic To: Jeff Law , "gcc-patches@gcc.gnu.org" CC: Djordje Todorovic , "richard.guenther@gmail.com" Subject: Re: [PATCH 1/2] ivopts: Revert computation of address cost complexity. Thread-Topic: [PATCH 1/2] ivopts: Revert computation of address cost complexity. Thread-Index: AQHY5VSpCkpNZ9wRE0qr2B1vutRVJa4i5Z0AgAB9V4Y= Date: Fri, 28 Oct 2022 06:43:37 +0000 Message-ID: References: <20221021135203.626255-1-dimitrije.milosevic@syrmia.com> <20221021135203.626255-2-dimitrije.milosevic@syrmia.com> <3c50de1f-c00b-9f8a-a604-a71bc546f1c2@gmail.com> In-Reply-To: <3c50de1f-c00b-9f8a-a604-a71bc546f1c2@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=Syrmia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM0PR03MB4882:EE_|AS8PR03MB7414:EE_ x-ms-office365-filtering-correlation-id: 55c5b108-4bc3-44b6-209e-08dab8afbdf9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aXVe+UnRFWxgLoAovQjtzd5x323fmOnF2ztxOhIIDzdA+0EdX7NMyGJ5DvQAfmMVElKQrbGgE952eOcuqiNSTZK4a2T9c/sma+H3foLHllX2zHjU1HW6PV8kcT9oTB2TLNLj6l0UPqSF78TqOJzy6AsES05DQD9LzIimYVX5X2sDzqm4F8j7njteyfDWMPcom/xdGZdQ8sZ9nvE0Y/EErJ9LJ70sUTpzr99VhYtXRH0oy0wvtM79R80NFBg7idH2t+mD1dCoRkwJquD1KGk9S3vsTxwcXROKsq9XcpLob0+d93MYBYJnMQNQRV82Eqgqh7dSyjLfVSDqMluVzpsWNcR8OAo4oIGG3WtnAvDR+4ZCL6cx6ako/idvTRD6q1zVahCz1qnT31rNYSGVmU2IHMWEE7ed0L1BW1x6KPB0/Rjq6xFOEVS6NncPC9lGQ3pGGbPath2oSeFziVqLPmmoYrJgD8k/e+ffDD2ZLllwN9Q8ak8lIZbdHYv1o9fvhu8rcpsxBYfGDPDfrS2SYBe0VkNJOZ35cG3p+gpSG6VTAZ5+TsFpZMflASdeVJVDORcGCTH0ga5xlS07tBNc7gj848Thk+jJxVQhIG1AKPezguSmUPczR6k7dF1oT1Xh3IH7HnftP2OywWpVP1QU786bD5VZFpgGgY8ohf27wanmijz2oDBFz4GXzVlptLre1HTbUZhiusy9KgEstical0sQPpkQ9woh0HawxpViqTNrdG91khYZYJvLLdOpNyvabl38 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB4882.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(366004)(39840400004)(346002)(136003)(451199015)(91956017)(64756008)(66476007)(66446008)(38100700002)(8676002)(66556008)(55016003)(66946007)(316002)(4326008)(2906002)(54906003)(33656002)(76116006)(110136005)(52536014)(122000001)(41300700001)(5660300002)(6506007)(53546011)(7696005)(186003)(26005)(9686003)(71200400001)(478600001)(86362001)(38070700005)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?9L7gZY8DIc+X7I00XsfoU299y9lHvEsT8CD2aT7a8KMag39+81NJmQmKvp?= =?iso-8859-2?Q?fu96+c0tkGKq1b43Z+lA3S6JpEz9YnJXheKMbsH9hrnX0yFC+BT7klmtKA?= =?iso-8859-2?Q?KUJzVaClm9+e9SnMv+L84s2m2k9HrZdbBehx3rlJVcr+kJt1oTAdB6SdJb?= =?iso-8859-2?Q?XP6w2loKoPsrcmSLYYUeW4O+iB12kVWNii7r2ek4YoVKtWpkjG69VGkVkF?= =?iso-8859-2?Q?ox6DnRMmb2fhHV2WNzNcBl0Qkb5lPZO44j/gd3ROK34dmlXMTW3m8ZFYEF?= =?iso-8859-2?Q?mis4oiI0g8Op9sXthaGTvnvHcsTr+nwd6T4cSe4ojx6r5usrWww5u5neRt?= =?iso-8859-2?Q?83pRhqHI8oYiCrt+SRuRR1KHd8qkhQhDerVAoV/znaB/q7NEps66rsnYao?= =?iso-8859-2?Q?PuSjuLff4CQrcKsL0gjJ9PGoe8Z4kq0FdQoDazAd+ZQ+HXFDTp4n4sPGqJ?= =?iso-8859-2?Q?7NGr6uz1ZxBuFUwx/EcFjtv4TbQ3ZuCSWzv/67tH6DGbk5sCVxeAXIXj7K?= =?iso-8859-2?Q?pcYFlEz0i1bSaPVEv/zEFPlbqLT69nSVUg6Js9j9cOg77uGEeVDyAHnG/O?= =?iso-8859-2?Q?37zMjlRizuGKPYAI04WytiTS4hAopt8lDks/FkSwnqI3cPZASdQKssQVOS?= =?iso-8859-2?Q?UKYPwJYlaHg6dw93pGb4b81zcS7W2HbTBoBHo/7XeoLSYuSrYpq93jtQ2v?= =?iso-8859-2?Q?BRGGPCMYWrEgX3YJEsgXNj97zEaO9E14S//cnqOfSulsJlN5zG/1AmKi5C?= =?iso-8859-2?Q?r/Ji5X4LWpRHgeAndQeADg4f35XbeZtuKW0K+s7c/zO2YoKUhspkkUGPfr?= =?iso-8859-2?Q?0qwTbsJt0Gj6a0vqcSaQRDgjGL5kC++piPK56gcIMVLICl7LPMM1qqV4KE?= =?iso-8859-2?Q?OS0KpLowcFf5qFAyciuVeVFp4YNbCvCmZhi7aW3cu4hBsHEsHdu7P3ggef?= =?iso-8859-2?Q?zPZWF8lTu0OF5Y3ABCpWjnP0m9MsaphFtGUpgRI/lrlzzN/tgSLxp8ZR8m?= =?iso-8859-2?Q?XS1k9q/tXMUIWljMP50hEHhamgiukHxHasZk0wgSL8byckiopzemTugG17?= =?iso-8859-2?Q?Tqi0J8WnYE1ZhbArImE0fnC+ABhLrh6bKkKVoEJfkcyEd9chr5btX8n1pJ?= =?iso-8859-2?Q?MnywDsoeQOZ9nl3sTc4N5RsL4hiEV87En8ZeYPxm9dENO2KoaeD8ub/GUQ?= =?iso-8859-2?Q?SQOIwDm2JYADDRn3nNC2fmgfMZl7LLLsrHRiqUHeJLhR4s6NfVz1jzgE+H?= =?iso-8859-2?Q?2v8E3GPUgXQ44OKoHieNT5vDWTfbpVH9THDcV/ECoD9h5z7BRKXOJIahax?= =?iso-8859-2?Q?ujYC/Wx79ToJ0T7wkql4fItK8owxRifTcuejGqNEEMRsV0yk0P6uXBWQ9b?= =?iso-8859-2?Q?lyTKQra9Q4LjZW8e9b/IN2nDzHZ6/5rsdQSNjaPn5YBpl+gOnIoUstO+BZ?= =?iso-8859-2?Q?myJu1WutnYCCcwTOSBpf3L7jgysROocf7xhQAJWbyLmuJLsM7iXoHGfr6+?= =?iso-8859-2?Q?RgiTE34iqM7S9HpWi2sf3YMSaFr+9H9AoWkvEp6vM5wHYOoLaPYIQWvBF0?= =?iso-8859-2?Q?X58ZXfmywhlGqtkY1hOc5Wie6ZCXAGFIvWD7I2FJMFYBamIvpZqAp4X2it?= =?iso-8859-2?Q?nOgIxXqpySXPNVA0RNaKo1ccENjnka2NSQtLQMzpp9R+UlyiYRl2CSww?= =?iso-8859-2?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB4882.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55c5b108-4bc3-44b6-209e-08dab8afbdf9 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2022 06:43:37.2198 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EBKHHIKR8WBIwP0egQX9Oig++jlD3IUpcLwb1Mek++4Dge8cs75m43r6B9s0xrZTS72jbnDLYB3ko3W10t5LQYsf5GBIpnP3UnjpKWv93Ng= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7414 X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jeff,=0A= =0A= > THe part I don't understand is, if you only have BASE+OFF, why does =0A= > preventing the calculation of more complex addressing modes matter?=A0 ie= , =0A= > what's the point of computing the cost of something like base + off + =0A= > scaled index when the target can't utilize it?=0A= =0A= Well, the complexities of all addressing modes other than BASE + OFFSET are= =0A= equal to 0. For targets like Mips, which only has BASE + OFFSET, it would s= till=0A= be more complex to use a candidate with BASE + INDEX << SCALE + OFFSET=0A= than a candidate with BASE + INDEX, for example, as it has to compensate=0A= the lack of other addressing modes somehow. If complexities for both of=0A= those are equal to 0, in cases where complexities decide which candidate is= =0A= to be chosen, a more complex candidate may be picked.=0A= =0A= Regards,=0A= Dimitrije=0A= =0A= =0A= From: Jeff Law =0A= Sent: Friday, October 28, 2022 1:02 AM=0A= To: Dimitrije Milosevic ; gcc-patches@gcc.g= nu.org =0A= Cc: Djordje Todorovic =0A= Subject: Re: [PATCH 1/2] ivopts: Revert computation of address cost complex= ity. =0A= =A0=0A= =0A= On 10/21/22 07:52, Dimitrije Milosevic wrote:=0A= > From: Dimitrije Milo=B9evi=E6 =0A= >=0A= > This patch reverts the computation of address cost complexity=0A= > to the legacy one. After f9f69dd, complexity is calculated=0A= > using the valid_mem_ref_p target hook. Architectures like=0A= > Mips only allow BASE + OFFSET addressing modes, which in turn=0A= > prevents the calculation of complexity for other addressing=0A= > modes, resulting in non-optimal candidate selection.=0A= >=0A= > gcc/ChangeLog:=0A= >=0A= >=A0=A0=A0=A0=A0=A0=A0 * tree-ssa-address.cc (multiplier_allowed_in_address= _p): Change=0A= >=A0=A0=A0=A0=A0=A0=A0 to non-static.=0A= >=A0=A0=A0=A0=A0=A0=A0 * tree-ssa-address.h (multiplier_allowed_in_address_= p): Declare.=0A= >=A0=A0=A0=A0=A0=A0=A0 * tree-ssa-loop-ivopts.cc (compute_symbol_and_var_pr= esent): Reintroduce.=0A= >=A0=A0=A0=A0=A0=A0=A0 (compute_min_and_max_offset): Likewise.=0A= >=A0=A0=A0=A0=A0=A0=A0 (get_address_cost): Revert=0A= >=A0=A0=A0=A0=A0=A0=A0 complexity calculation.=0A= =0A= THe part I don't understand is, if you only have BASE+OFF, why does =0A= preventing the calculation of more complex addressing modes matter?=A0 ie, = =0A= what's the point of computing the cost of something like base + off + =0A= scaled index when the target can't utilize it?=0A= =0A= =0A= jeff=0A= =0A=