From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-oln040092074079.outbound.protection.outlook.com [40.92.74.79]) by sourceware.org (Postfix) with ESMTPS id 21A69384A030 for ; Wed, 6 Jan 2021 07:52:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 21A69384A030 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WLU2AbCEYYEKZ/jdKj6U//y1MGxPkpeHMubc770tegaFYinYwcGVBURh+p0uvQWCfHFp8rYcfgrRHzIiZ4bSqZpo7gRkO2B88OJ09nxhmiXEKaUnZcoH6BJkRqKukGEdNKt7qIsu+8J0a0d8DjloM8YkrDJQ7e+vy2hRUYSlBtHRK7CFT7uyHzOExhA6eRsBTgsQBuBLaqOYCtzqc9sK0GTMNKHqiRIwQJKRGk589UEYFsy3IKOvmDcIH26Ar5lmcJnVbAI72Se5LMhcStcaNBg1YPB2Y9n57d0sPtXEZJG+wOMArA/2YRCd1mLCFCQ+PC+0yqkjJw1fiILRTgfHYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GWA5ceAKkamsHIDHkDuI4E0ZtMOX6/gEDMaHUkWFzA4=; b=Oy2XC+yKtJQAZXr6qwU2c7nojNIbOtpK+zsX5RTOx8sc4jZgUeSkRc97aIS1GWmWWLmdZe/aJjRB1HC3+S5qbxsQ1COleOHYfuYqaSLorvvdckN5xQgzeTSaqL4kmpkBuUQW5gAM8ou9rGde3CdVIaMjEvWDpfkjOT9Xdw9hw7m1h6tmd5Z4caVVRFfVRZBu9olqY4rlzKm+Oe9CkP167wBN9ljsnateFFMT1bNwwPg2CltC4Q9fiUJXcO5rlz0TW+9Z/JL6AgzkjcggEUVSEB5lB7q6KWNOCDpdyHjZIE2htAAfyIjEFOWg6OTckEnyd8f+2oobu3h8SBURJXFJsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DB3EUR04FT023.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0c::4e) by DB3EUR04HT216.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0c::389) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Wed, 6 Jan 2021 07:52:42 +0000 Received: from AM0PR0602MB3410.eurprd06.prod.outlook.com (2a01:111:e400:7e0c::48) by DB3EUR04FT023.mail.protection.outlook.com (2a01:111:e400:7e0c::138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Wed, 6 Jan 2021 07:52:42 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:5CE81618742D1823190E7A8526B8C6C8BB11FAD7FF2DF06B096DA242DE347140; UpperCasedChecksum:7785B84B74DEFCBCCCAF35AD78DA141AFC3CAD98EC505C15337ED671B198B9E7; SizeAsReceived:8015; Count:47 Received: from AM0PR0602MB3410.eurprd06.prod.outlook.com ([fe80::60c8:86c2:bdaa:f0d2]) by AM0PR0602MB3410.eurprd06.prod.outlook.com ([fe80::60c8:86c2:bdaa:f0d2%3]) with mapi id 15.20.3721.024; Wed, 6 Jan 2021 07:52:42 +0000 Subject: Re: [PATCH] Add line debug info for virtual thunks (PR ipa/97937) To: Jeff Law , "gcc-patches@gcc.gnu.org" , Richard Biener , Jakub Jelinek , Alexandre Oliva References: <6fe16e71-1a72-2c9d-11f2-642f9da8539b@redhat.com> From: Bernd Edlinger Message-ID: Date: Wed, 6 Jan 2021 08:52:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: <6fe16e71-1a72-2c9d-11f2-642f9da8539b@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TMN: [cbOZTuj15r9lgTLfWl9pDfUh41ii8E7K] X-ClientProxiedBy: FR2P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::20) To AM0PR0602MB3410.eurprd06.prod.outlook.com (2603:10a6:208:21::24) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (88.68.3.2) by FR2P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.4 via Frontend Transport; Wed, 6 Jan 2021 07:52:41 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 7ac42d60-0c90-4252-8cd6-08d8b2180c11 X-MS-TrafficTypeDiagnostic: DB3EUR04HT216: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M1pa4bUjlWU7AquOeuZcUpRZLMJmYId1JI+c700NS5eNoZv6zwI2HBfx3yswAqWryIeveAvJmoYMkRBIvQrieSa+ulCgUGWlOSpxtL4WkPJ9r30gg3nxNM2SGbHPmDAB7dxx7zqG9gwQJ1r3LFcqL6j0VmzE2Xz8aSpbH6Ugy7WvkrqpN008CVcfT+Cin3bIRu+pc69IVqOvLFBQA/kvuwFQf0MQfdc/UUQc9zSTPo/SCxRNiQdEXH4324WTTBvt X-MS-Exchange-AntiSpam-MessageData: FrQIBH2HCVI3iXjTHY3ispLxgwDNnX/Mpxq1rtsdA5z0e+i3DUlkIstkkjmbPGghDkW/vtTpZ5iij2PbpTKMBjsJ6IUvnAg+nL9k22lM9LfeEqV1DEAMEGqeBKVd1NqUFPPtnz1Ra+GZh/UX2OfoFA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2021 07:52:42.3661 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: 7ac42d60-0c90-4252-8cd6-08d8b2180c11 X-MS-Exchange-CrossTenant-AuthSource: DB3EUR04FT023.eop-eur04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3EUR04HT216 X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2021 07:52:45 -0000 On 1/4/21 10:45 PM, Jeff Law wrote: > > > On 1/4/21 1:06 PM, Bernd Edlinger wrote: >> --- a/gcc/final.c >> +++ b/gcc/final.c >> @@ -1735,7 +1735,12 @@ final_start_function_1 (rtx_insn **firstp, FILE *file, int *seen, >> last_filename); >> >> if (!dwarf2_debug_info_emitted_p (current_function_decl)) >> - dwarf2out_begin_prologue (0, 0, NULL); >> + { >> + if (write_symbols == DWARF2_DEBUG) >> + dwarf2out_begin_prologue (last_linenum, last_columnnum, last_filename); >> + else >> + dwarf2out_begin_prologue (0, 0, NULL); >> + } > The only way you're getting into this code is for DEBUG_DWARF2 and > VMS_AND_DWARF2_DEBUG and in the latter case we want to make the same > fix.  So drop the newly added conditional and just make the code > something like this: > > > if (!dwarf2_debug_info_emitted_p (current_function_decl)) >  dwarf2out_begin_prologue (last_linenum, last_columnnum, last_filename) > > No, this is block is entered iff (write_symbols != DWARF2_DEBUG && write_symbols != VMS_AND_DWARF2_DEBUG) || DECL_IGNORED (current_function_decl)) so emitting .loc info here could easily break DBX, XCOFF, and VMS w/o DWARF while I have no way to test anything for these debug formats. Bernd.