From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-oln040092068088.outbound.protection.outlook.com [40.92.68.88]) by sourceware.org (Postfix) with ESMTPS id DF8023861826 for ; Mon, 11 Jan 2021 11:13:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DF8023861826 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ktn9cKQFJIXG4C+iHzI2qRYDvc3mw/elM/wF0X6f1qCbDX3gHAKVJkrgvGN0my01ge7DDOmkhKDvAoEp2D9/AAi+KRjMctKJTfWohxUv2WykyzNSRT5GrtGv79pd+lSMjF0VbrCcA0V74IXhnbFOb8WJMYJv0KnUnD+L3Whrfd8f6Y3K7h68jSfgpcp0vVzLJyY6MEBBQ7aCHtYtNJgC9h9TFRNMEW2iLL713g2HZ7z/nhazfcWsa8FyRKFQmkxEkesMxcv7NMsnLWOSnG3JsEZEIU01os/iC3rXubXaZcmpXXq2swABr+GNhAXV7E5wkZWw10HGyx+iqsJidv2opQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hdtkW79l31DMYzHQBMrz6TOaixFU8ts/INRD4u0iJA4=; b=GvkYPT7KxC7kwt8WP4NAACxYsVd7LcHZysQvgSMV0O5Um5K1m5BARAElVIYRJ9jbV5aZ9AElvHg3pdNPAi3YpwxzV2pOcZ5nF+SOIFya7huElFH3spTRecctba1LRXbsR1k/g5KAOMTqaYJjCx/fp+pPc2cmagZnnJ5sAW42WoYkxygS69EMCam6XStXYsotv8BWKi2Tw912Q+ZB2pMX+/ZX7tu4KYylqixv/PQz31i38cn7TEbAUJCXRk9wu1kueC2pbav/Jx80FxIYqTx/HXb0iljlHA/qAVxudRwBoGVvfDvnQ1aXOElIbCTUCsinZDUO0hvZi+XW90a8pQGpbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from HE1EUR02FT031.eop-EUR02.prod.protection.outlook.com (2a01:111:e400:7e1d::40) by HE1EUR02HT191.eop-EUR02.prod.protection.outlook.com (2a01:111:e400:7e1d::350) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Mon, 11 Jan 2021 11:13:41 +0000 Received: from AM0PR0602MB3410.eurprd06.prod.outlook.com (2a01:111:e400:7e1d::4b) by HE1EUR02FT031.mail.protection.outlook.com (2a01:111:e400:7e1d::141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Mon, 11 Jan 2021 11:13:41 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:B3F40EC574A8D1E55CD806C5D1888BDFF586A2B72C724D338C4C31B2C53ACE2E; UpperCasedChecksum:5D4687167FAF501C5DBEB33CFD982DB7A37173AE957262FFE4C26CAC967FC29E; SizeAsReceived:9229; Count:48 Received: from AM0PR0602MB3410.eurprd06.prod.outlook.com ([fe80::60c8:86c2:bdaa:f0d2]) by AM0PR0602MB3410.eurprd06.prod.outlook.com ([fe80::60c8:86c2:bdaa:f0d2%3]) with mapi id 15.20.3742.012; Mon, 11 Jan 2021 11:13:41 +0000 Subject: Re: [PATCH v2] testsuite: Fix test failures from outputs.exp [PR98225] To: David Edelsohn Cc: Rainer Orth , "gcc-patches@gcc.gnu.org" , Mike Stump , Alexandre Oliva References: From: Bernd Edlinger Message-ID: Date: Mon, 11 Jan 2021 12:13:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TMN: [BwKjQEd/N2dnfwZxIBzt+RYXRtrjQKwk] X-ClientProxiedBy: AM0PR02CA0148.eurprd02.prod.outlook.com (2603:10a6:20b:28d::15) To AM0PR0602MB3410.eurprd06.prod.outlook.com (2603:10a6:208:21::24) X-Microsoft-Original-Message-ID: <0cd6284e-93f7-b826-5c09-08c9085af014@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (88.68.3.2) by AM0PR02CA0148.eurprd02.prod.outlook.com (2603:10a6:20b:28d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Mon, 11 Jan 2021 11:13:40 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 9640cd45-816b-4376-8b7c-08d8b621f3c4 X-MS-TrafficTypeDiagnostic: HE1EUR02HT191: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZSnwflfrhs7fLUrhTt/s/ysOIk8e3D8rtff86IHaLoJ++/1Z50+WhsOFRpKjpxaad3xi6vLfa5ADWbPsDHpLOFYnzJnXrUQ0vo1Cd0axmtKaoxcOZWuWJlPnw3S049Z5TYJOJSxvEao7soBvJloikLO+fyF+P8njeOldEf6WJ1G8tkZWmHPBN2/znJ1l3/G1h/bMpli7zLYPW1pJ6WbiHFYGvuPvzJAC6IrpWpjXK+aT3lPf08DejDCtxs6DJTQ7 X-MS-Exchange-AntiSpam-MessageData: UH0xt/PfPn7XNzV451Mc589lGloBilhwNpXztlewJvgT5IURtQf82lfXPu6JQwk0urnkwZZqYpigIVomJSbIb7KajOr1dlfmWmgC8pwlZzEkY6w2ArUcFGxp8RrIkd3uHlSp2bxBfcTgxj+TrqS+mw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2021 11:13:41.1176 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: 9640cd45-816b-4376-8b7c-08d8b621f3c4 X-MS-Exchange-CrossTenant-AuthSource: HE1EUR02FT031.eop-EUR02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR02HT191 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 11:13:46 -0000 On 1/8/21 8:27 PM, David Edelsohn wrote: > Hi, Bernd > > Thanks for investigating this and creating a revised version of the > patch. With the second patch, the gcc.misc-test/outputs.exp results > are clean on AIX. > Many thanks for confirming that the patch works. Is it OK to push? Thanks Bernd. > Thanks, David > > On Fri, Jan 8, 2021 at 1:59 PM Bernd Edlinger wrote: >> >> On 1/8/21 3:23 PM, David Edelsohn wrote: >>> On Thu, Jan 7, 2021 at 5:18 PM Bernd Edlinger wrote: >>>> >>>> Hi, >>>> >>>> On 1/7/21 5:12 PM, Rainer Orth wrote: >>>>> The unsetenv needs to be wrapped in >>>>> >>>>> if [info exists env(MAKEFLAGS)] { >>>>> >>>> >>>> Done. >>>> >>>>> @@ -163,6 +167,9 @@ proc outest { test sources opts dirs out >>>>> if { $ogl != {} } { >>>>> pass "$test: $d$o" >>>>> file delete $ogl >>>>> + } elseif { [string match "*.ld1_args" $o] } { >>>>> + # This file may be missing if !HAVE_GNU_LD >>>>> + pass "$test: $d$o" >>>>> >>>>> Always PASSing the test even if it isn't run is wrong. Either wrap >>>>> the whole group of tests with response files in >>>>> >>>>> if [check_effective_target_gld] { >>>>> >>>>> or make the test for the *.ld1_args file conditional on that >>>>> (e.g. along the lines of $ltop used elsewhere). I'd welcome input >>>>> from Alexandre which is preferred. >>>>> >>>> >>>> Ah, yes that is a good idea. Thanks. >>>> >>>> >>>> I think the .cdtor.* handling, is probably a bad example that I followed here. >>>> I don't know why that is there in the first place, as there >>>> are no C++ test cases, these files should not be created at all. >>>> If they are ever created we would have a couple of other files created >>>> as well IMHO. >>>> If there are still missing files in some cases, >>>> I'd prefer to track these per test case, instead of globally. >>>> >>>> Therefore I propose to remove that exception for now. >>>> >>>> Is it OK for trunk? >>> >>> As Alex said, please don't just remove features and functionality if >>> you don't know why they were added. The history is online in the >>> mailing list and the repo history. >>> >>> AIX uses constructors to register EH frames and libgcc has an EH >>> frame. ctors and dtors can be found in non-C++ code. >>> >> >> Okydoky. >> >> I think I understand now better what the issue is here. >> Although the name cdtor suggests that it has something to do with >> C++ it is also needed to collect EH frame info, in certain targets. >> Those are mainly AIX but also hppa*-*-hpux*. >> I believe those exceptions are only necessary for targets that >> define EH_FRAME_THROUGH_COLLECT2. >> >> I have tested this new version of my patch but only on not-affected >> x86_64-pc-linux-gnu. >> >> @David, @Rainer: I would very much appreciate if you could give this patch >> a test on your systems. >> >> >> Thanks >> Berns.