Re: [PATCH][committed]middle-end: Fix signbit tests when ran on ISA with support for masks.

[Tamar Christina <Tamar.Christina@arm.com>]

Ah yes that particular test checks the vector code.

I see that the function wasn't vectorized but that the scalar replacement was done.


_15 = _4 > 0;



So the test is checking if (-x >> bitsize-1) gets optimized to -(x > 0)

I see that the replacement was made on the scalar correctly so I will modify

The test to check for either the vector is vect_int or the scalar replacement

if not.



Cheers,

Tamar

________________________________
From: Sandra Loosemore <sandra@codesourcery.com>
Sent: Wednesday, November 10, 2021 8:03 PM
To: Tamar Christina <Tamar.Christina@arm.com>; gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>; rguenther@suse.de <rguenther@suse.de>
Subject: Re: [PATCH][committed]middle-end: Fix signbit tests when ran on ISA with support for masks.

On 11/10/21 11:53 AM, Tamar Christina wrote:
> FAIL: gcc.dg/signbit-2.c scan-tree-dump-times optimized
> "[file://\\s+]\\s+<file://s+]//s+>>\\s+{ 0,
> 0, 0, 0 }" 1
>
> That's the old test which this patch has changed. Does it still fail
> with the new patch?

My test results are indeed from a couple days ago.  But, I looked at
your new modifications to this test, and still don't see anything like
the pattern it's looking for, or understand what output you expect to be
happening here.  Is the whole test specific to vector ISAs, and not just
your recent changes to it?  I've attached the .optimized dump I got on
nios2-elf.

-Sandra